HBase
  1. HBase
  2. HBASE-10186

region_mover.rb broken because ServerName constructor is changed to private

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.96.1
    • Fix Version/s: 0.98.0, 0.96.2, 0.99.0
    • Component/s: scripts
    • Labels:
      None
    • Environment:

      x86_64 GNU/Linux

    • Hadoop Flags:
      Reviewed

      Description

      After upgrading to 0.96.1 (from 0.96.0) i have tried rolling restart with ./rolling-restart.sh --graceful but region_mover.rb throws error:

      TypeError: no public constructors for Java::OrgApacheHadoopHbase::ServerName
           getRegions at ./region_mover.rb:257
        unloadRegions at ./region_mover.rb:318
               (root) at ./region_mover.rb:461
      

      After checking region_mover.rb i believe this line:

      return ProtobufUtil::getOnlineRegions(connection.getAdmin(ServerName.new(servername)));
      

      should be changed to

      return ProtobufUtil::getOnlineRegions(connection.getAdmin(ServerName.valueOf(servername)));
      

      After making this change region_mover.rb is working again. I will attach patch shortly.

      1. HBASE-10186.patch
        0.5 kB
        Samir Ahmic

        Issue Links

          Activity

          Hide
          Samir Ahmic added a comment -

          I have attached patch.

          Show
          Samir Ahmic added a comment - I have attached patch.
          Hide
          Ted Yu added a comment -

          +1

          Show
          Ted Yu added a comment - +1
          Hide
          Jonathan Hsieh added a comment -

          lgtm. commiting to 0.96/0.98/trunk. Thanks samir!

          Show
          Jonathan Hsieh added a comment - lgtm. commiting to 0.96/0.98/trunk. Thanks samir!
          Hide
          Hudson added a comment -

          FAILURE: Integrated in hbase-0.96-hadoop2 #152 (See https://builds.apache.org/job/hbase-0.96-hadoop2/152/)
          HBASE-10186 region_mover.rb broken because ServerName constructor is changed to private (Samir Ahmic) (jmhsieh: rev 1551531)

          • /hbase/branches/0.96/bin/region_mover.rb
          Show
          Hudson added a comment - FAILURE: Integrated in hbase-0.96-hadoop2 #152 (See https://builds.apache.org/job/hbase-0.96-hadoop2/152/ ) HBASE-10186 region_mover.rb broken because ServerName constructor is changed to private (Samir Ahmic) (jmhsieh: rev 1551531) /hbase/branches/0.96/bin/region_mover.rb
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in HBase-0.98-on-Hadoop-1.1 #15 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/15/)
          HBASE-10186 region_mover.rb broken because ServerName constructor is changed to private (Samir Ahmic) (jmhsieh: rev 1551533)

          • /hbase/branches/0.98/bin/region_mover.rb
          Show
          Hudson added a comment - SUCCESS: Integrated in HBase-0.98-on-Hadoop-1.1 #15 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/15/ ) HBASE-10186 region_mover.rb broken because ServerName constructor is changed to private (Samir Ahmic) (jmhsieh: rev 1551533) /hbase/branches/0.98/bin/region_mover.rb
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in HBase-0.98 #19 (See https://builds.apache.org/job/HBase-0.98/19/)
          HBASE-10186 region_mover.rb broken because ServerName constructor is changed to private (Samir Ahmic) (jmhsieh: rev 1551533)

          • /hbase/branches/0.98/bin/region_mover.rb
          Show
          Hudson added a comment - SUCCESS: Integrated in HBase-0.98 #19 (See https://builds.apache.org/job/HBase-0.98/19/ ) HBASE-10186 region_mover.rb broken because ServerName constructor is changed to private (Samir Ahmic) (jmhsieh: rev 1551533) /hbase/branches/0.98/bin/region_mover.rb
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in hbase-0.96 #230 (See https://builds.apache.org/job/hbase-0.96/230/)
          HBASE-10186 region_mover.rb broken because ServerName constructor is changed to private (Samir Ahmic) (jmhsieh: rev 1551531)

          • /hbase/branches/0.96/bin/region_mover.rb
          Show
          Hudson added a comment - SUCCESS: Integrated in hbase-0.96 #230 (See https://builds.apache.org/job/hbase-0.96/230/ ) HBASE-10186 region_mover.rb broken because ServerName constructor is changed to private (Samir Ahmic) (jmhsieh: rev 1551531) /hbase/branches/0.96/bin/region_mover.rb
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in HBase-TRUNK #4732 (See https://builds.apache.org/job/HBase-TRUNK/4732/)
          HBASE-10186 region_mover.rb broken because ServerName constructor is changed to private (Samir Ahmic) (jmhsieh: rev 1551532)

          • /hbase/trunk/bin/region_mover.rb
          Show
          Hudson added a comment - SUCCESS: Integrated in HBase-TRUNK #4732 (See https://builds.apache.org/job/HBase-TRUNK/4732/ ) HBASE-10186 region_mover.rb broken because ServerName constructor is changed to private (Samir Ahmic) (jmhsieh: rev 1551532) /hbase/trunk/bin/region_mover.rb
          Hide
          Hudson added a comment -

          FAILURE: Integrated in HBase-TRUNK-on-Hadoop-1.1 #9 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-1.1/9/)
          HBASE-10186 region_mover.rb broken because ServerName constructor is changed to private (Samir Ahmic) (jmhsieh: rev 1551532)

          • /hbase/trunk/bin/region_mover.rb
          Show
          Hudson added a comment - FAILURE: Integrated in HBase-TRUNK-on-Hadoop-1.1 #9 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-1.1/9/ ) HBASE-10186 region_mover.rb broken because ServerName constructor is changed to private (Samir Ahmic) (jmhsieh: rev 1551532) /hbase/trunk/bin/region_mover.rb
          Hide
          Enis Soztutar added a comment -

          Closing this issue after 0.99.0 release.

          Show
          Enis Soztutar added a comment - Closing this issue after 0.99.0 release.

            People

            • Assignee:
              Samir Ahmic
              Reporter:
              Samir Ahmic
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development