Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0.0-beta-1
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Release Note:
      Hide
      We now have slf4j as our front-end. Be careful adding logging from here on out; make sure it slf4j.

      From here on out, as us devs go, we need to convert log messages from being 'guarded' -- i.e. surrounded by if (LOG.isDebugEnabled...) -- to instead being parameterized log messages. e.g. the latter rather than the former in the below:

      logger.debug("The new entry is "+entry+".");
      logger.debug("The new entry is {}.", entry);

      See [1] for background on perf benefits.

      Note, FATAL log level is not present in slf4j. It is noted as a Marker but won't show in logs as a LEVEL.

      1. https://www.slf4j.org/faq.html#logging_performance
      Show
      We now have slf4j as our front-end. Be careful adding logging from here on out; make sure it slf4j. From here on out, as us devs go, we need to convert log messages from being 'guarded' -- i.e. surrounded by if (LOG.isDebugEnabled...) -- to instead being parameterized log messages. e.g. the latter rather than the former in the below: logger.debug("The new entry is "+entry+"."); logger.debug("The new entry is {}.", entry); See [1] for background on perf benefits. Note, FATAL log level is not present in slf4j. It is noted as a Marker but won't show in logs as a LEVEL. 1. https://www.slf4j.org/faq.html#logging_performance

      Description

      Allows logging with less friction. See http://logging.apache.org/log4j/2.x/ This rather radical transition can be done w/ minor change given they have an adapter for apache's logging, the one we use. They also have and adapter for slf4j so we likely can remove at least some of the 4 versions of this module our dependencies make use of.

      I made a start in attached patch but am currently stuck in maven dependency resolve hell courtesy of our slf4j. Fixing will take some concentration and a good net connection, an item I currently lack. Other TODOs are that will need to fix our little log level setting jsp page – will likely have to undo our use of hadoop's tool here – and the config system changes a little.

      I will return to this project soon. Will bring numbers.

        Attachments

        1. 10092.txt
          4 kB
          stack
        2. 10092v2.txt
          4 kB
          stack
        3. HBASE-10092.master.001.patch
          1.90 MB
          Balazs Meszaros
        4. HBASE-10092.master.002.patch
          1.89 MB
          Balazs Meszaros
        5. HBASE-10092.master.003.patch
          2.03 MB
          Balazs Meszaros
        6. HBASE-10092.master.004.patch
          2.05 MB
          Balazs Meszaros
        7. HBASE-10092.patch
          90 kB
          Andrew Purtell
        8. HBASE-10092-addendum.patch
          6 kB
          Duo Zhang
        9. HBASE-10092-addendum-2.master.002.patch
          3 kB
          Appy
        10. HBASE-10092-preview-v0.patch
          102 kB
          Alex Newman

          Issue Links

            Activity

              People

              • Assignee:
                balazs.meszaros Balazs Meszaros
                Reporter:
                stack stack
              • Votes:
                0 Vote for this issue
                Watchers:
                15 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: