Details

    • Type: Sub-task Sub-task
    • Status: Patch Available
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: 2.0.0
    • Component/s: None
    • Labels:
      None

      Description

      Allows logging with less friction. See http://logging.apache.org/log4j/2.x/ This rather radical transition can be done w/ minor change given they have an adapter for apache's logging, the one we use. They also have and adapter for slf4j so we likely can remove at least some of the 4 versions of this module our dependencies make use of.

      I made a start in attached patch but am currently stuck in maven dependency resolve hell courtesy of our slf4j. Fixing will take some concentration and a good net connection, an item I currently lack. Other TODOs are that will need to fix our little log level setting jsp page – will likely have to undo our use of hadoop's tool here – and the config system changes a little.

      I will return to this project soon. Will bring numbers.

      1. HBASE-10092-preview-v0.patch
        102 kB
        Alex Newman
      2. HBASE-10092.patch
        90 kB
        Andrew Purtell
      3. 10092v2.txt
        4 kB
        stack
      4. 10092.txt
        4 kB
        stack

        Issue Links

          Activity

          Hide
          stack added a comment -

          Make sure zkcli works when I am done...see if I can fix the eclipse issue over in HBASE-10073 while I am at it.

          Show
          stack added a comment - Make sure zkcli works when I am done...see if I can fix the eclipse issue over in HBASE-10073 while I am at it.
          Hide
          stack added a comment -

          I need to convert the log4j.properties files to log4j2.xml files.

          Show
          stack added a comment - I need to convert the log4j.properties files to log4j2.xml files.
          Hide
          stack added a comment -

          See how it does...

          Show
          stack added a comment - See how it does...
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12637326/10092v2.txt
          against trunk revision .
          ATTACHMENT ID: 12637326

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          -1 javadoc. The javadoc tool appears to have generated 6 warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          +1 site. The mvn site goal succeeds with this patch.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hbase.client.TestClientScannerRPCTimeout
          org.apache.hadoop.hbase.client.TestMultiParallel
          org.apache.hadoop.hbase.replication.TestReplicationKillMasterRSCompressed
          org.apache.hadoop.hbase.replication.TestReplicationKillMasterRS
          org.apache.hadoop.hbase.fs.TestBlockReorder
          org.apache.hadoop.hbase.replication.TestReplicationKillSlaveRS
          org.apache.hadoop.hbase.snapshot.TestFlushSnapshotFromClient
          org.apache.hadoop.hbase.TestIOFencing
          org.apache.hadoop.hbase.replication.TestReplicationSmallTests
          org.apache.hadoop.hbase.regionserver.wal.TestSecureHLog
          org.apache.hadoop.hbase.replication.TestReplicationDisableInactivePeer
          org.apache.hadoop.hbase.regionserver.wal.TestHLogSplit
          org.apache.hadoop.hbase.client.TestFromClientSide
          org.apache.hadoop.hbase.ipc.TestDelayedRpc
          org.apache.hadoop.hbase.regionserver.wal.TestHLogSplitCompressed
          org.apache.hadoop.hbase.replication.TestReplicationChangingPeerRegionservers
          org.apache.hadoop.hbase.regionserver.wal.TestHLog
          org.apache.hadoop.hbase.filter.TestFilterWithScanLimits
          org.apache.hadoop.hbase.replication.TestReplicationSyncUpTool

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/9123//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9123//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9123//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9123//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9123//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9123//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9123//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9123//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9123//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9123//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/9123//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12637326/10092v2.txt against trunk revision . ATTACHMENT ID: 12637326 +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 javadoc . The javadoc tool appears to have generated 6 warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.client.TestClientScannerRPCTimeout org.apache.hadoop.hbase.client.TestMultiParallel org.apache.hadoop.hbase.replication.TestReplicationKillMasterRSCompressed org.apache.hadoop.hbase.replication.TestReplicationKillMasterRS org.apache.hadoop.hbase.fs.TestBlockReorder org.apache.hadoop.hbase.replication.TestReplicationKillSlaveRS org.apache.hadoop.hbase.snapshot.TestFlushSnapshotFromClient org.apache.hadoop.hbase.TestIOFencing org.apache.hadoop.hbase.replication.TestReplicationSmallTests org.apache.hadoop.hbase.regionserver.wal.TestSecureHLog org.apache.hadoop.hbase.replication.TestReplicationDisableInactivePeer org.apache.hadoop.hbase.regionserver.wal.TestHLogSplit org.apache.hadoop.hbase.client.TestFromClientSide org.apache.hadoop.hbase.ipc.TestDelayedRpc org.apache.hadoop.hbase.regionserver.wal.TestHLogSplitCompressed org.apache.hadoop.hbase.replication.TestReplicationChangingPeerRegionservers org.apache.hadoop.hbase.regionserver.wal.TestHLog org.apache.hadoop.hbase.filter.TestFilterWithScanLimits org.apache.hadoop.hbase.replication.TestReplicationSyncUpTool Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/9123//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9123//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9123//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9123//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9123//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9123//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9123//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9123//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9123//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9123//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/9123//console This message is automatically generated.
          Hide
          Andrew Purtell added a comment - - edited

          The patch from HBASE-11284

          Change summary:

          • 53 files changed, 497 insertions, 531 deletions
          • POM changes: Import log4j2 artifacts only into the compiler classpath. Include the artifacts that wire log4j2 up to commons-logging and slf4j. Exclude log4j1 except in test scope (required by Hadoop). Bring slf4j into test scope also (required by Hadoop, ZooKeeper, and Thrift).
          • org.apache.log4j.Level is an internal implementation detail of 1.x no longer available. Remove all uses.
          • org.apache.log4j.Appender is also an internal implementation detail of 1.x. One unit test and a log management utility requires reimplementation or removal. For now offending code is commented out and marked with TODO
          • Replace log4j.properties files with log4j2.xml and log4j2-test.xml files. Not sure if these are functional yet. May require tweaks if significantly deviating from old behavior. conf/hbase-env.sh and bin/hbase required minor related changes. Haven't figured out how to do custom log levels yet like we had in the old log4j.properties files.
          Show
          Andrew Purtell added a comment - - edited The patch from HBASE-11284 Change summary: 53 files changed, 497 insertions, 531 deletions POM changes: Import log4j2 artifacts only into the compiler classpath. Include the artifacts that wire log4j2 up to commons-logging and slf4j. Exclude log4j1 except in test scope (required by Hadoop). Bring slf4j into test scope also (required by Hadoop, ZooKeeper, and Thrift). org.apache.log4j.Level is an internal implementation detail of 1.x no longer available. Remove all uses. org.apache.log4j.Appender is also an internal implementation detail of 1.x. One unit test and a log management utility requires reimplementation or removal. For now offending code is commented out and marked with TODO Replace log4j.properties files with log4j2.xml and log4j2-test.xml files. Not sure if these are functional yet. May require tweaks if significantly deviating from old behavior. conf/hbase-env.sh and bin/hbase required minor related changes. Haven't figured out how to do custom log levels yet like we had in the old log4j.properties files.
          Hide
          stack added a comment -

          How to progress on this Andrew Purtell?

          + Need to make tgzs and see that stuff lands in right place. Add some excludes for transitive includes of old log4js.
          + Need to try in standalone, pseudo, and cluster and bring up shell to make sure logs are ending up in right place?

          I'd be tempted to just commit something that basically worked and then work out the rest in subsequent issues.

          Show
          stack added a comment - How to progress on this Andrew Purtell ? + Need to make tgzs and see that stuff lands in right place. Add some excludes for transitive includes of old log4js. + Need to try in standalone, pseudo, and cluster and bring up shell to make sure logs are ending up in right place? I'd be tempted to just commit something that basically worked and then work out the rest in subsequent issues.
          Hide
          Andrew Purtell added a comment - - edited

          Need to make tgzs and see that stuff lands in right place. Add some excludes for transitive includes of old log4js.

          I did this and checked mvn dependency:tree. It looks good. I then had to add back log4j 1 and slf4j in test scope so we could actually instantiate Hadoop classes for running unit tests (Java logging is a disaster), not sure what that is going to do in an assembly.

          Need to try in standalone, pseudo, and cluster and bring up shell to make sure logs are ending up in right place

          Yes, the new log4j2.xml files are untested and I'm sure need work.

          Show
          Andrew Purtell added a comment - - edited Need to make tgzs and see that stuff lands in right place. Add some excludes for transitive includes of old log4js. I did this and checked mvn dependency:tree. It looks good. I then had to add back log4j 1 and slf4j in test scope so we could actually instantiate Hadoop classes for running unit tests (Java logging is a disaster), not sure what that is going to do in an assembly. Need to try in standalone, pseudo, and cluster and bring up shell to make sure logs are ending up in right place Yes, the new log4j2.xml files are untested and I'm sure need work.
          Hide
          Alex Newman added a comment -

          Mind if I hope on this patch?

          Show
          Alex Newman added a comment - Mind if I hope on this patch?
          Hide
          Andrew Purtell added a comment -

          Reassigned to Alex Newman. Good luck!

          Show
          Andrew Purtell added a comment - Reassigned to Alex Newman . Good luck!
          Hide
          stack added a comment -

          I think this a hbase 2.0 issue now. Log config format changes which will be too much to take on in a 1.0 hbase (IMO).

          Show
          stack added a comment - I think this a hbase 2.0 issue now. Log config format changes which will be too much to take on in a 1.0 hbase (IMO).
          Hide
          Andrew Purtell added a comment -

          Log config format changes which will be too much to take on in a 1.0 hbase (IMO).

          Was thinking about this also. So let me just propose it then.. What about putting in a log configuration file adapter so we don't have to change our log4j properties files until later? This would be needed if we ever wanted to backport async logging improvements to something like 0.98.

          Show
          Andrew Purtell added a comment - Log config format changes which will be too much to take on in a 1.0 hbase (IMO). Was thinking about this also. So let me just propose it then.. What about putting in a log configuration file adapter so we don't have to change our log4j properties files until later? This would be needed if we ever wanted to backport async logging improvements to something like 0.98.
          Hide
          stack added a comment -

          What about putting in a log configuration file adapter so we don't have to change our log4j properties files until later?

          That'd make it palatable.

          Show
          stack added a comment - What about putting in a log configuration file adapter so we don't have to change our log4j properties files until later? That'd make it palatable.
          Hide
          Matt Sicker added a comment -

          If support for properties files is that important, vote for LOG4J2-635. I personally find them horribly confusing to use in comparison with the XML/JSON/YAML formats, but it seems to be a desired feature.

          Otherwise, you can create a custom ConfigurationFactory to do your own config file parsing and delegation.

          Show
          Matt Sicker added a comment - If support for properties files is that important, vote for LOG4J2-635 . I personally find them horribly confusing to use in comparison with the XML/JSON/YAML formats, but it seems to be a desired feature. Otherwise, you can create a custom ConfigurationFactory to do your own config file parsing and delegation.
          Hide
          Alex Newman added a comment -

          Matt Sicker I don't think properties is a blocker one way or another.

          stack Andrew Purtell
          I am trying to figure out what to do with HttpRequestLogAppender. Is this anything more than trying to get jetty to log to log4j? If so can we just do http://www.eclipse.org/jetty/documentation/current/example-logging-log4j.html?

          Show
          Alex Newman added a comment - Matt Sicker I don't think properties is a blocker one way or another. stack Andrew Purtell I am trying to figure out what to do with HttpRequestLogAppender. Is this anything more than trying to get jetty to log to log4j? If so can we just do http://www.eclipse.org/jetty/documentation/current/example-logging-log4j.html?
          Hide
          Alex Newman added a comment -

          Any reason why we should not consider logback? It looks like supporting unit testing with the new version of surefire is going to be very hard with log4j2

          Show
          Alex Newman added a comment - Any reason why we should not consider logback? It looks like supporting unit testing with the new version of surefire is going to be very hard with log4j2
          Hide
          Nicolas Liochon added a comment -

          The issue I had with common-logging in the past was the lack of MDC (I wanted to log the htrace id). All other wrappers support MDC.

          But naive question: would it make sense to use directly log4j2 instead of using a wrapper?

          Show
          Nicolas Liochon added a comment - The issue I had with common-logging in the past was the lack of MDC (I wanted to log the htrace id). All other wrappers support MDC. But naive question: would it make sense to use directly log4j2 instead of using a wrapper?
          Hide
          Alex Newman added a comment -

          The good news is that I am fairly sure unit tests will not be an issue with log4j2. As far as using it directly, I am game. But it's a much larger change. I think I am very close on this one.

          Show
          Alex Newman added a comment - The good news is that I am fairly sure unit tests will not be an issue with log4j2. As far as using it directly, I am game. But it's a much larger change. I think I am very close on this one.
          Hide
          Nicolas Liochon added a comment -

          Yeah, using it directly is more in the scope of HBASE-11334. Putting a comment there.

          Show
          Nicolas Liochon added a comment - Yeah, using it directly is more in the scope of HBASE-11334 . Putting a comment there.
          Hide
          Andrew Purtell added a comment -

          I don't think properties is a blocker one way or another.

          See Stack's comment above. The change will not be palatable for current or anticipated releases (0.98, 1.0) without properties file compatibility. A trunk only change would still be a great contribution but with less impact. I would really like to see async logging a possibility in 0.98 so will need to do this work at least in that branch.

          Any reason why we should not consider logback? It looks like supporting unit testing with the new version of surefire is going to be very hard with log4j2

          Hadoop is looking at moving up to log4j2 also. What kind of hell will we be in if Hadoop is on log4j2 and we are on logback? Isn't log4j2 the continuation of logback?

          Show
          Andrew Purtell added a comment - I don't think properties is a blocker one way or another. See Stack's comment above. The change will not be palatable for current or anticipated releases (0.98, 1.0) without properties file compatibility. A trunk only change would still be a great contribution but with less impact. I would really like to see async logging a possibility in 0.98 so will need to do this work at least in that branch. Any reason why we should not consider logback? It looks like supporting unit testing with the new version of surefire is going to be very hard with log4j2 Hadoop is looking at moving up to log4j2 also. What kind of hell will we be in if Hadoop is on log4j2 and we are on logback? Isn't log4j2 the continuation of logback?
          Hide
          Andrew Purtell added a comment -

          If support for properties files is that important, vote for LOG4J2-635.

          As requested, Matt Sicker!

          Show
          Andrew Purtell added a comment - If support for properties files is that important, vote for LOG4J2-635 . As requested, Matt Sicker !
          Hide
          Alex Newman added a comment -

          I have attached a preview patch to keep this up to date. You can follow my realtime progress at
          https://github.com/OhmData/hbase-public/tree/10092

          Overall, there's a bunch of stuff I want feedback on.

          1 - What is the purpose of setting the request logger? Setting appenders is a bit more difficult to do in the new log4j2. Perhaps we would be better just upgrading to jetty 9 and using the built in capability. Another option may be using routing.
          2 - Andrew Purtell Why did you leave in the log4j v1 stuff. Is the compatibility the useful part. What am I missing?

          Show
          Alex Newman added a comment - I have attached a preview patch to keep this up to date. You can follow my realtime progress at https://github.com/OhmData/hbase-public/tree/10092 Overall, there's a bunch of stuff I want feedback on. 1 - What is the purpose of setting the request logger? Setting appenders is a bit more difficult to do in the new log4j2. Perhaps we would be better just upgrading to jetty 9 and using the built in capability. Another option may be using routing. 2 - Andrew Purtell Why did you leave in the log4j v1 stuff. Is the compatibility the useful part. What am I missing?
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12664241/HBASE-10092-preview-v0.patch
          against trunk revision .
          ATTACHMENT ID: 12664241

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 99 new or modified tests.

          -1 javac. The applied patch generated 69 javac compiler warnings (more than the trunk's current 45 warnings).

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 javadoc. The javadoc tool appears to have generated 6 warning messages.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          +1 site. The mvn site goal succeeds with this patch.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hbase.util.TestDynamicClassLoader
          org.apache.hadoop.hbase.io.crypto.aes.TestAES
          org.apache.hadoop.hbase.io.crypto.TestKeyProvider
          org.apache.hadoop.hbase.io.crypto.TestCipherProvider
          org.apache.hadoop.hbase.io.crypto.TestEncryption
          org.apache.hadoop.hbase.util.TestCoprocessorClassLoader

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/10572//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10572//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10572//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10572//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10572//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10572//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10572//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10572//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10572//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10572//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10572//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12664241/HBASE-10092-preview-v0.patch against trunk revision . ATTACHMENT ID: 12664241 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 99 new or modified tests. -1 javac . The applied patch generated 69 javac compiler warnings (more than the trunk's current 45 warnings). +1 javac . The applied patch does not increase the total number of javac compiler warnings. -1 javadoc . The javadoc tool appears to have generated 6 warning messages. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.util.TestDynamicClassLoader org.apache.hadoop.hbase.io.crypto.aes.TestAES org.apache.hadoop.hbase.io.crypto.TestKeyProvider org.apache.hadoop.hbase.io.crypto.TestCipherProvider org.apache.hadoop.hbase.io.crypto.TestEncryption org.apache.hadoop.hbase.util.TestCoprocessorClassLoader Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/10572//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10572//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10572//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10572//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10572//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10572//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10572//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10572//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10572//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10572//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10572//console This message is automatically generated.
          Hide
          Andrew Purtell added a comment -

          Why did you leave in the log4j v1 stuff. Is the compatibility the useful part. What am I missing?

          Can you be a bit more specific?

          Show
          Andrew Purtell added a comment - Why did you leave in the log4j v1 stuff. Is the compatibility the useful part. What am I missing? Can you be a bit more specific?
          Hide
          stack added a comment -

          What is the purpose of setting the request logger? Setting appenders is a bit more difficult to do in the new log4j2. Perhaps we would be better just upgrading to jetty 9 and using the built in capability. Another option may be using routing.

          Which request logger? Is this in the http package only? That came in from hadoop recently.

          Show
          stack added a comment - What is the purpose of setting the request logger? Setting appenders is a bit more difficult to do in the new log4j2. Perhaps we would be better just upgrading to jetty 9 and using the built in capability. Another option may be using routing. Which request logger? Is this in the http package only? That came in from hadoop recently.
          Hide
          Alex Newman added a comment -

          Andrew Purtell I meant including log4j v1 in the poms. I've noticed that I needed to include it in a few places for dependencies, but I'm curious what the rational was.

          stack Yes the one in the http package. What exactly does that achieve? I assume it is to consolidate jetty logging through log4j.

          Show
          Alex Newman added a comment - Andrew Purtell I meant including log4j v1 in the poms. I've noticed that I needed to include it in a few places for dependencies, but I'm curious what the rational was. stack Yes the one in the http package. What exactly does that achieve? I assume it is to consolidate jetty logging through log4j.
          Hide
          Andrew Purtell added a comment -

          I meant including log4j v1 in the poms. I've noticed that I needed to include it in a few places for dependencies, but I'm curious what the rational was.

          ​If you don't do that then Hadoop classes won't link.​ We set up Hadoop miniclusters for a lot of unit tests, hbase-testing-util, etc.

          Show
          Andrew Purtell added a comment - I meant including log4j v1 in the poms. I've noticed that I needed to include it in a few places for dependencies, but I'm curious what the rational was. ​If you don't do that then Hadoop classes won't link.​ We set up Hadoop miniclusters for a lot of unit tests, hbase-testing-util, etc.
          Hide
          stack added a comment -

          I moved this out of hbase 1.0. Move back if viable patch in time.

          Show
          stack added a comment - I moved this out of hbase 1.0. Move back if viable patch in time.

            People

            • Assignee:
              Alex Newman
              Reporter:
              stack
            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:

                Development