[HAWQ-1181] Improve the code quality of Apache HAWQ.

• Type: New Feature
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Component/s: Build
• Assignee: Lei Chang
• Reporter: Hong Wu
• Created: 01/Dec/16 05:53
• Updated: 05/Dec/16 18:34

Description

There are several aspects to improve the code quality of Apache HAWQ. All these aspects may relate to some code factors, bug fix, modularization... This is super helpful to the future development of HAWQ project. I try to list some of the aspects in my mind, we can create sub-tasks for these further:

1. Fix compiling warnings.
2. Improve code coverage rate.
3. Fix static check defects(such as clang-check and coverity).
4. Refactor HAWQ with separate modules to help developers write painless unit tests, to help integrate new features from upstream Postgres.
5. HAWQ Code style unification and fix, improve CI and pull requests reviewing process to check this.
6. Decapitate Autotool and rewrite building system using CMake or other libraries.
7. Replace `greenplum` string with `hawq`.

Sub-Tasks

• Fix risky "-Wshift-negative-value, -Wparentheses-equality, -Wtautological-compare" types of compile warnings under osx: Resolved
• Fix "-Wsometimes-uninitialized, -Wsizeof-pointer-memaccess, -Wdangling-else, -Wheader-guard, -Wenum-conversion, -Winvalid-source-encoding" compile warnings under osx: Resolved
• Fix "-Wtautological-constant-out-of-range-compare, -Wtautological-compare, -Wpointer-bool-conversion, -Wnon-literal-null-conversion, -Wincompatible-pointer-types, -Wlogical-not-parentheses" compile warnings under osx.: Resolved
• Fix "Wtypedef-redefinition, Wconstant-logical-operand, Wmemsize-comparison, Wnull-dereference, Wpointer-sign, Wint-conversion" compile warnings.: Resolved
• Fix "-Wimplicit-function-declaration, -Wgnu-variable-sized-type-not-at-end, -Wuninitialized, -Wunused-variable, -Wunused-function, -Wmissing-prototypes, -Wtautological-pointer-compare, -Wincompatible-pointer-types" warnings.: Open