Details

    • Sub-task
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 5.0M15
    • Classlib
    • None
    • Patch Available

    Description

      This failure was found when I trying to test Apache FOP on hdk:
      testCMYK Failure expected:<172> but was:<173>

      After tried to reproduce the issue, I found out that this was not really a bug. The precise value should be 172.992, hdk rounded up it to 173 while RI just truncates it to 172.

      I don't know if we need to fix this for consistency?

      PS: the class CMKYColorSpace in the test case is copied from Apache FOP project, is it ok?

      Attachments

        1. HARMONY-6592.diff
          3 kB
          Lang Yang

        Activity

          tellison Tim Ellison added a comment -

          Lang,

          I applied your patch to the AWT module at repo revision r966188, but I've not included the test case since as you say it is copied from FOP, and I think I'd rather have an originally authored test case, or rely upon using FOP tests to check for regressions.

          How far do we get through FOP now?

          Please verify the patch was applied as expected.

          tellison Tim Ellison added a comment - Lang, I applied your patch to the AWT module at repo revision r966188, but I've not included the test case since as you say it is copied from FOP, and I think I'd rather have an originally authored test case, or rely upon using FOP tests to check for regressions. How far do we get through FOP now? Please verify the patch was applied as expected.
          yanglang Lang Yang added a comment -

          Thanks for the clarification. The patch was applied as expected.

          FOP can be built successful. But the crash issue that reported on http://wiki.apache.org/harmony/Apache_FOP still exist.

          There was one test suit has encountered deadlock issues, it cannot be completed on hdk. Except that one, hdk has passed FOP's tests with 5 failures, 26 errors and 96.79% success rate. I will update the wiki page tomorrow with more details.

          yanglang Lang Yang added a comment - Thanks for the clarification. The patch was applied as expected. FOP can be built successful. But the crash issue that reported on http://wiki.apache.org/harmony/Apache_FOP still exist. There was one test suit has encountered deadlock issues, it cannot be completed on hdk. Except that one, hdk has passed FOP's tests with 5 failures, 26 errors and 96.79% success rate. I will update the wiki page tomorrow with more details.
          hudson Hudson added a comment -

          Integrated in Harmony-1.5-head-linux-x86_64 #901 (See http://hudson.zones.apache.org/hudson/job/Harmony-1.5-head-linux-x86_64/901/)
          Apply patch for HARMONY-6592 ([classlib][awt] Color.getBlue failed on FOP's test case)

          hudson Hudson added a comment - Integrated in Harmony-1.5-head-linux-x86_64 #901 (See http://hudson.zones.apache.org/hudson/job/Harmony-1.5-head-linux-x86_64/901/ ) Apply patch for HARMONY-6592 ( [classlib] [awt] Color.getBlue failed on FOP's test case)

          People

            tellison Tim Ellison
            yanglang Lang Yang
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: