Details

    • Sub-task
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 5.0M15
    • Classlib
    • None
    • Patch Available

    Description

      Implemented method ServiceRegistry.deregisterServiceProvider(java.lang.Object, java.lang.Class)

      Spec - http://java.sun.com/j2se/1.4.2/docs/api/javax/imageio/spi/ServiceRegistry.html#deregisterServiceProvider(java.lang.Object, java.lang.Class)

      Attachments

        1. HARMONY-6518.diff
          4 kB
          Lang Yang

        Activity

          tellison Tim Ellison added a comment -

          Thanks Lang.

          Patch applied to imageio module at repo revision r953364.

          Please check it was applied as you expected.

          p.s. we tend to use (foo == null) rather than the other way around, though I understand why you may do it that way. Better to follow the established style, and in any case removeProvider(Object,Class) has it both ways round!

          tellison Tim Ellison added a comment - Thanks Lang. Patch applied to imageio module at repo revision r953364. Please check it was applied as you expected. p.s. we tend to use (foo == null) rather than the other way around, though I understand why you may do it that way. Better to follow the established style, and in any case removeProvider(Object,Class) has it both ways round!
          leshik Alexei Fedotov added a comment -

          Tim, JFYI, I'm currently applying HARMONY-6507.

          leshik Alexei Fedotov added a comment - Tim, JFYI, I'm currently applying HARMONY-6507 .
          hudson Hudson added a comment -

          Integrated in Harmony-1.5-head-linux-x86_64 #840 (See http://hudson.zones.apache.org/hudson/job/Harmony-1.5-head-linux-x86_64/840/)
          Apply patch for HARMONY-6518 (Implementation of method deregisterServiceProvider(java.lang.Object, java.lang.Class))

          hudson Hudson added a comment - Integrated in Harmony-1.5-head-linux-x86_64 #840 (See http://hudson.zones.apache.org/hudson/job/Harmony-1.5-head-linux-x86_64/840/ ) Apply patch for HARMONY-6518 (Implementation of method deregisterServiceProvider(java.lang.Object, java.lang.Class))
          yanglang Lang Yang added a comment -

          Thanks Tim. It was applied as expected.

          Also thanks for that tip, I saw that expression several times in the existing implementation, so thought it's ok to use it. Anyway, as you have mentioned, I will follow the established style

          yanglang Lang Yang added a comment - Thanks Tim. It was applied as expected. Also thanks for that tip, I saw that expression several times in the existing implementation, so thought it's ok to use it. Anyway, as you have mentioned, I will follow the established style
          hudson Hudson added a comment -

          Integrated in Harmony-select-1.5-head-linux-x86_64 #28 (See http://hudson.zones.apache.org/hudson/job/Harmony-select-1.5-head-linux-x86_64/28/)
          Apply patch for HARMONY-6518 (Implementation of method deregisterServiceProvider(java.lang.Object, java.lang.Class))

          hudson Hudson added a comment - Integrated in Harmony-select-1.5-head-linux-x86_64 #28 (See http://hudson.zones.apache.org/hudson/job/Harmony-select-1.5-head-linux-x86_64/28/ ) Apply patch for HARMONY-6518 (Implementation of method deregisterServiceProvider(java.lang.Object, java.lang.Class))

          People

            tellison Tim Ellison
            yanglang Lang Yang
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: