Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.0M7
    • Component/s: JDK
    • Labels:
      None
    • Environment:
      Should run in all environment.
    • Patch Info:
      Patch Available
    • Estimated Complexity:
      Moderate

      Description

      Changes and new development compared to: https://issues.apache.org/jira/browse/HARMONY-5886

      -BaseFormDialog: represents a base form dialog which will be used to query data of policy entries
      -BaseFormDialog is used for KeystoreEntryEditFormDialog to inherit from, to create a form dialog to view and edit the keystore and the keystore password url entries.
      -Edited policy file is displayed in a text field.
      -Central check and confirmation for unsaved changes before certain operations (exit, open file, start new file).
      -ListAndEditPanel which provides a listing and editing interface for various entities.
      This will be used to list and to provide an entry point for editing grant entries, permissions, principals.
      -The New menu works now
      -GrantEntry and its parts (permissions, principals) are created.

      1. policytool 2008.07.07.patch
        78 kB
        András Belicza
      2. policytool 2008.07.08 empty lines.patch
        63 kB
        András Belicza
      3. screenshot-1.jpg
        47 kB
        András Belicza

        Activity

        Hide
        András Belicza added a comment -

        Looks fine to me.

        Show
        András Belicza added a comment - Looks fine to me.
        Hide
        Sian January added a comment -

        Slightly modified patch applied at r674840.

        Re formatting - for if/else blocks we tend to put the else on the same line as the closing bracket for the if statement, but I've done that for you as I didn't mention it in my previous comment (hence the slightly modified patch).

        Please check that it was applied as you expected apart from this change.

        Show
        Sian January added a comment - Slightly modified patch applied at r674840. Re formatting - for if/else blocks we tend to put the else on the same line as the closing bracket for the if statement, but I've done that for you as I didn't mention it in my previous comment (hence the slightly modified patch). Please check that it was applied as you expected apart from this change.
        Hide
        András Belicza added a comment -

        I removed spaces from the separator lines.
        I override-and-updated before creating this new patch, there is no need to the previous patch "policytool 2008.07.07.patch" (but that info is probably contained in the patch).

        Show
        András Belicza added a comment - I removed spaces from the separator lines. I override-and-updated before creating this new patch, there is no need to the previous patch "policytool 2008.07.07.patch" (but that info is probably contained in the patch).
        Hide
        András Belicza added a comment -

        All right, I correct it and submit a new patch.

        Show
        András Belicza added a comment - All right, I correct it and submit a new patch.
        Hide
        Sian January added a comment -

        It's better that blank lines have no spaces on at all.

        Show
        Sian January added a comment - It's better that blank lines have no spaces on at all.
        Hide
        András Belicza added a comment -

        There might be extra spaces for 2 reasons:
        -I finally set up my eclipse not to use tabs but spaces only. I think that's the expected operational.
        -If a class has 2 methods for example and there's an empty separator between the 2 methods, I usually put 4 spaces in that line (1 tab) so it has the same identation as other rows in the declaration of the class. Is this not intended? Should I use empty lines there with no spaces? And what about inside 1 method? If I have an empty tagging-separator line between 2 operations in a method, should it be an empty line without spaces too? I guess it's prefered to have as many spaces as other lines in that method for identation.

        So which one should I use?

        Show
        András Belicza added a comment - There might be extra spaces for 2 reasons: -I finally set up my eclipse not to use tabs but spaces only. I think that's the expected operational. -If a class has 2 methods for example and there's an empty separator between the 2 methods, I usually put 4 spaces in that line (1 tab) so it has the same identation as other rows in the declaration of the class. Is this not intended? Should I use empty lines there with no spaces? And what about inside 1 method? If I have an empty tagging-separator line between 2 operations in a method, should it be an empty line without spaces too? I guess it's prefered to have as many spaces as other lines in that method for identation. So which one should I use?
        Hide
        Sian January added a comment -

        Thanks for this contribution Andras, it looks like you have made some good progress. I've tried it out and it's working for me now with and without a "-file" argument, but unfortunately the patch isn't very clean. You have several files where the patch is adding extra spaces onto empty lines. If you can upload a clean patch I'll be happy to commit it.

        Show
        Sian January added a comment - Thanks for this contribution Andras, it looks like you have made some good progress. I've tried it out and it's working for me now with and without a "-file" argument, but unfortunately the patch isn't very clean. You have several files where the patch is adding extra spaces onto empty lines. If you can upload a clean patch I'll be happy to commit it.
        Hide
        András Belicza added a comment -

        This is how policytool looked like on July 7, 2008.

        Show
        András Belicza added a comment - This is how policytool looked like on July 7, 2008.

          People

          • Assignee:
            Sian January
            Reporter:
            András Belicza
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development