[HARMONY-5796] [classlib][pack200] Pack200UnpackerAdapter still using Segment

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 5.0M5
• Fix Version/s: 5.0M6
• Component/s: Classlib
• Environment: All pack200 Java 5
• Patch Info: Patch Available
• Estimated Complexity: Novice
• Assignee: Sian January
• Reporter: Andrew Cornwall
• Created: 25/Apr/08 21:10
• Updated: 01/May/08 16:35
• Resolved: 01/May/08 08:12

Description

The Java5 Pack200UnpackerAdapter still uses the old Segment code instead of the new Archive code. Here's a quick patch:

Index: C:/harmony/pack200workspace/Pack200 working/src/main/java5/org/apache/harmony/unpack200/Pack200UnpackerAdapter.java
===================================================================
— C:/harmony/pack200workspace/Pack200 working/src/main/java5/org/apache/harmony/unpack200/Pack200UnpackerAdapter.java (revision 651261)
+++ C:/harmony/pack200workspace/Pack200 working/src/main/java5/org/apache/harmony/unpack200/Pack200UnpackerAdapter.java (working copy)
@@ -46,13 +46,8 @@
"Must specify both input and output streams");
completed(0);
try {

• while (in.available() > 0) { - new Segment().unpack(in, out); - out.flush(); - }
• } catch (Pack200Exception e) { - throw new IOException("Failed to unpack Jar:" + String.valueOf(e)); - }

  + Archive archive = new Archive(in, out);
  + archive.unpack();
  completed(1);
  in.close();
  }