[HARMONY-5086] [drlvm][kernel][geronimo] AnnotatedElement.getDeclaredAnnotations() throws exception if annotation is not available

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Component/s: App-Oriented Bug Reports, DRLVM
• Patch Info: Patch Available
• Assignee: Alexey Varlamov
• Reporter: Vasily Zakharov
• Created: 07/Nov/07 23:10
• Updated: 20/Mar/08 14:39
• Resolved: 16/Nov/07 11:58

Description

When AccessibleObject.getDeclaredAnnotations() is called and the annotation class to be returned cannot be loaded, RI just skips that annotation, and Harmony throws exception.
To reproduce, use the following code:

import java.lang.annotation.*;
import java.lang.reflect.*;
import java.net.*;
public class Test {
public static void main(String[] args) {
try

{ Class cls = Foo.class; Field field = cls.getDeclaredFields()[0]; Constructor constructor = cls.getDeclaredConstructors()[0]; Method method = cls.getDeclaredMethods()[0]; int can = cls.getDeclaredAnnotations().length; int fan = field.getDeclaredAnnotations().length; int nan = constructor.getDeclaredAnnotations().length; int man = method.getDeclaredAnnotations().length; System.out.println("SUCCESS: " + can + " " + fan + " " + nan + " " + man); }

catch (Exception e)

{ e.printStackTrace(System.out); }

}
}

@Retention(RetentionPolicy.RUNTIME)
@interface Ann {}

@Ann class Foo {
@Ann int field;
@Ann Foo() {}
@Ann void method() {}
}

If the test is run normally, both RI and Harmony produce the same result, but if Ann.class file is REMOVED, the output becomes different.

Output on RI and Harmony with Ann.class present:

SUCCESS: 1 1 1

Output on RI with Ann.class removed:

SUCCESS: 0 0 0

Output on Harmony with Ann.class removed:

java.lang.TypeNotPresentException: Type Ann not present
at org.apache.harmony.vm.VMGenericsAndAnnotations.getDeclaredAnnotations(VMGenericsAndAnnotations.java)
at java.lang.reflect.Field$FieldData.getAnnotations(Field.java:457)
at java.lang.reflect.Field.getDeclaredAnnotations(Field.java:42)
at Test.main(Test.java:11)
Caused by: java.lang.NoClassDefFoundError: Ann
at org.apache.harmony.vm.VMGenericsAndAnnotations.getDeclaredAnnotations(VMGenericsAndAnnotations.java)
... 3 more
Caused by: java.lang.ClassNotFoundException: Ann
at java.net.URLClassLoader.findClass(URLClassLoader.java:894)
at java.lang.ClassLoader.loadClass(ClassLoader.java:575)
at java.lang.ClassLoader$SystemClassLoader.loadClass(ClassLoader.java:963)
at java.lang.ClassLoader.loadClass(ClassLoader.java:319)
at org.apache.harmony.vm.VMGenericsAndAnnotations.getDeclaredAnnotations(VMGenericsAndAnnotations.java)
... 3 more

This issue prevents Apache Geronimo 2.0 from starting on Harmony.

Issue Links

• is related to: HARMONY-5005 [drlvm][kernel][geronimo] Field.getGenericType() fails on a parametrized class from custom classloader
• relates to: HARMONY-5180 [drlvm][kernel][geronimo] Annotations get loaded with wrong classloader
• relates to: HARMONY-5622 [drlvm][kernel][geronimo] Method.getGeneric*() methods throw NPE for parametrized interface methods