Uploaded image for project: 'Harmony'
  1. Harmony
  2. HARMONY-4818

[drlvm][verifier] first step towards Java6 BC verification: splitting existing code

    XMLWordPrintableJSON

Details

    • New Feature
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 5.0M4
    • DRLVM
    • None
    • Patch Available

    Description

      as Alexei F noted somewhere Java6 verifier might be obtained from Java5 verifier
      mostly by removing some code.

      Since we all don't want code duplication, it makes sense to split current verifier to
      common part that will be used by both Java5 and Java6 verifiers and Java5-specific
      part.

      I've made such a separation and here is the code for review.
      The modifications made are mostly splitting the files and moving unmodified pieces
      of code around. So, I submitted 'code' rather then 'patch'.

      _base suffix or no suffix means that it's a base part, common for both verifiers

      _x suffix means that the same code operates with different types, it's written with templates. There are 2000+ lines of such a code.

      _5 suffix means pure Java5 code

      I've created a new namespace for _5 code, so that later I'll create different
      Java6-specific types with the same names in Java6-specific namespace

      Please review the code.

      Attachments

        1. verifier-refactoring.zip
          52 kB
          Mikhail Loenko
        2. verifier-refactoring2.zip
          63 kB
          Mikhail Loenko

        Activity

          People

            mloenko Mikhail Loenko
            mloenko Mikhail Loenko
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: