Uploaded image for project: 'Harmony'
  1. Harmony
  2. HARMONY-1564

[drlvm][jit] patch for possible ABCD bug

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: DRLVM
    • Labels:
      None
    • Patch Info:
      Patch Available
    • Estimated Complexity:
      Advanced

      Description

      I've been reading through the ABCD implementation in jitrino, and if I understand it correctly, I found a bug. I've attached a patch to fix it. Someone who actually understands the code should verify this.

      Also, did anyone ever test this ABCD pass? I ask because I've tried running it on a bidirectional bubble sort as mentioned in the original paper. The paper mentions that the pass should be able to prove all of the bounds checks in the sort method as redundant/unnecessary. However, when I try running the abcd pass on a bidirectional bubble sort (attached), none of the bounds checks are eliminated.

      The bidirectional bubble sort program is based on code I found here: http://www.cs.ubc.ca/~harrison/Java/sorting-demo.html

        Attachments

        1. abcd.patch
          0.7 kB
          Naveen Neelakantam
        2. BidirectionalBubbleSort.java
          3 kB
          Naveen Neelakantam
        3. abcd-original.tar.gz
          8 kB
          Egor Pasko
        4. naveen_1.patch
          2 kB
          Naveen Neelakantam
        5. naveen_2.patch
          3 kB
          Naveen Neelakantam

          Issue Links

            Activity

              People

              • Assignee:
                varlax Alexey Varlamov
                Reporter:
                neelakan Naveen Neelakantam
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: