Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Duplicate
    • Affects Version/s: 2.1.0-beta, 3.0.0
    • Fix Version/s: None
    • Component/s: documentation, metrics
    • Labels:
    • Environment:

      trunk

      Description

      In o.a.h.ipc.metrics.RpcMetrics.java, metrics are declared as follows:

         @Metric("Queue time") MutableRate rpcQueueTime;
         @Metric("Processsing time") MutableRate rpcProcessingTime;
      

      Since some users may confuse which unit (sec or msec) is correct, they should be documented.

      1. HADOOP-9913.patch
        2 kB
        Akira AJISAKA
      2. HADOOP-9913.2.patch
        1 kB
        Akira AJISAKA
      3. HADOOP-9913.3.patch
        1 kB
        Akira AJISAKA

        Issue Links

          Activity

          Akira AJISAKA made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Assignee Akira AJISAKA [ ajisakaa ]
          Resolution Duplicate [ 3 ]
          Akira AJISAKA made changes -
          Link This issue duplicates HADOOP-6350 [ HADOOP-6350 ]
          Akira AJISAKA made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Target Version/s 3.0.0 [ 12320357 ] 3.0.0, 2.6.0 [ 12320357, 12327179 ]
          Akira AJISAKA made changes -
          Attachment HADOOP-9913.3.patch [ 12662433 ]
          Allen Wittenauer made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Akira AJISAKA made changes -
          Link This issue relates to HDFS-5144 [ HDFS-5144 ]
          Akira AJISAKA made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Akira AJISAKA made changes -
          Description In o.a.h.hdfs.server.namenode.metrics.NameNodeMetrics.java, metrics are declared as follows:

          {code}
            @Metric("Duration in SafeMode at startup") MutableGaugeInt safeModeTime;
            @Metric("Time loading FS Image at startup") MutableGaugeInt fsImageLoadTime;
          {code}

          Since some users may confuse which unit (sec or msec) is correct, they should be documented.
          In o.a.h.ipc.metrics.RpcMetrics.java, metrics are declared as follows:

          {code}
             @Metric("Queue time") MutableRate rpcQueueTime;
             @Metric("Processsing time") MutableRate rpcProcessingTime;
          {code}

          Since some users may confuse which unit (sec or msec) is correct, they should be documented.
          Akira AJISAKA made changes -
          Description For example, in o.a.h.hdfs.server.namenode.metrics.NameNodeMetrics.java, metrics are declared as follows:

          {code}
            @Metric("Duration in SafeMode at startup") MutableGaugeInt safeModeTime;
            @Metric("Time loading FS Image at startup") MutableGaugeInt fsImageLoadTime;
          {code}

          Since some users may confuse which unit (sec or msec) is correct, they should be documented.
          In o.a.h.hdfs.server.namenode.metrics.NameNodeMetrics.java, metrics are declared as follows:

          {code}
            @Metric("Duration in SafeMode at startup") MutableGaugeInt safeModeTime;
            @Metric("Time loading FS Image at startup") MutableGaugeInt fsImageLoadTime;
          {code}

          Since some users may confuse which unit (sec or msec) is correct, they should be documented.
          Akira AJISAKA made changes -
          Summary Document time unit to RpcMetrics Document time unit to RpcMetrics.java
          Akira AJISAKA made changes -
          Summary Document time unit to metrics Document time unit to RpcMetrics
          Akira AJISAKA made changes -
          Attachment HADOOP-9913.2.patch [ 12600696 ]
          Akira AJISAKA made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Akira AJISAKA made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Akira AJISAKA made changes -
          Field Original Value New Value
          Attachment HADOOP-9913.patch [ 12600480 ]
          Akira AJISAKA created issue -

            People

            • Assignee:
              Unassigned
              Reporter:
              Akira AJISAKA
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development