Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-9849

License information is missing for native CRC32 code

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 2.1.0-beta
    • Fix Version/s: 2.9.0, 3.0.0-alpha4
    • Component/s: None
    • Labels:

      Description

      The following files are licensed under the BSD license but the BSD
      license is not part if the distribution:
      hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/io/compress/lz4/lz4.c
      hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/util/bulk_crc32.c

      I believe this file is BSD as well:
      hadoop-hdfs-project/hadoop-hdfs/src/main/native/util/tree.h

        Activity

        Hide
        tstclair Timothy St. Clair added a comment -

        name change patch

        Show
        tstclair Timothy St. Clair added a comment - name change patch
        Hide
        tstclair Timothy St. Clair added a comment -

        Ready for review.

        Show
        tstclair Timothy St. Clair added a comment - Ready for review.
        Hide
        tstclair Timothy St. Clair added a comment -

        ignore comments, wrong window

        Show
        tstclair Timothy St. Clair added a comment - ignore comments, wrong window
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12596689/HADOOP-9849.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs-httpfs.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2943//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2943//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12596689/HADOOP-9849.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs-httpfs. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2943//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2943//console This message is automatically generated.
        Hide
        templedf Daniel Templeton added a comment -

        This issue seems largely addressed by the current LICENSE.txt file, except for the BSD license on the CRC code. From LICENSE.txt:

        For portions of the native implementation of slicing-by-8 CRC calculation
        in src/main/native/src/org/apache/hadoop/util:
        
        /**
         *   Copyright 2008,2009,2010 Massachusetts Institute of Technology.
         *   All rights reserved. Use of this source code is governed by a
         *   BSD-style license that can be found in the LICENSE file.
         */
        

        There is no "LICENSE file" included that contains the appropriate BSD license. That segment of text looks like it was just copied from the header of the CRC files themselves. Bumping the priority, because licensing is important.

        Show
        templedf Daniel Templeton added a comment - This issue seems largely addressed by the current LICENSE.txt file, except for the BSD license on the CRC code. From LICENSE.txt: For portions of the native implementation of slicing-by-8 CRC calculation in src/main/native/src/org/apache/hadoop/util: /** * Copyright 2008,2009,2010 Massachusetts Institute of Technology. * All rights reserved. Use of this source code is governed by a * BSD-style license that can be found in the LICENSE file. */ There is no "LICENSE file" included that contains the appropriate BSD license. That segment of text looks like it was just copied from the header of the CRC files themselves. Bumping the priority, because licensing is important.
        Hide
        andrew.wang Andrew Wang added a comment -

        I dug up the original code from this link and pasted in the included LICENSE file to our LICENSE.txt:

        http://www.evanjones.ca/crc32c.tar.bz2

        Daniel Templeton could you review? I think this applies to all the branch-2's as well, since this is old code.

        Show
        andrew.wang Andrew Wang added a comment - I dug up the original code from this link and pasted in the included LICENSE file to our LICENSE.txt: http://www.evanjones.ca/crc32c.tar.bz2 Daniel Templeton could you review? I think this applies to all the branch-2's as well, since this is old code.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 19s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 whitespace 0m 0s The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
        +1 asflicense 0m 33s The patch does not generate ASF License warnings.
        1m 16s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:14b5c93
        JIRA Issue HADOOP-9849
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12866081/HADOOP-9849.001.patch
        Optional Tests asflicense
        uname Linux 4f068644c0b7 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / cedaf4c
        whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/12229/artifact/patchprocess/whitespace-eol.txt
        modules C: . U: .
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12229/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 whitespace 0m 0s The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply +1 asflicense 0m 33s The patch does not generate ASF License warnings. 1m 16s Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HADOOP-9849 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12866081/HADOOP-9849.001.patch Optional Tests asflicense uname Linux 4f068644c0b7 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / cedaf4c whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/12229/artifact/patchprocess/whitespace-eol.txt modules C: . U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12229/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        andrew.wang Andrew Wang added a comment -

        Ping Daniel Templeton quick review?

        Show
        andrew.wang Andrew Wang added a comment - Ping Daniel Templeton quick review?
        Hide
        templedf Daniel Templeton added a comment -

        Looks good to me. +1

        Show
        templedf Daniel Templeton added a comment - Looks good to me. +1
        Hide
        templedf Daniel Templeton added a comment -

        Thanks for the patch, Andrew Wang. Committed to trunk and branch-2.

        Show
        templedf Daniel Templeton added a comment - Thanks for the patch, Andrew Wang . Committed to trunk and branch-2.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11807 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11807/)
        HADOOP-9849. License information is missing for native CRC32 code (templedf: rev 92243484f9b868aa18618759145e9dd554e245c5)

        • (edit) LICENSE.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11807 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11807/ ) HADOOP-9849 . License information is missing for native CRC32 code (templedf: rev 92243484f9b868aa18618759145e9dd554e245c5) (edit) LICENSE.txt

          People

          • Assignee:
            andrew.wang Andrew Wang
            Reporter:
            tstclair Timothy St. Clair
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development