Details

    • Type: Bug
    • Status: Open
    • Priority: Critical
    • Resolution: Unresolved
    • Affects Version/s: 2.1.0-beta
    • Fix Version/s: None
    • Component/s: None
    • Labels:

      Description

      The following files are licensed under the BSD license but the BSD
      license is not part if the distribution:
      hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/io/compress/lz4/lz4.c
      hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/util/bulk_crc32.c

      I believe this file is BSD as well:
      hadoop-hdfs-project/hadoop-hdfs/src/main/native/util/tree.h

        Activity

        Hide
        tstclair Timothy St. Clair added a comment -

        name change patch

        Show
        tstclair Timothy St. Clair added a comment - name change patch
        Hide
        tstclair Timothy St. Clair added a comment -

        Ready for review.

        Show
        tstclair Timothy St. Clair added a comment - Ready for review.
        Hide
        tstclair Timothy St. Clair added a comment -

        ignore comments, wrong window

        Show
        tstclair Timothy St. Clair added a comment - ignore comments, wrong window
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12596689/HADOOP-9849.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs-httpfs.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2943//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2943//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12596689/HADOOP-9849.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs-httpfs. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2943//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2943//console This message is automatically generated.
        Hide
        templedf Daniel Templeton added a comment -

        This issue seems largely addressed by the current LICENSE.txt file, except for the BSD license on the CRC code. From LICENSE.txt:

        For portions of the native implementation of slicing-by-8 CRC calculation
        in src/main/native/src/org/apache/hadoop/util:
        
        /**
         *   Copyright 2008,2009,2010 Massachusetts Institute of Technology.
         *   All rights reserved. Use of this source code is governed by a
         *   BSD-style license that can be found in the LICENSE file.
         */
        

        There is no "LICENSE file" included that contains the appropriate BSD license. That segment of text looks like it was just copied from the header of the CRC files themselves. Bumping the priority, because licensing is important.

        Show
        templedf Daniel Templeton added a comment - This issue seems largely addressed by the current LICENSE.txt file, except for the BSD license on the CRC code. From LICENSE.txt: For portions of the native implementation of slicing-by-8 CRC calculation in src/main/native/src/org/apache/hadoop/util: /** * Copyright 2008,2009,2010 Massachusetts Institute of Technology. * All rights reserved. Use of this source code is governed by a * BSD-style license that can be found in the LICENSE file. */ There is no "LICENSE file" included that contains the appropriate BSD license. That segment of text looks like it was just copied from the header of the CRC files themselves. Bumping the priority, because licensing is important.

          People

          • Assignee:
            Unassigned
            Reporter:
            tstclair Timothy St. Clair
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:

              Development