Hadoop Common
  1. Hadoop Common
  2. HADOOP-9822

create constant MAX_CAPACITY in RetryCache rather than hard-coding 16 in RetryCache constructor

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3.0
    • Fix Version/s: 2.8.0
    • Component/s: None
    • Labels:
    • Hadoop Flags:
      Reviewed

      Description

      The magic number "16" is also used in ClientId.BYTE_LENGTH, so hard-coding magic number "16" is a bit confusing.

      1. HADOOP-9822.1.patch
        1 kB
        Tsuyoshi Ozawa
      2. HADOOP-9822.2.patch
        1 kB
        Tsuyoshi Ozawa
      3. HADOOP-9822.3.patch
        1 kB
        Tsuyoshi Ozawa
      4. HADOOP-9822.4.patch
        1 kB
        Tsuyoshi Ozawa

        Issue Links

          Activity

          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12595553/HADOOP-9822.1.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2913//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2913//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12595553/HADOOP-9822.1.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2913//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2913//console This message is automatically generated.
          Hide
          Colin P. McCabe added a comment -

          Looks fine to me. Can we have the constant in caps, like usual?

          Show
          Colin P. McCabe added a comment - Looks fine to me. Can we have the constant in caps, like usual?
          Hide
          Tsuyoshi Ozawa added a comment -

          Thanks for reviewing, Colin.
          Yes, we should change maxCapacity to MAX_CAPACITY as usual.

          Show
          Tsuyoshi Ozawa added a comment - Thanks for reviewing, Colin. Yes, we should change maxCapacity to MAX_CAPACITY as usual.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12596295/HADOOP-9822.2.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2931//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2931//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12596295/HADOOP-9822.2.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2931//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2931//console This message is automatically generated.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12596295/HADOOP-9822.2.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/3495//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3495//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12596295/HADOOP-9822.2.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/3495//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3495//console This message is automatically generated.
          Hide
          Tsuyoshi Ozawa added a comment -

          Rebased on trunk.

          Show
          Tsuyoshi Ozawa added a comment - Rebased on trunk.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12634912/HADOOP-9822.3.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/3676//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3676//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12634912/HADOOP-9822.3.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/3676//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3676//console This message is automatically generated.
          Hide
          Tsuyoshi Ozawa added a comment -

          Colin P. McCabe, do you mind taking a look? I think it's ready for review.

          Show
          Tsuyoshi Ozawa added a comment - Colin P. McCabe , do you mind taking a look? I think it's ready for review.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12634912/HADOOP-9822.3.patch
          against trunk revision 8f1a668.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/4648//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4648//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12634912/HADOOP-9822.3.patch against trunk revision 8f1a668. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/4648//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4648//console This message is automatically generated.
          Hide
          Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 14m 51s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 javac 7m 32s There were no new javac warning messages.
          +1 javadoc 9m 45s There were no new javadoc warning messages.
          +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 1m 6s The applied patch generated 1 new checkstyle issues (total was 14, now 15).
          +1 whitespace 0m 1s The patch has no lines that end in whitespace.
          +1 install 1m 34s mvn install still works.
          +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
          +1 findbugs 1m 42s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
          +1 common tests 23m 41s Tests passed in hadoop-common.
              61m 14s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12634912/HADOOP-9822.3.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 6ae2a0d
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/6443/artifact/patchprocess/diffcheckstylehadoop-common.txt
          hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6443/artifact/patchprocess/testrun_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6443/testReport/
          Java 1.7.0_55
          uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6443/console

          This message was automatically generated.

          Show
          Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 51s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 32s There were no new javac warning messages. +1 javadoc 9m 45s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 1m 6s The applied patch generated 1 new checkstyle issues (total was 14, now 15). +1 whitespace 0m 1s The patch has no lines that end in whitespace. +1 install 1m 34s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 1m 42s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 common tests 23m 41s Tests passed in hadoop-common.     61m 14s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12634912/HADOOP-9822.3.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 6ae2a0d checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/6443/artifact/patchprocess/diffcheckstylehadoop-common.txt hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6443/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6443/testReport/ Java 1.7.0_55 uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6443/console This message was automatically generated.
          Hide
          Haohui Mai added a comment -

          Looks good to me overall.

          private final int MAX_CAPACITY = 16;
          

          Should be private static final.

          Show
          Haohui Mai added a comment - Looks good to me overall. private final int MAX_CAPACITY = 16; Should be private static final.
          Hide
          Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 7m 46s trunk passed
          +1 compile 8m 6s trunk passed with JDK v1.8.0_66
          +1 compile 8m 30s trunk passed with JDK v1.7.0_85
          +1 checkstyle 0m 16s trunk passed
          +1 mvnsite 1m 1s trunk passed
          +1 mvneclipse 0m 14s trunk passed
          -1 findbugs 1m 47s hadoop-common-project/hadoop-common in trunk has 1 extant Findbugs warnings.
          +1 javadoc 0m 53s trunk passed with JDK v1.8.0_66
          +1 javadoc 1m 2s trunk passed with JDK v1.7.0_85
          +1 mvninstall 1m 46s the patch passed
          +1 compile 7m 43s the patch passed with JDK v1.8.0_66
          +1 javac 7m 43s the patch passed
          +1 compile 8m 29s the patch passed with JDK v1.7.0_85
          +1 javac 8m 29s the patch passed
          -1 checkstyle 0m 15s Patch generated 1 new checkstyle issues in hadoop-common-project/hadoop-common (total was 15, now 16).
          +1 mvnsite 1m 0s the patch passed
          +1 mvneclipse 0m 14s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 1m 56s the patch passed
          +1 javadoc 0m 53s the patch passed with JDK v1.8.0_66
          +1 javadoc 1m 2s the patch passed with JDK v1.7.0_85
          -1 unit 7m 6s hadoop-common in the patch failed with JDK v1.8.0_66.
          -1 unit 7m 18s hadoop-common in the patch failed with JDK v1.7.0_85.
          +1 asflicense 0m 23s Patch does not generate ASF License warnings.
          68m 53s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.fs.permission.TestFsPermission
            hadoop.io.compress.TestCompressorDecompressor
          JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.io.compress.lz4.TestLz4CompressorDecompressor
          JDK v1.7.0_85 Failed junit tests hadoop.fs.permission.TestFsPermission
            hadoop.io.compress.TestCompressorDecompressor
          JDK v1.7.0_85 Timed out junit tests org.apache.hadoop.io.compress.lz4.TestLz4CompressorDecompressor



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12634912/HADOOP-9822.3.patch
          JIRA Issue HADOOP-9822
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux d7f0f40e7925 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 077fa52
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/8127/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8127/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8127/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8127/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_85.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8127/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8127/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_85.txt
          JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8127/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Max memory used 75MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8127/console

          This message was automatically generated.

          Show
          Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 46s trunk passed +1 compile 8m 6s trunk passed with JDK v1.8.0_66 +1 compile 8m 30s trunk passed with JDK v1.7.0_85 +1 checkstyle 0m 16s trunk passed +1 mvnsite 1m 1s trunk passed +1 mvneclipse 0m 14s trunk passed -1 findbugs 1m 47s hadoop-common-project/hadoop-common in trunk has 1 extant Findbugs warnings. +1 javadoc 0m 53s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 2s trunk passed with JDK v1.7.0_85 +1 mvninstall 1m 46s the patch passed +1 compile 7m 43s the patch passed with JDK v1.8.0_66 +1 javac 7m 43s the patch passed +1 compile 8m 29s the patch passed with JDK v1.7.0_85 +1 javac 8m 29s the patch passed -1 checkstyle 0m 15s Patch generated 1 new checkstyle issues in hadoop-common-project/hadoop-common (total was 15, now 16). +1 mvnsite 1m 0s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 56s the patch passed +1 javadoc 0m 53s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 2s the patch passed with JDK v1.7.0_85 -1 unit 7m 6s hadoop-common in the patch failed with JDK v1.8.0_66. -1 unit 7m 18s hadoop-common in the patch failed with JDK v1.7.0_85. +1 asflicense 0m 23s Patch does not generate ASF License warnings. 68m 53s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.fs.permission.TestFsPermission   hadoop.io.compress.TestCompressorDecompressor JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.io.compress.lz4.TestLz4CompressorDecompressor JDK v1.7.0_85 Failed junit tests hadoop.fs.permission.TestFsPermission   hadoop.io.compress.TestCompressorDecompressor JDK v1.7.0_85 Timed out junit tests org.apache.hadoop.io.compress.lz4.TestLz4CompressorDecompressor Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12634912/HADOOP-9822.3.patch JIRA Issue HADOOP-9822 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux d7f0f40e7925 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 077fa52 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/8127/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8127/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8127/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8127/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_85.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8127/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8127/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_85.txt JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8127/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Max memory used 75MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8127/console This message was automatically generated.
          Hide
          Tsuyoshi Ozawa added a comment -

          Haohui Mai thank you for taking a look. Updating a patch to make the constant private static final.

          Show
          Tsuyoshi Ozawa added a comment - Haohui Mai thank you for taking a look. Updating a patch to make the constant private static final .
          Hide
          Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 7m 24s trunk passed
          +1 compile 7m 41s trunk passed with JDK v1.8.0_66
          +1 compile 8m 45s trunk passed with JDK v1.7.0_85
          +1 checkstyle 0m 15s trunk passed
          +1 mvnsite 1m 4s trunk passed
          +1 mvneclipse 0m 16s trunk passed
          -1 findbugs 2m 16s hadoop-common-project/hadoop-common in trunk has 1 extant Findbugs warnings.
          +1 javadoc 0m 53s trunk passed with JDK v1.8.0_66
          +1 javadoc 1m 2s trunk passed with JDK v1.7.0_85
          +1 mvninstall 1m 42s the patch passed
          +1 compile 7m 50s the patch passed with JDK v1.8.0_66
          +1 javac 7m 50s the patch passed
          +1 compile 8m 34s the patch passed with JDK v1.7.0_85
          +1 javac 8m 34s the patch passed
          +1 checkstyle 0m 15s the patch passed
          +1 mvnsite 1m 0s the patch passed
          +1 mvneclipse 0m 14s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 1m 58s the patch passed
          +1 javadoc 0m 52s the patch passed with JDK v1.8.0_66
          +1 javadoc 1m 4s the patch passed with JDK v1.7.0_85
          -1 unit 6m 59s hadoop-common in the patch failed with JDK v1.8.0_66.
          -1 unit 7m 19s hadoop-common in the patch failed with JDK v1.7.0_85.
          +1 asflicense 0m 22s Patch does not generate ASF License warnings.
          68m 50s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.fs.permission.TestFsPermission
            hadoop.io.compress.TestCompressorDecompressor
          JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.io.compress.lz4.TestLz4CompressorDecompressor
          JDK v1.7.0_85 Failed junit tests hadoop.fs.permission.TestFsPermission
            hadoop.http.TestHttpServer
            hadoop.security.ssl.TestReloadingX509TrustManager
            hadoop.io.compress.TestCompressorDecompressor
          JDK v1.7.0_85 Timed out junit tests org.apache.hadoop.io.compress.lz4.TestLz4CompressorDecompressor



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12773877/HADOOP-9822.4.patch
          JIRA Issue HADOOP-9822
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux c5b237c16bca 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 298a8cb
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/8140/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8140/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8140/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_85.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8140/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8140/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_85.txt
          JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8140/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Max memory used 78MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8140/console

          This message was automatically generated.

          Show
          Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 24s trunk passed +1 compile 7m 41s trunk passed with JDK v1.8.0_66 +1 compile 8m 45s trunk passed with JDK v1.7.0_85 +1 checkstyle 0m 15s trunk passed +1 mvnsite 1m 4s trunk passed +1 mvneclipse 0m 16s trunk passed -1 findbugs 2m 16s hadoop-common-project/hadoop-common in trunk has 1 extant Findbugs warnings. +1 javadoc 0m 53s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 2s trunk passed with JDK v1.7.0_85 +1 mvninstall 1m 42s the patch passed +1 compile 7m 50s the patch passed with JDK v1.8.0_66 +1 javac 7m 50s the patch passed +1 compile 8m 34s the patch passed with JDK v1.7.0_85 +1 javac 8m 34s the patch passed +1 checkstyle 0m 15s the patch passed +1 mvnsite 1m 0s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 58s the patch passed +1 javadoc 0m 52s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 4s the patch passed with JDK v1.7.0_85 -1 unit 6m 59s hadoop-common in the patch failed with JDK v1.8.0_66. -1 unit 7m 19s hadoop-common in the patch failed with JDK v1.7.0_85. +1 asflicense 0m 22s Patch does not generate ASF License warnings. 68m 50s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.fs.permission.TestFsPermission   hadoop.io.compress.TestCompressorDecompressor JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.io.compress.lz4.TestLz4CompressorDecompressor JDK v1.7.0_85 Failed junit tests hadoop.fs.permission.TestFsPermission   hadoop.http.TestHttpServer   hadoop.security.ssl.TestReloadingX509TrustManager   hadoop.io.compress.TestCompressorDecompressor JDK v1.7.0_85 Timed out junit tests org.apache.hadoop.io.compress.lz4.TestLz4CompressorDecompressor Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12773877/HADOOP-9822.4.patch JIRA Issue HADOOP-9822 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux c5b237c16bca 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 298a8cb findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/8140/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8140/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8140/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_85.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8140/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8140/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_85.txt JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8140/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Max memory used 78MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8140/console This message was automatically generated.
          Hide
          Haohui Mai added a comment -

          +1

          Show
          Haohui Mai added a comment - +1
          Hide
          Haohui Mai added a comment -

          I've committed the patch to trunk and branch-2. Thanks Tsuyoshi Ozawa for the contribution.

          Show
          Haohui Mai added a comment - I've committed the patch to trunk and branch-2. Thanks Tsuyoshi Ozawa for the contribution.
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in Hadoop-trunk-Commit #8865 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8865/)
          HADOOP-9822. create constant MAX_CAPACITY in RetryCache rather than (wheat9: rev 5f269a0ad81bb6abc5242bf628f028ae6812f6b3)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RetryCache.java
          Show
          Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #8865 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8865/ ) HADOOP-9822 . create constant MAX_CAPACITY in RetryCache rather than (wheat9: rev 5f269a0ad81bb6abc5242bf628f028ae6812f6b3) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RetryCache.java
          Hide
          Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2647 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2647/)
          HADOOP-9822. create constant MAX_CAPACITY in RetryCache rather than (wheat9: rev 5f269a0ad81bb6abc5242bf628f028ae6812f6b3)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RetryCache.java
          Show
          Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2647 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2647/ ) HADOOP-9822 . create constant MAX_CAPACITY in RetryCache rather than (wheat9: rev 5f269a0ad81bb6abc5242bf628f028ae6812f6b3) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RetryCache.java
          Hide
          Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #707 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/707/)
          HADOOP-9822. create constant MAX_CAPACITY in RetryCache rather than (wheat9: rev 5f269a0ad81bb6abc5242bf628f028ae6812f6b3)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RetryCache.java
          Show
          Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #707 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/707/ ) HADOOP-9822 . create constant MAX_CAPACITY in RetryCache rather than (wheat9: rev 5f269a0ad81bb6abc5242bf628f028ae6812f6b3) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RetryCache.java
          Hide
          Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #1440 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1440/)
          HADOOP-9822. create constant MAX_CAPACITY in RetryCache rather than (wheat9: rev 5f269a0ad81bb6abc5242bf628f028ae6812f6b3)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RetryCache.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1440 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1440/ ) HADOOP-9822 . create constant MAX_CAPACITY in RetryCache rather than (wheat9: rev 5f269a0ad81bb6abc5242bf628f028ae6812f6b3) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RetryCache.java hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #717 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/717/)
          HADOOP-9822. create constant MAX_CAPACITY in RetryCache rather than (wheat9: rev 5f269a0ad81bb6abc5242bf628f028ae6812f6b3)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RetryCache.java
          Show
          Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #717 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/717/ ) HADOOP-9822 . create constant MAX_CAPACITY in RetryCache rather than (wheat9: rev 5f269a0ad81bb6abc5242bf628f028ae6812f6b3) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RetryCache.java
          Hide
          Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #633 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/633/)
          HADOOP-9822. create constant MAX_CAPACITY in RetryCache rather than (wheat9: rev 5f269a0ad81bb6abc5242bf628f028ae6812f6b3)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RetryCache.java
          Show
          Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #633 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/633/ ) HADOOP-9822 . create constant MAX_CAPACITY in RetryCache rather than (wheat9: rev 5f269a0ad81bb6abc5242bf628f028ae6812f6b3) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RetryCache.java
          Hide
          Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2572 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2572/)
          HADOOP-9822. create constant MAX_CAPACITY in RetryCache rather than (wheat9: rev 5f269a0ad81bb6abc5242bf628f028ae6812f6b3)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RetryCache.java
          Show
          Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2572 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2572/ ) HADOOP-9822 . create constant MAX_CAPACITY in RetryCache rather than (wheat9: rev 5f269a0ad81bb6abc5242bf628f028ae6812f6b3) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RetryCache.java

            People

            • Assignee:
              Tsuyoshi Ozawa
              Reporter:
              Tsuyoshi Ozawa
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development