Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.1.0-beta, 3.0.0-alpha1
    • Fix Version/s: 2.1.0-beta
    • Component/s: tools
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      junit.framework.AssertionFailedError: expected:<r---w-rw-> but was:<r---wxrwx>
      	at junit.framework.Assert.fail(Assert.java:50)
      	at junit.framework.Assert.failNotEquals(Assert.java:287)
      	at junit.framework.Assert.assertEquals(Assert.java:67)
      	at junit.framework.Assert.assertEquals(Assert.java:74)
      	at org.apache.hadoop.tools.TestDistCh.checkFileStatus(TestDistCh.java:197)
      	at org.apache.hadoop.tools.TestDistCh.testDistCh(TestDistCh.java:180)
      

      It has been broken since Jun 14.

        Activity

        Hide
        kihwal Kihwal Lee added a comment -

        Brandon Li: It looks like it has something to do with HDFS-4659. Can you confirm?

        Show
        kihwal Kihwal Lee added a comment - Brandon Li : It looks like it has something to do with HDFS-4659 . Can you confirm?
        Hide
        brandonli Brandon Li added a comment -

        Kihwal Lee Thank you. I think you are right.

        Show
        brandonli Brandon Li added a comment - Kihwal Lee Thank you. I think you are right.
        Hide
        jingzhao Jing Zhao added a comment -

        The UMask is applied only when a file is created with default permission. Update TestDistCh based on this observation.

        Show
        jingzhao Jing Zhao added a comment - The UMask is applied only when a file is created with default permission. Update TestDistCh based on this observation.
        Hide
        hadoopqa Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12592678/HADOOP-9738.001.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-tools/hadoop-extras.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2793//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2793//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12592678/HADOOP-9738.001.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-tools/hadoop-extras. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2793//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2793//console This message is automatically generated.
        Hide
        kihwal Kihwal Lee added a comment -

        +1 The test fix seems to be in line with the other test fixes in HDFS-4659.

        Show
        kihwal Kihwal Lee added a comment - +1 The test fix seems to be in line with the other test fixes in HDFS-4659 .
        Hide
        kihwal Kihwal Lee added a comment -

        Thanks for the patch, Jing. I've committed this to trunk, branch-2 and branch-2.1-beta.

        Show
        kihwal Kihwal Lee added a comment - Thanks for the patch, Jing. I've committed this to trunk, branch-2 and branch-2.1-beta.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-trunk-Commit #4101 (See https://builds.apache.org/job/Hadoop-trunk-Commit/4101/)
        HADOOP-9738. TestDistCh fails. Contributed by Jing Zhao. (kihwal: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1503976)

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-tools/hadoop-extras/src/main/java/org/apache/hadoop/tools/DistCh.java
        • /hadoop/common/trunk/hadoop-tools/hadoop-extras/src/test/java/org/apache/hadoop/tools/TestDistCh.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #4101 (See https://builds.apache.org/job/Hadoop-trunk-Commit/4101/ ) HADOOP-9738 . TestDistCh fails. Contributed by Jing Zhao. (kihwal: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1503976 ) /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-tools/hadoop-extras/src/main/java/org/apache/hadoop/tools/DistCh.java /hadoop/common/trunk/hadoop-tools/hadoop-extras/src/test/java/org/apache/hadoop/tools/TestDistCh.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk #273 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/273/)
        HADOOP-9738. TestDistCh fails. Contributed by Jing Zhao. (kihwal: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1503976)

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-tools/hadoop-extras/src/main/java/org/apache/hadoop/tools/DistCh.java
        • /hadoop/common/trunk/hadoop-tools/hadoop-extras/src/test/java/org/apache/hadoop/tools/TestDistCh.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #273 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/273/ ) HADOOP-9738 . TestDistCh fails. Contributed by Jing Zhao. (kihwal: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1503976 ) /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-tools/hadoop-extras/src/main/java/org/apache/hadoop/tools/DistCh.java /hadoop/common/trunk/hadoop-tools/hadoop-extras/src/test/java/org/apache/hadoop/tools/TestDistCh.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #1463 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1463/)
        HADOOP-9738. TestDistCh fails. Contributed by Jing Zhao. (kihwal: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1503976)

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-tools/hadoop-extras/src/main/java/org/apache/hadoop/tools/DistCh.java
        • /hadoop/common/trunk/hadoop-tools/hadoop-extras/src/test/java/org/apache/hadoop/tools/TestDistCh.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #1463 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1463/ ) HADOOP-9738 . TestDistCh fails. Contributed by Jing Zhao. (kihwal: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1503976 ) /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-tools/hadoop-extras/src/main/java/org/apache/hadoop/tools/DistCh.java /hadoop/common/trunk/hadoop-tools/hadoop-extras/src/test/java/org/apache/hadoop/tools/TestDistCh.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Mapreduce-trunk #1490 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1490/)
        HADOOP-9738. TestDistCh fails. Contributed by Jing Zhao. (kihwal: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1503976)

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-tools/hadoop-extras/src/main/java/org/apache/hadoop/tools/DistCh.java
        • /hadoop/common/trunk/hadoop-tools/hadoop-extras/src/test/java/org/apache/hadoop/tools/TestDistCh.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk #1490 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1490/ ) HADOOP-9738 . TestDistCh fails. Contributed by Jing Zhao. (kihwal: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1503976 ) /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-tools/hadoop-extras/src/main/java/org/apache/hadoop/tools/DistCh.java /hadoop/common/trunk/hadoop-tools/hadoop-extras/src/test/java/org/apache/hadoop/tools/TestDistCh.java

          People

          • Assignee:
            jingzhao Jing Zhao
            Reporter:
            kihwal Kihwal Lee
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development