Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-9729

The example code of org.apache.hadoop.util.Tool is incorrect

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.1.2
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: util
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      see http://hadoop.apache.org/docs/stable/api/org/apache/hadoop/util/Tool.html

      function public int run(String[] args) has no return value in the example code

      1. HADOOP-9729.patch
        0.8 kB
        hellojinjie

        Activity

        Hide
        qwertymaniac Harsh J added a comment -

        This was fixed in trunk and current versions (2.x): http://hadoop.apache.org/docs/current/api/org/apache/hadoop/util/Tool.html

        Show
        qwertymaniac Harsh J added a comment - This was fixed in trunk and current versions (2.x): http://hadoop.apache.org/docs/current/api/org/apache/hadoop/util/Tool.html
        Hide
        hellojinjie hellojinjie added a comment -

        Harsh J why always return 0, regardless of the job status?

        RunningJob runningJob = JobClient.runJob(job);
        if (runningJob.isSuccessful()) {
        return 0;
        } else {
        return -1;
        }

        Show
        hellojinjie hellojinjie added a comment - Harsh J why always return 0, regardless of the job status? RunningJob runningJob = JobClient.runJob(job); if (runningJob.isSuccessful()) { return 0; } else { return -1; }
        Hide
        qwertymaniac Harsh J added a comment -

        Good point, I suppose that can be fixed. Would you like to submit a docs patch for this?

        Show
        qwertymaniac Harsh J added a comment - Good point, I suppose that can be fixed. Would you like to submit a docs patch for this?
        Hide
        hellojinjie hellojinjie added a comment -

        Harsh J OK, I will submit a patch later..
        eeeeh, It seems that I have to learn how to submit a patch ...hehe

        Show
        hellojinjie hellojinjie added a comment - Harsh J OK, I will submit a patch later.. eeeeh, It seems that I have to learn how to submit a patch ...hehe
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12598170/HADOOP-9729.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2986//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2986//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12598170/HADOOP-9729.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2986//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2986//console This message is automatically generated.
        Hide
        hellojinjie hellojinjie added a comment -

        I just modify the comment, so, it's no need to add tests or modify tests.

        Show
        hellojinjie hellojinjie added a comment - I just modify the comment, so, it's no need to add tests or modify tests.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 14m 34s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 7m 27s There were no new javac warning messages.
        +1 javadoc 9m 35s There were no new javadoc warning messages.
        +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 1m 4s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 32s mvn install still works.
        +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
        +1 findbugs 1m 38s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
        +1 common tests 23m 3s Tests passed in hadoop-common.
            59m 54s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12598170/HADOOP-9729.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 57d9a97
        hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6398/artifact/patchprocess/testrun_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6398/testReport/
        Java 1.7.0_55
        uname Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6398/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 34s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 27s There were no new javac warning messages. +1 javadoc 9m 35s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 4s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 32s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 findbugs 1m 38s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 common tests 23m 3s Tests passed in hadoop-common.     59m 54s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12598170/HADOOP-9729.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 57d9a97 hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6398/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6398/testReport/ Java 1.7.0_55 uname Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6398/console This message was automatically generated.
        Hide
        nijel nijel added a comment -

        patch looks good
        +1

        Show
        nijel nijel added a comment - patch looks good +1
        Hide
        jlowe Jason Lowe added a comment -

        +1 lgtm. Committing this.

        Show
        jlowe Jason Lowe added a comment - +1 lgtm. Committing this.
        Hide
        jlowe Jason Lowe added a comment -

        Thanks to hellojinjie for the contribution and to nijel for additional review! I committed this to trunk and branch-2.

        Show
        jlowe Jason Lowe added a comment - Thanks to hellojinjie for the contribution and to nijel for additional review! I committed this to trunk and branch-2.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #7779 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7779/)
        HADOOP-9729. The example code of org.apache.hadoop.util.Tool is incorrect. Contributed by hellojinjie (jlowe: rev ec2748dedbc500bd554aa62ca76ccab593129966)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Tool.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7779 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7779/ ) HADOOP-9729 . The example code of org.apache.hadoop.util.Tool is incorrect. Contributed by hellojinjie (jlowe: rev ec2748dedbc500bd554aa62ca76ccab593129966) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Tool.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #191 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/191/)
        HADOOP-9729. The example code of org.apache.hadoop.util.Tool is incorrect. Contributed by hellojinjie (jlowe: rev ec2748dedbc500bd554aa62ca76ccab593129966)

        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Tool.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #191 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/191/ ) HADOOP-9729 . The example code of org.apache.hadoop.util.Tool is incorrect. Contributed by hellojinjie (jlowe: rev ec2748dedbc500bd554aa62ca76ccab593129966) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Tool.java hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk #922 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/922/)
        HADOOP-9729. The example code of org.apache.hadoop.util.Tool is incorrect. Contributed by hellojinjie (jlowe: rev ec2748dedbc500bd554aa62ca76ccab593129966)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Tool.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #922 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/922/ ) HADOOP-9729 . The example code of org.apache.hadoop.util.Tool is incorrect. Contributed by hellojinjie (jlowe: rev ec2748dedbc500bd554aa62ca76ccab593129966) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Tool.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2120 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2120/)
        HADOOP-9729. The example code of org.apache.hadoop.util.Tool is incorrect. Contributed by hellojinjie (jlowe: rev ec2748dedbc500bd554aa62ca76ccab593129966)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Tool.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2120 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2120/ ) HADOOP-9729 . The example code of org.apache.hadoop.util.Tool is incorrect. Contributed by hellojinjie (jlowe: rev ec2748dedbc500bd554aa62ca76ccab593129966) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Tool.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #180 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/180/)
        HADOOP-9729. The example code of org.apache.hadoop.util.Tool is incorrect. Contributed by hellojinjie (jlowe: rev ec2748dedbc500bd554aa62ca76ccab593129966)

        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Tool.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #180 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/180/ ) HADOOP-9729 . The example code of org.apache.hadoop.util.Tool is incorrect. Contributed by hellojinjie (jlowe: rev ec2748dedbc500bd554aa62ca76ccab593129966) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Tool.java hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #190 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/190/)
        HADOOP-9729. The example code of org.apache.hadoop.util.Tool is incorrect. Contributed by hellojinjie (jlowe: rev ec2748dedbc500bd554aa62ca76ccab593129966)

        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Tool.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #190 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/190/ ) HADOOP-9729 . The example code of org.apache.hadoop.util.Tool is incorrect. Contributed by hellojinjie (jlowe: rev ec2748dedbc500bd554aa62ca76ccab593129966) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Tool.java hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2138 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2138/)
        HADOOP-9729. The example code of org.apache.hadoop.util.Tool is incorrect. Contributed by hellojinjie (jlowe: rev ec2748dedbc500bd554aa62ca76ccab593129966)

        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Tool.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2138 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2138/ ) HADOOP-9729 . The example code of org.apache.hadoop.util.Tool is incorrect. Contributed by hellojinjie (jlowe: rev ec2748dedbc500bd554aa62ca76ccab593129966) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Tool.java hadoop-common-project/hadoop-common/CHANGES.txt

          People

          • Assignee:
            hellojinjie hellojinjie
            Reporter:
            hellojinjie hellojinjie
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 1h
              1h
              Remaining:
              Remaining Estimate - 1h
              1h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development