[HADOOP-9681] FileUtil.unTarUsingJava() should close the InputStream upon finishing

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1-win, 2.1.0-beta, 3.0.0-alpha1
• Fix Version/s: 1-win, 2.1.0-beta
• Target Version/s: 1-win, 2.1.0-beta
• Hadoop Flags: Reviewed
• Assignee: Chuan Liu
• Reporter: Chuan Liu
• Created: 01/Jul/13 18:52
• Updated: 12/May/16 18:25
• Resolved: 02/Jul/13 19:41

Description

In FileUtil.unTarUsingJava() method, we did not close input steams explicitly upon finish. This could lead to a file handle leak on Windows.

I discovered this when investigating the unit test case failure of TestFSDownload.testDownloadArchive(). FSDownload class will use FileUtil.unTarUsingJava() to unpack some temporary archive file. Later, the temporary file should be deleted. Because of the file handle leak, the File.delete() method fails. The test case then fails because it assert the temporary file should not exist.

Issue Links

• is part of: HADOOP-8562 Enhancements to support Hadoop on Windows Server and Windows Azure environments
• relates to: YARN-597 TestFSDownload fails on Windows because of dependencies on tar/gzip/jar tools