[HADOOP-9658] SnappyCodec#checkNativeCodeLoaded may unexpectedly fail when native code is not loaded

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.8.0, 2.7.1, 3.0.0-alpha1
• Target Version/s: 2.7.1
• Hadoop Flags: Reviewed
• Assignee: Zhijie Shen
• Reporter: Zhijie Shen
• Created: 20/Jun/13 09:59
• Updated: 06/Jan/17 01:30
• Resolved: 04/May/15 08:10

Description

  public static void checkNativeCodeLoaded() {
      if (!NativeCodeLoader.buildSupportsSnappy()) {
        throw new RuntimeException("native snappy library not available: " +
            "this version of libhadoop was built without " +
            "snappy support.");
      }
      if (!SnappyCompressor.isNativeCodeLoaded()) {
        throw new RuntimeException("native snappy library not available: " +
            "SnappyCompressor has not been loaded.");
      }
      if (!SnappyDecompressor.isNativeCodeLoaded()) {
        throw new RuntimeException("native snappy library not available: " +
            "SnappyDecompressor has not been loaded.");
      }
  }

buildSupportsSnappy is native method. If the native code is not loaded, the method will be missing. Therefore, whether the native code is loaded or not, the first runtime exception will not be thrown.

Issue Links

• relates to: HADOOP-9665 BlockDecompressorStream#decompress will throw EOFException instead of return -1 when EOF