Hadoop Common
  1. Hadoop Common
  2. HADOOP-9611

mvn-rpmbuild against google-guice > 3.0 yields missing cglib dependency

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.0, 2.1.0-beta
    • Fix Version/s: 2.3.0
    • Component/s: build
    • Labels:

      Description

      Google guice 3.0 repackaged some external dependencies (cglib), which are broken out and exposed when running a mvn-rpmbuild against a stock Fedora 18 machine (3.1.2-6). By adding the explicit dependency, it fixes the error and causes no impact to normal mvn builds.

      1. HADOOP-2.2.0-9611.patch
        2 kB
        Robert Rati
      2. HADOOP-9611.patch
        2 kB
        Timothy St. Clair

        Issue Links

          Activity

          Arun C Murthy made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Arun C Murthy made changes -
          Fix Version/s 2.3.0 [ 12325254 ]
          Fix Version/s 2.4.0 [ 12324587 ]
          Hide
          Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #426 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/426/)
          HADOOP-9611 mvn-rpmbuild against google-guice > 3.0 yields missing cglib dependency (stevel: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1551916)

          • /hadoop/common/trunk
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-project/pom.xml
          • /hadoop/common/trunk/hadoop-tools/hadoop-extras/pom.xml
          • /hadoop/common/trunk/hadoop-tools/hadoop-streaming/pom.xml
          • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/pom.xml
          • /hadoop/common/trunk/hadoop-yarn-project/pom.xml
          Show
          Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #426 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/426/ ) HADOOP-9611 mvn-rpmbuild against google-guice > 3.0 yields missing cglib dependency (stevel: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1551916 ) /hadoop/common/trunk /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-project/pom.xml /hadoop/common/trunk/hadoop-tools/hadoop-extras/pom.xml /hadoop/common/trunk/hadoop-tools/hadoop-streaming/pom.xml /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/pom.xml /hadoop/common/trunk/hadoop-yarn-project/pom.xml
          Hide
          Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #1642 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1642/)
          HADOOP-9611 mvn-rpmbuild against google-guice > 3.0 yields missing cglib dependency (stevel: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1551916)

          • /hadoop/common/trunk
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-project/pom.xml
          • /hadoop/common/trunk/hadoop-tools/hadoop-extras/pom.xml
          • /hadoop/common/trunk/hadoop-tools/hadoop-streaming/pom.xml
          • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/pom.xml
          • /hadoop/common/trunk/hadoop-yarn-project/pom.xml
          Show
          Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #1642 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1642/ ) HADOOP-9611 mvn-rpmbuild against google-guice > 3.0 yields missing cglib dependency (stevel: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1551916 ) /hadoop/common/trunk /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-project/pom.xml /hadoop/common/trunk/hadoop-tools/hadoop-extras/pom.xml /hadoop/common/trunk/hadoop-tools/hadoop-streaming/pom.xml /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/pom.xml /hadoop/common/trunk/hadoop-yarn-project/pom.xml
          Hide
          Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #1616 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1616/)
          HADOOP-9611 mvn-rpmbuild against google-guice > 3.0 yields missing cglib dependency (stevel: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1551916)

          • /hadoop/common/trunk
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-project/pom.xml
          • /hadoop/common/trunk/hadoop-tools/hadoop-extras/pom.xml
          • /hadoop/common/trunk/hadoop-tools/hadoop-streaming/pom.xml
          • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/pom.xml
          • /hadoop/common/trunk/hadoop-yarn-project/pom.xml
          Show
          Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #1616 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1616/ ) HADOOP-9611 mvn-rpmbuild against google-guice > 3.0 yields missing cglib dependency (stevel: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1551916 ) /hadoop/common/trunk /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-project/pom.xml /hadoop/common/trunk/hadoop-tools/hadoop-extras/pom.xml /hadoop/common/trunk/hadoop-tools/hadoop-streaming/pom.xml /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/pom.xml /hadoop/common/trunk/hadoop-yarn-project/pom.xml
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in Hadoop-trunk-Commit #4908 (See https://builds.apache.org/job/Hadoop-trunk-Commit/4908/)
          HADOOP-9611 mvn-rpmbuild against google-guice > 3.0 yields missing cglib dependency (stevel: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1551916)

          • /hadoop/common/trunk
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-project/pom.xml
          • /hadoop/common/trunk/hadoop-tools/hadoop-extras/pom.xml
          • /hadoop/common/trunk/hadoop-tools/hadoop-streaming/pom.xml
          • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/pom.xml
          • /hadoop/common/trunk/hadoop-yarn-project/pom.xml
          Show
          Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #4908 (See https://builds.apache.org/job/Hadoop-trunk-Commit/4908/ ) HADOOP-9611 mvn-rpmbuild against google-guice > 3.0 yields missing cglib dependency (stevel: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1551916 ) /hadoop/common/trunk /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-project/pom.xml /hadoop/common/trunk/hadoop-tools/hadoop-extras/pom.xml /hadoop/common/trunk/hadoop-tools/hadoop-streaming/pom.xml /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/pom.xml /hadoop/common/trunk/hadoop-yarn-project/pom.xml
          Steve Loughran made changes -
          Resolution Fixed [ 1 ]
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Assignee Timothy St. Clair [ tstclair ]
          Fix Version/s 2.4.0 [ 12324587 ]
          Hide
          Steve Loughran added a comment -

          1 committed to branch2. thanks!

          Show
          Steve Loughran added a comment - 1 committed to branch2 . thanks!
          Hide
          Robert Rati added a comment -

          Correct.

          Show
          Robert Rati added a comment - Correct.
          Hide
          Steve Loughran added a comment -

          OK, so the 2.2 patch is intended for branch-2 and then trunk?

          Show
          Steve Loughran added a comment - OK, so the 2.2 patch is intended for branch-2 and then trunk?
          Hide
          Robert Rati added a comment -

          Some additional modules were found to be missing the dependency since the patch was first posted.

          Show
          Robert Rati added a comment - Some additional modules were found to be missing the dependency since the patch was first posted.
          Hide
          Steve Loughran added a comment -

          Tim -why is the 2.2.0 patch bigger than the first? Shouldn't they be the same?

          Show
          Steve Loughran added a comment - Tim -why is the 2.2.0 patch bigger than the first? Shouldn't they be the same?
          Steve Loughran made changes -
          Link This issue is depended upon by HADOOP-9991 [ HADOOP-9991 ]
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12610118/HADOOP-2.2.0-9611.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-tools/hadoop-extras hadoop-tools/hadoop-streaming.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/3245//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3245//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12610118/HADOOP-2.2.0-9611.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-tools/hadoop-extras hadoop-tools/hadoop-streaming. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/3245//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3245//console This message is automatically generated.
          Robert Rati made changes -
          Attachment HADOOP-2.2.0-9611.patch [ 12610118 ]
          Hide
          Timothy St. Clair added a comment -

          patch is ready for review

          Show
          Timothy St. Clair added a comment - patch is ready for review
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12585461/HADOOP-9611.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in .

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2589//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2589//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12585461/HADOOP-9611.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in . +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2589//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2589//console This message is automatically generated.
          Timothy St. Clair made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Timothy St. Clair made changes -
          Component/s build [ 12311543 ]
          Timothy St. Clair made changes -
          Affects Version/s 3.0.0 [ 12320357 ]
          Affects Version/s 2.0.5-beta [ 12324030 ]
          Timothy St. Clair made changes -
          Field Original Value New Value
          Attachment HADOOP-9611.patch [ 12585461 ]
          Hide
          Timothy St. Clair added a comment -

          Update to add cglib to pom dependencies. Patch provided by pmackinn@redhat.com

          Show
          Timothy St. Clair added a comment - Update to add cglib to pom dependencies. Patch provided by pmackinn@redhat.com
          Timothy St. Clair created issue -

            People

            • Assignee:
              Timothy St. Clair
              Reporter:
              Timothy St. Clair
            • Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development