Hadoop Common
  1. Hadoop Common
  2. HADOOP-9605

Update junit dependency

        Details

        • Type: Improvement Improvement
        • Status: Closed
        • Priority: Major Major
        • Resolution: Fixed
        • Affects Version/s: 2.1.0-beta, 3.0.0-alpha1
        • Fix Version/s: 2.1.0-beta
        • Component/s: build
        • Labels:

          Description

          Simple update of the junit dependency to use newer version. E.g. when running maven-rpmbuild on Fedora 18.

          1. File
            HADOOP-9605.patch1
            0.4 kB
            Timothy St. Clair
          2. File
            HADOOP-9605.patch2
            0.9 kB
            Timothy St. Clair

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            Timothy St. Clair added a comment -

            Update JUnit Dep

            Show
            Timothy St. Clair added a comment - Update JUnit Dep
            Hide
            Permalink
            Konstantin Boudnik added a comment -

            While pretty tiny, I'd suggest to split the patch in two:

            • dependency's version bump
            • and update for the rule to be separated
            Show
            Konstantin Boudnik added a comment - While pretty tiny, I'd suggest to split the patch in two: dependency's version bump and update for the rule to be separated
            Hide
            Permalink
            Hadoop QA added a comment -

            -1 overall. Here are the results of testing the latest attachment
            http://issues.apache.org/jira/secure/attachment/12585298/HADOOP-9605.patch
            against trunk revision .

            +1 @author. The patch does not contain any @author tags.

            +1 tests included. The patch appears to include 1 new or modified test files.

            -1 javac. The applied patch generated 1381 javac compiler warnings (more than the trunk's current 1367 warnings).

            +1 javadoc. The javadoc tool did not generate any warning messages.

            +1 eclipse:eclipse. The patch built with eclipse:eclipse.

            +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

            +1 release audit. The applied patch does not increase the total number of release audit warnings.

            +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.

            +1 contrib tests. The patch passed contrib unit tests.

            Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2581//testReport/
            Javac warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/2581//artifact/trunk/patchprocess/diffJavacWarnings.txt
            Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2581//console

            This message is automatically generated.

            Show
            Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12585298/HADOOP-9605.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. -1 javac . The applied patch generated 1381 javac compiler warnings (more than the trunk's current 1367 warnings). +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2581//testReport/ Javac warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/2581//artifact/trunk/patchprocess/diffJavacWarnings.txt Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2581//console This message is automatically generated.
            Hide
            Permalink
            Timothy St. Clair added a comment -

            Patch breakout per Cos's review

            Show
            Timothy St. Clair added a comment - Patch breakout per Cos's review
            Hide
            Permalink
            Konstantin Boudnik added a comment -

            I should've be more explicit - I am sorry - I meant that test update also needs to go to a separate JIRA.

            +1 on the version bump, as it seems that javac warnings are legitimate.

            Show
            Konstantin Boudnik added a comment - I should've be more explicit - I am sorry - I meant that test update also needs to go to a separate JIRA. +1 on the version bump, as it seems that javac warnings are legitimate.
            Hide
            Permalink
            Hadoop QA added a comment -

            -1 overall. Here are the results of testing the latest attachment
            http://issues.apache.org/jira/secure/attachment/12585304/HADOOP-9605.patch2
            against trunk revision .

            +1 @author. The patch does not contain any @author tags.

            +1 tests included. The patch appears to include 1 new or modified test files.

            -1 javac. The patch appears to cause the build to fail.

            Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2582//console

            This message is automatically generated.

            Show
            Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12585304/HADOOP-9605.patch2 against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. -1 javac . The patch appears to cause the build to fail. Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2582//console This message is automatically generated.
            Hide
            Permalink
            Timothy St. Clair added a comment -

            I don't mind splitting up the version bump and the dependency change, but the build will break if they are not both applied. Still want me to separate?

            Show
            Timothy St. Clair added a comment - I don't mind splitting up the version bump and the dependency change, but the build will break if they are not both applied. Still want me to separate?
            Hide
            Permalink
            Konstantin Boudnik added a comment -

            Oh... I am sorry - you right of course. That makes sense - let me commit the patch then.

            Show
            Konstantin Boudnik added a comment - Oh... I am sorry - you right of course. That makes sense - let me commit the patch then.
            Hide
            Permalink
            Hudson added a comment -

            Integrated in Hadoop-trunk-Commit #3812 (See https://builds.apache.org/job/Hadoop-trunk-Commit/3812/)
            HADOOP-9605. Update junit dependency. Contributed by Timothy St. Clair. (Revision 1487980)

            Result = SUCCESS
            cos : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1487980
            Files :

            • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
            • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/test/UnitTestcaseTimeLimit.java
            • /hadoop/common/trunk/hadoop-project/pom.xml
            Show
            Hudson added a comment - Integrated in Hadoop-trunk-Commit #3812 (See https://builds.apache.org/job/Hadoop-trunk-Commit/3812/ ) HADOOP-9605 . Update junit dependency. Contributed by Timothy St. Clair. (Revision 1487980) Result = SUCCESS cos : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1487980 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/test/UnitTestcaseTimeLimit.java /hadoop/common/trunk/hadoop-project/pom.xml
            Hide
            Permalink
            Konstantin Boudnik added a comment -

            I have committed the patch both to trunk and branch-2. Thanks Timothy!

            Show
            Konstantin Boudnik added a comment - I have committed the patch both to trunk and branch-2. Thanks Timothy!
            Hide
            Permalink
            Hudson added a comment -

            Integrated in Hadoop-Yarn-trunk #226 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/226/)
            HADOOP-9605. Update junit dependency. Contributed by Timothy St. Clair. (Revision 1487980)

            Result = SUCCESS
            cos : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1487980
            Files :

            • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
            • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/test/UnitTestcaseTimeLimit.java
            • /hadoop/common/trunk/hadoop-project/pom.xml
            Show
            Hudson added a comment - Integrated in Hadoop-Yarn-trunk #226 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/226/ ) HADOOP-9605 . Update junit dependency. Contributed by Timothy St. Clair. (Revision 1487980) Result = SUCCESS cos : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1487980 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/test/UnitTestcaseTimeLimit.java /hadoop/common/trunk/hadoop-project/pom.xml
            Hide
            Permalink
            Hudson added a comment -

            Integrated in Hadoop-Hdfs-trunk #1416 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1416/)
            HADOOP-9605. Update junit dependency. Contributed by Timothy St. Clair. (Revision 1487980)

            Result = FAILURE
            cos : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1487980
            Files :

            • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
            • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/test/UnitTestcaseTimeLimit.java
            • /hadoop/common/trunk/hadoop-project/pom.xml
            Show
            Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1416 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1416/ ) HADOOP-9605 . Update junit dependency. Contributed by Timothy St. Clair. (Revision 1487980) Result = FAILURE cos : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1487980 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/test/UnitTestcaseTimeLimit.java /hadoop/common/trunk/hadoop-project/pom.xml
            Hide
            Permalink
            Hudson added a comment -

            Integrated in Hadoop-Mapreduce-trunk #1442 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1442/)
            HADOOP-9605. Update junit dependency. Contributed by Timothy St. Clair. (Revision 1487980)

            Result = SUCCESS
            cos : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1487980
            Files :

            • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
            • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/test/UnitTestcaseTimeLimit.java
            • /hadoop/common/trunk/hadoop-project/pom.xml
            Show
            Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1442 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1442/ ) HADOOP-9605 . Update junit dependency. Contributed by Timothy St. Clair. (Revision 1487980) Result = SUCCESS cos : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1487980 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/test/UnitTestcaseTimeLimit.java /hadoop/common/trunk/hadoop-project/pom.xml
            Hide
            Permalink
            Hudson added a comment -

            Integrated in Hadoop-trunk-Commit #3869 (See https://builds.apache.org/job/Hadoop-trunk-Commit/3869/)
            Move HADOP-9131, HADOOP-8957 to release 2.0.1 section and HADOOP-9607, HADOOP-9605 to BUG FIXES (Revision 1490119)

            Result = SUCCESS
            suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1490119
            Files :

            • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
            • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
            Show
            Hudson added a comment - Integrated in Hadoop-trunk-Commit #3869 (See https://builds.apache.org/job/Hadoop-trunk-Commit/3869/ ) Move HADOP-9131, HADOOP-8957 to release 2.0.1 section and HADOOP-9607 , HADOOP-9605 to BUG FIXES (Revision 1490119) Result = SUCCESS suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1490119 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
            Hide
            Permalink
            Hudson added a comment -

            Integrated in Hadoop-Yarn-trunk #232 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/232/)
            Move HADOP-9131, HADOOP-8957 to release 2.0.1 section and HADOOP-9607, HADOOP-9605 to BUG FIXES (Revision 1490119)

            Result = SUCCESS
            suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1490119
            Files :

            • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
            • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
            Show
            Hudson added a comment - Integrated in Hadoop-Yarn-trunk #232 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/232/ ) Move HADOP-9131, HADOOP-8957 to release 2.0.1 section and HADOOP-9607 , HADOOP-9605 to BUG FIXES (Revision 1490119) Result = SUCCESS suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1490119 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
            Hide
            Permalink
            Hudson added a comment -

            Integrated in Hadoop-Hdfs-trunk #1422 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1422/)
            Move HADOP-9131, HADOOP-8957 to release 2.0.1 section and HADOOP-9607, HADOOP-9605 to BUG FIXES (Revision 1490119)

            Result = FAILURE
            suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1490119
            Files :

            • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
            • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
            Show
            Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1422 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1422/ ) Move HADOP-9131, HADOOP-8957 to release 2.0.1 section and HADOOP-9607 , HADOOP-9605 to BUG FIXES (Revision 1490119) Result = FAILURE suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1490119 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
            Hide
            Permalink
            Hudson added a comment -

            Integrated in Hadoop-Mapreduce-trunk #1448 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1448/)
            Move HADOP-9131, HADOOP-8957 to release 2.0.1 section and HADOOP-9607, HADOOP-9605 to BUG FIXES (Revision 1490119)

            Result = SUCCESS
            suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1490119
            Files :

            • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
            • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
            Show
            Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1448 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1448/ ) Move HADOP-9131, HADOOP-8957 to release 2.0.1 section and HADOOP-9607 , HADOOP-9605 to BUG FIXES (Revision 1490119) Result = SUCCESS suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1490119 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt

              People

              • Assignee:
                Unassigned
                Reporter:
                Timothy St. Clair
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Development