Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-9583

test-patch gives +1 despite build failure when running tests

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-alpha1
    • Fix Version/s: 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      I've seen a couple of checkins recently where tests have timed out resulting in a Maven build failure yet test-patch reports an overall +1 on the patch. This is encouraging commits of patches that subsequently break builds.

      1. HADOOP-9583.another_dummy.patch
        3 kB
        Kihwal Lee
      2. HADOOP-9583.patch
        3 kB
        Jason Lowe
      3. HADOOP-9583-dummy.patch
        4 kB
        Kihwal Lee
      4. HADOOP-9583-dummy.patch
        4 kB
        Vinod Kumar Vavilapalli
      5. HADOOP-9583-dummy-without-changes.patch
        0.8 kB
        Vinod Kumar Vavilapalli

        Issue Links

          Activity

          Hide
          jlowe Jason Lowe added a comment -

          An excerpt from the test-patch run on MAPREDUCE-5257 at https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3651//console. Note that surefire times out the TestRMContainerAllocator test and causes the build to fail yet test-patch reports an overall +1:

          [...]
          
          -------------------------------------------------------
           T E S T S
          -------------------------------------------------------
          Running org.apache.hadoop.mapreduce.jobhistory.TestEvents
          Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.016 sec
          Running org.apache.hadoop.mapreduce.jobhistory.TestJobHistoryEventHandler
          Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 10.068 sec
          Running org.apache.hadoop.mapreduce.v2.app.webapp.TestAMWebServices
          Tests run: 11, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 6.121 sec
          Running org.apache.hadoop.mapreduce.v2.app.webapp.TestAMWebServicesAttempts
          Tests run: 15, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 6.714 sec
          Running org.apache.hadoop.mapreduce.v2.app.webapp.TestAMWebServicesJobs
          Tests run: 21, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 9.379 sec
          Running org.apache.hadoop.mapreduce.v2.app.webapp.TestAMWebApp
          Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 11.757 sec
          Running org.apache.hadoop.mapreduce.v2.app.webapp.TestAppController
          Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.865 sec
          Running org.apache.hadoop.mapreduce.v2.app.webapp.TestAMWebServicesJobConf
          Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.297 sec
          Running org.apache.hadoop.mapreduce.v2.app.webapp.TestAMWebServicesTasks
          Tests run: 20, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 7.975 sec
          Running org.apache.hadoop.mapreduce.v2.app.TestJobEndNotifier
          Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 14.536 sec
          Running org.apache.hadoop.mapreduce.v2.app.TestMRClientService
          Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.687 sec
          Running org.apache.hadoop.mapreduce.v2.app.local.TestLocalContainerAllocator
          Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.556 sec
          Running org.apache.hadoop.mapreduce.v2.app.TestRecovery
          Tests run: 12, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 36.474 sec
          Running org.apache.hadoop.mapreduce.v2.app.TestFetchFailure
          Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 13.167 sec
          Running org.apache.hadoop.mapreduce.v2.app.TestTaskHeartbeatHandler
          Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.575 sec
          Running org.apache.hadoop.mapreduce.v2.app.metrics.TestMRAppMetrics
          Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.435 sec
          Running org.apache.hadoop.mapreduce.v2.app.commit.TestCommitterEventHandler
          Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.175 sec
          Running org.apache.hadoop.mapreduce.v2.app.TestAMInfos
          Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.911 sec
          Running org.apache.hadoop.mapreduce.v2.app.TestMRApp
          Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 14.69 sec
          Running org.apache.hadoop.mapreduce.v2.app.TestRMContainerAllocator
          Running org.apache.hadoop.mapreduce.v2.app.TestFail
          Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 11.717 sec
          Running org.apache.hadoop.mapreduce.v2.app.speculate.TestDataStatistics
          Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.059 sec
          Running org.apache.hadoop.mapreduce.v2.app.TestMRAppMaster
          Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.294 sec
          Running org.apache.hadoop.mapreduce.v2.app.job.impl.TestTaskAttemptContainerRequest
          Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.501 sec
          Running org.apache.hadoop.mapreduce.v2.app.job.impl.TestTaskAttempt
          Tests run: 11, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 7.187 sec
          Running org.apache.hadoop.mapreduce.v2.app.job.impl.TestJobImpl
          Tests run: 13, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.338 sec
          Running org.apache.hadoop.mapreduce.v2.app.job.impl.TestMapReduceChildJVM
          Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.709 sec
          Running org.apache.hadoop.mapreduce.v2.app.job.impl.TestTaskImpl
          Tests run: 21, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.532 sec
          Running org.apache.hadoop.mapreduce.v2.app.launcher.TestContainerLauncherImpl
          Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.779 sec
          Running org.apache.hadoop.mapreduce.v2.app.launcher.TestContainerLauncher
          Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 12.952 sec
          Running org.apache.hadoop.mapreduce.v2.app.TestRuntimeEstimators
          Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 43.723 sec
          Running org.apache.hadoop.mapreduce.v2.app.TestStagingCleanup
          Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 23.408 sec
          Running org.apache.hadoop.mapreduce.v2.app.TestKill
          Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 6.97 sec
          Running org.apache.hadoop.mapred.TestTaskAttemptListenerImpl
          Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.066 sec
          
          Results :
          
          Tests run: 213, Failures: 0, Errors: 0, Skipped: 0
          
          [INFO] ------------------------------------------------------------------------
          [INFO] BUILD FAILURE
          [INFO] ------------------------------------------------------------------------
          [INFO] Total time: 4:46.806s
          [INFO] Finished at: Sun May 19 03:58:31 UTC 2013
          [INFO] Final Memory: 19M/290M
          [INFO] ------------------------------------------------------------------------
          [WARNING] The requested profile "native" could not be activated because it does not exist.
          [ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.12.3:test (default-test) on project hadoop-mapreduce-client-app: ExecutionException; nested exception is java.util.concurrent.ExecutionException: java.lang.RuntimeException: The forked VM terminated without saying properly goodbye. VM crash or System.exit called ? -> [Help 1]
          [ERROR] 
          [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
          [ERROR] Re-run Maven using the -X switch to enable full debug logging.
          [ERROR] 
          [ERROR] For more information about the errors and possible solutions, please read the following articles:
          [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
          [INFO] Build failures were ignored.
          /home/jenkins/jenkins-slave/workspace/PreCommit-MAPREDUCE-Build/trunk
          
          [...]
          
          {color:green}+1 overall{color}.  Here are the results of testing the latest attachment 
            http://issues.apache.org/jira/secure/attachment/12583714/MAPREDUCE-5257-20130516.patch
            against trunk revision .
          
              {color:green}+1 @author{color}.  The patch does not contain any @author tags.
          
              {color:green}+1 tests included{color}.  The patch appears to include 1 new or modified test files.
          
              {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.
          
              {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.
          
              {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.
          
              {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.
          
              {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.
          
              {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app.
          
              {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.
          
          Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3651//testReport/
          Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3651//console
          
          Show
          jlowe Jason Lowe added a comment - An excerpt from the test-patch run on MAPREDUCE-5257 at https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3651//console . Note that surefire times out the TestRMContainerAllocator test and causes the build to fail yet test-patch reports an overall +1: [...] ------------------------------------------------------- T E S T S ------------------------------------------------------- Running org.apache.hadoop.mapreduce.jobhistory.TestEvents Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.016 sec Running org.apache.hadoop.mapreduce.jobhistory.TestJobHistoryEventHandler Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 10.068 sec Running org.apache.hadoop.mapreduce.v2.app.webapp.TestAMWebServices Tests run: 11, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 6.121 sec Running org.apache.hadoop.mapreduce.v2.app.webapp.TestAMWebServicesAttempts Tests run: 15, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 6.714 sec Running org.apache.hadoop.mapreduce.v2.app.webapp.TestAMWebServicesJobs Tests run: 21, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 9.379 sec Running org.apache.hadoop.mapreduce.v2.app.webapp.TestAMWebApp Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 11.757 sec Running org.apache.hadoop.mapreduce.v2.app.webapp.TestAppController Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.865 sec Running org.apache.hadoop.mapreduce.v2.app.webapp.TestAMWebServicesJobConf Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.297 sec Running org.apache.hadoop.mapreduce.v2.app.webapp.TestAMWebServicesTasks Tests run: 20, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 7.975 sec Running org.apache.hadoop.mapreduce.v2.app.TestJobEndNotifier Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 14.536 sec Running org.apache.hadoop.mapreduce.v2.app.TestMRClientService Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.687 sec Running org.apache.hadoop.mapreduce.v2.app.local.TestLocalContainerAllocator Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.556 sec Running org.apache.hadoop.mapreduce.v2.app.TestRecovery Tests run: 12, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 36.474 sec Running org.apache.hadoop.mapreduce.v2.app.TestFetchFailure Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 13.167 sec Running org.apache.hadoop.mapreduce.v2.app.TestTaskHeartbeatHandler Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.575 sec Running org.apache.hadoop.mapreduce.v2.app.metrics.TestMRAppMetrics Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.435 sec Running org.apache.hadoop.mapreduce.v2.app.commit.TestCommitterEventHandler Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.175 sec Running org.apache.hadoop.mapreduce.v2.app.TestAMInfos Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.911 sec Running org.apache.hadoop.mapreduce.v2.app.TestMRApp Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 14.69 sec Running org.apache.hadoop.mapreduce.v2.app.TestRMContainerAllocator Running org.apache.hadoop.mapreduce.v2.app.TestFail Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 11.717 sec Running org.apache.hadoop.mapreduce.v2.app.speculate.TestDataStatistics Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.059 sec Running org.apache.hadoop.mapreduce.v2.app.TestMRAppMaster Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.294 sec Running org.apache.hadoop.mapreduce.v2.app.job.impl.TestTaskAttemptContainerRequest Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.501 sec Running org.apache.hadoop.mapreduce.v2.app.job.impl.TestTaskAttempt Tests run: 11, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 7.187 sec Running org.apache.hadoop.mapreduce.v2.app.job.impl.TestJobImpl Tests run: 13, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.338 sec Running org.apache.hadoop.mapreduce.v2.app.job.impl.TestMapReduceChildJVM Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.709 sec Running org.apache.hadoop.mapreduce.v2.app.job.impl.TestTaskImpl Tests run: 21, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.532 sec Running org.apache.hadoop.mapreduce.v2.app.launcher.TestContainerLauncherImpl Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.779 sec Running org.apache.hadoop.mapreduce.v2.app.launcher.TestContainerLauncher Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 12.952 sec Running org.apache.hadoop.mapreduce.v2.app.TestRuntimeEstimators Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 43.723 sec Running org.apache.hadoop.mapreduce.v2.app.TestStagingCleanup Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 23.408 sec Running org.apache.hadoop.mapreduce.v2.app.TestKill Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 6.97 sec Running org.apache.hadoop.mapred.TestTaskAttemptListenerImpl Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.066 sec Results : Tests run: 213, Failures: 0, Errors: 0, Skipped: 0 [INFO] ------------------------------------------------------------------------ [INFO] BUILD FAILURE [INFO] ------------------------------------------------------------------------ [INFO] Total time: 4:46.806s [INFO] Finished at: Sun May 19 03:58:31 UTC 2013 [INFO] Final Memory: 19M/290M [INFO] ------------------------------------------------------------------------ [WARNING] The requested profile "native" could not be activated because it does not exist. [ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.12.3:test (default-test) on project hadoop-mapreduce-client-app: ExecutionException; nested exception is java.util.concurrent.ExecutionException: java.lang.RuntimeException: The forked VM terminated without saying properly goodbye. VM crash or System.exit called ? -> [Help 1] [ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch. [ERROR] Re-run Maven using the -X switch to enable full debug logging. [ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles: [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException [INFO] Build failures were ignored. /home/jenkins/jenkins-slave/workspace/PreCommit-MAPREDUCE-Build/trunk [...] {color:green}+1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12583714/MAPREDUCE-5257-20130516.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 1 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 core tests{color}. The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app. {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3651//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3651//console
          Hide
          atm Aaron T. Myers added a comment -

          Yes, this is the reason we briefly had a requirement that all tests have an @timeout annotation. In this comment I also suggested a way that we could make test-patch detect timed out tests automatically based on exactly the sort of output you pasted here.

          Show
          atm Aaron T. Myers added a comment - Yes, this is the reason we briefly had a requirement that all tests have an @timeout annotation. In this comment I also suggested a way that we could make test-patch detect timed out tests automatically based on exactly the sort of output you pasted here.
          Hide
          jlowe Jason Lowe added a comment -

          Sure, that sounds reasonable. If that's not reliable I'm even OK with test-patch simply commenting along the lines of "-1 tests. The test build failed" and leave it up to someone to dig through the console output to figure out what happened. The worst thing to do is ignore the build failure which is what it does today. Maybe a combination of the two approaches? Look for tests that timeout and call them out individually if found, but even if none are found don't allow a build failure to result in a +1 for the patch.

          Show
          jlowe Jason Lowe added a comment - Sure, that sounds reasonable. If that's not reliable I'm even OK with test-patch simply commenting along the lines of "-1 tests. The test build failed" and leave it up to someone to dig through the console output to figure out what happened. The worst thing to do is ignore the build failure which is what it does today. Maybe a combination of the two approaches? Look for tests that timeout and call them out individually if found, but even if none are found don't allow a build failure to result in a +1 for the patch.
          Hide
          atm Aaron T. Myers added a comment -

          All makes sense to me. I'm cool with any of these approaches. Agree that the current state of affairs is the worst scenario.

          Show
          atm Aaron T. Myers added a comment - All makes sense to me. I'm cool with any of these approaches. Agree that the current state of affairs is the worst scenario.
          Hide
          jlowe Jason Lowe added a comment -

          Patch to try to implement the double-pronged approach. Maven is now executed with -fae rather than -fn so we can get a proper exit code for test builds. The test build output is also collected for post-processing to look for tests that timed out.

          Show
          jlowe Jason Lowe added a comment - Patch to try to implement the double-pronged approach. Maven is now executed with -fae rather than -fn so we can get a proper exit code for test builds. The test build output is also collected for post-processing to look for tests that timed out.
          Hide
          hadoopqa Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12584540/HADOOP-9583.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in .

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2559//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2559//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12584540/HADOOP-9583.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in . +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2559//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2559//console This message is automatically generated.
          Hide
          vinodkv Vinod Kumar Vavilapalli added a comment -

          I am looking at this for commit, as it's been a real pain..

          Show
          vinodkv Vinod Kumar Vavilapalli added a comment - I am looking at this for commit, as it's been a real pain..
          Hide
          vinodkv Vinod Kumar Vavilapalli added a comment -

          TestMRJobs is timing out now, a dummy patch to see if the changes help Jenkins catch it..

          Show
          vinodkv Vinod Kumar Vavilapalli added a comment - TestMRJobs is timing out now, a dummy patch to see if the changes help Jenkins catch it..
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12588725/HADOOP-9583-dummy.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 2 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient:

          org.apache.hadoop.mapreduce.lib.aggregate.TestMapReduceAggregates
          org.apache.hadoop.mapreduce.v2.TestMiniMRProxyUser
          org.apache.hadoop.mapreduce.lib.input.TestMRSequenceFileAsTextInputFormat
          org.apache.hadoop.mapreduce.lib.input.TestMultipleInputs
          org.apache.hadoop.mapreduce.lib.output.TestMRSequenceFileAsBinaryOutputFormat
          org.apache.hadoop.mapreduce.lib.output.TestJobOutputCommitter
          org.apache.hadoop.mapreduce.security.TestJHSSecurity
          org.apache.hadoop.mapreduce.v2.TestMRJobs
          org.apache.hadoop.mapreduce.lib.input.TestLineRecordReader
          org.apache.hadoop.mapreduce.lib.db.TestDataDrivenDBInputFormat
          org.apache.hadoop.mapred.TestMapRed
          org.apache.hadoop.mapreduce.lib.join.TestJoinDatamerge
          org.apache.hadoop.mapreduce.v2.TestSpeculativeExecution
          org.apache.hadoop.mapreduce.lib.output.TestFileOutputCommitter
          org.apache.hadoop.mapreduce.v2.TestUberAM
          org.apache.hadoop.mapreduce.TestChild
          org.apache.hadoop.mapreduce.TestMapReduceLazyOutput
          org.apache.hadoop.mapreduce.lib.chain.TestMapReduceChain
          org.apache.hadoop.mapreduce.v2.TestMRAppWithCombiner
          org.apache.hadoop.mapreduce.TestMRJobClient
          org.apache.hadoop.mapreduce.lib.fieldsel.TestMRFieldSelection
          org.apache.hadoop.mapreduce.lib.input.TestMRSequenceFileInputFilter
          org.apache.hadoop.mapreduce.lib.input.TestMRSequenceFileAsBinaryInputFormat
          org.apache.hadoop.mapreduce.TestValueIterReset
          org.apache.hadoop.mapreduce.lib.jobcontrol.TestMapReduceJobControl
          org.apache.hadoop.mapreduce.lib.output.TestMRMultipleOutputs
          org.apache.hadoop.mapreduce.v2.TestMROldApiJobs
          org.apache.hadoop.mapreduce.TestMapCollection
          org.apache.hadoop.mapreduce.lib.chain.TestChainErrors
          org.apache.hadoop.mapreduce.lib.map.TestMultithreadedMapper
          org.apache.hadoop.mapreduce.lib.chain.TestSingleElementChain
          org.apache.hadoop.mapreduce.v2.TestMRJobsWithHistoryService
          org.apache.hadoop.mapreduce.lib.partition.TestMRKeyFieldBasedComparator
          org.apache.hadoop.mapreduce.TestLocalRunner
          org.apache.hadoop.mapreduce.lib.input.TestNLineInputFormat
          org.apache.hadoop.mapreduce.lib.input.TestFileInputFormat
          org.apache.hadoop.mapreduce.lib.input.TestCombineFileInputFormat

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2679//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2679//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12588725/HADOOP-9583-dummy.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 2 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient: org.apache.hadoop.mapreduce.lib.aggregate.TestMapReduceAggregates org.apache.hadoop.mapreduce.v2.TestMiniMRProxyUser org.apache.hadoop.mapreduce.lib.input.TestMRSequenceFileAsTextInputFormat org.apache.hadoop.mapreduce.lib.input.TestMultipleInputs org.apache.hadoop.mapreduce.lib.output.TestMRSequenceFileAsBinaryOutputFormat org.apache.hadoop.mapreduce.lib.output.TestJobOutputCommitter org.apache.hadoop.mapreduce.security.TestJHSSecurity org.apache.hadoop.mapreduce.v2.TestMRJobs org.apache.hadoop.mapreduce.lib.input.TestLineRecordReader org.apache.hadoop.mapreduce.lib.db.TestDataDrivenDBInputFormat org.apache.hadoop.mapred.TestMapRed org.apache.hadoop.mapreduce.lib.join.TestJoinDatamerge org.apache.hadoop.mapreduce.v2.TestSpeculativeExecution org.apache.hadoop.mapreduce.lib.output.TestFileOutputCommitter org.apache.hadoop.mapreduce.v2.TestUberAM org.apache.hadoop.mapreduce.TestChild org.apache.hadoop.mapreduce.TestMapReduceLazyOutput org.apache.hadoop.mapreduce.lib.chain.TestMapReduceChain org.apache.hadoop.mapreduce.v2.TestMRAppWithCombiner org.apache.hadoop.mapreduce.TestMRJobClient org.apache.hadoop.mapreduce.lib.fieldsel.TestMRFieldSelection org.apache.hadoop.mapreduce.lib.input.TestMRSequenceFileInputFilter org.apache.hadoop.mapreduce.lib.input.TestMRSequenceFileAsBinaryInputFormat org.apache.hadoop.mapreduce.TestValueIterReset org.apache.hadoop.mapreduce.lib.jobcontrol.TestMapReduceJobControl org.apache.hadoop.mapreduce.lib.output.TestMRMultipleOutputs org.apache.hadoop.mapreduce.v2.TestMROldApiJobs org.apache.hadoop.mapreduce.TestMapCollection org.apache.hadoop.mapreduce.lib.chain.TestChainErrors org.apache.hadoop.mapreduce.lib.map.TestMultithreadedMapper org.apache.hadoop.mapreduce.lib.chain.TestSingleElementChain org.apache.hadoop.mapreduce.v2.TestMRJobsWithHistoryService org.apache.hadoop.mapreduce.lib.partition.TestMRKeyFieldBasedComparator org.apache.hadoop.mapreduce.TestLocalRunner org.apache.hadoop.mapreduce.lib.input.TestNLineInputFormat org.apache.hadoop.mapreduce.lib.input.TestFileInputFormat org.apache.hadoop.mapreduce.lib.input.TestCombineFileInputFormat +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2679//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2679//console This message is automatically generated.
          Hide
          vinodkv Vinod Kumar Vavilapalli added a comment -

          Another dummy patch just to run MR tests without the actual fix to test-patch.

          Show
          vinodkv Vinod Kumar Vavilapalli added a comment - Another dummy patch just to run MR tests without the actual fix to test-patch.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12588736/HADOOP-9583-dummy-without-changes.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient:

          org.apache.hadoop.mapreduce.v2.TestMRJobsWithHistoryService

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2680//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2680//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12588736/HADOOP-9583-dummy-without-changes.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient: org.apache.hadoop.mapreduce.v2.TestMRJobsWithHistoryService +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2680//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2680//console This message is automatically generated.
          Hide
          kihwal Kihwal Lee added a comment -

          Submitting again to make sure it works after HADOOP-9186.

          Show
          kihwal Kihwal Lee added a comment - Submitting again to make sure it works after HADOOP-9186 .
          Hide
          hadoopqa Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12596958/HADOOP-9583.another_dummy.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in .

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2949//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2949//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12596958/HADOOP-9583.another_dummy.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in . +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2949//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2949//console This message is automatically generated.
          Hide
          kihwal Kihwal Lee added a comment -

          No test ran and the build failed but it's got +1 overall.

          Show
          kihwal Kihwal Lee added a comment - No test ran and the build failed but it's got +1 overall.
          Hide
          kihwal Kihwal Lee added a comment -

          Resubmitting Vinod's dummy patch to force tests to run.

          Show
          kihwal Kihwal Lee added a comment - Resubmitting Vinod's dummy patch to force tests to run.
          Hide
          hadoopqa Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12597088/HADOOP-9583-dummy.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 2 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2953//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2953//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12597088/HADOOP-9583-dummy.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 2 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2953//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2953//console This message is automatically generated.
          Hide
          kihwal Kihwal Lee added a comment -

          Ok, TestUberAM terminated and the build failed, but it still posted overall +1. It seems the patch no longer works after HADOOP-9186.

          HADOOP-9853 might fix this instead.

          Show
          kihwal Kihwal Lee added a comment - Ok, TestUberAM terminated and the build failed, but it still posted overall +1. It seems the patch no longer works after HADOOP-9186 . HADOOP-9853 might fix this instead.
          Hide
          kihwal Kihwal Lee added a comment -

          I misunderstood what HADOOP-9853 does. After experimenting with it, I realized it would be helpful if test-patch runs tests in multiple modules in a single build. If a patch touches two modules and there was a known test timeout in the first module, the build won't continue to the second module. The author may be misled to believe that the known failure is the only failure. With HADOOP-9853, surefire timeout cases can be dealt with, but 1) the script cannot rely on the exit code for failures and 2) any other types of test process failures are not covered (e.g. something causing System.exit()).

          Regardless of HADOOP-9853, it might be better to have the script also post something indicating that not all tests were run if something like this happens.

          Show
          kihwal Kihwal Lee added a comment - I misunderstood what HADOOP-9853 does. After experimenting with it, I realized it would be helpful if test-patch runs tests in multiple modules in a single build. If a patch touches two modules and there was a known test timeout in the first module, the build won't continue to the second module. The author may be misled to believe that the known failure is the only failure. With HADOOP-9853 , surefire timeout cases can be dealt with, but 1) the script cannot rely on the exit code for failures and 2) any other types of test process failures are not covered (e.g. something causing System.exit()). Regardless of HADOOP-9853 , it might be better to have the script also post something indicating that not all tests were run if something like this happens.
          Hide
          jlowe Jason Lowe added a comment -

          Ok, TestUberAM terminated and the build failed, but it still posted overall +1. It seems the patch no longer works after HADOOP-9186.

          I believe we're being bitten by HADOOP-8875, as test-patch currently doesn't have a way to test itself. So the output above is from the original test-patch before the change.

          I manually ran the updated test-patch, and it correctly identified the test timeouts and reported an overall -1 result.

          Show
          jlowe Jason Lowe added a comment - Ok, TestUberAM terminated and the build failed, but it still posted overall +1. It seems the patch no longer works after HADOOP-9186 . I believe we're being bitten by HADOOP-8875 , as test-patch currently doesn't have a way to test itself. So the output above is from the original test-patch before the change. I manually ran the updated test-patch, and it correctly identified the test timeouts and reported an overall -1 result.
          Hide
          jlowe Jason Lowe added a comment -

          With HADOOP-9853, surefire timeout cases can be dealt with, but 1) the script cannot rely on the exit code for failures and 2) any other types of test process failures are not covered (e.g. something causing System.exit()).

          The separate modules are run as separate Maven invocations, so we should be fine there. If one module build fails it should proceed to the next one. Also surefire runs all the tests in the module even if one or more times out or exits unexpectedly, so as long as we're not telling surefire to ignore those cases it should continue to return a non-zero exit code.

          Show
          jlowe Jason Lowe added a comment - With HADOOP-9853 , surefire timeout cases can be dealt with, but 1) the script cannot rely on the exit code for failures and 2) any other types of test process failures are not covered (e.g. something causing System.exit()). The separate modules are run as separate Maven invocations, so we should be fine there. If one module build fails it should proceed to the next one. Also surefire runs all the tests in the module even if one or more times out or exits unexpectedly, so as long as we're not telling surefire to ignore those cases it should continue to return a non-zero exit code.
          Hide
          kihwal Kihwal Lee added a comment -

          The separate modules are run as separate Maven invocations.

          Then it should be fine.
          +1 for the patch.

          Show
          kihwal Kihwal Lee added a comment - The separate modules are run as separate Maven invocations. Then it should be fine. +1 for the patch.
          Hide
          kihwal Kihwal Lee added a comment -

          Thanks for addressing this issue, Jason. I've committed this to trunk.

          Show
          kihwal Kihwal Lee added a comment - Thanks for addressing this issue, Jason. I've committed this to trunk.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-trunk-Commit #4246 (See https://builds.apache.org/job/Hadoop-trunk-Commit/4246/)
          HADOOP-9583. test-patch gives +1 despite build failure when running tests. Contributed by Jason Lowe. (kihwal: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1513200)

          • /hadoop/common/trunk/dev-support/test-patch.sh
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #4246 (See https://builds.apache.org/job/Hadoop-trunk-Commit/4246/ ) HADOOP-9583 . test-patch gives +1 despite build failure when running tests. Contributed by Jason Lowe. (kihwal: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1513200 ) /hadoop/common/trunk/dev-support/test-patch.sh /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Yarn-trunk #300 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/300/)
          HADOOP-9583. test-patch gives +1 despite build failure when running tests. Contributed by Jason Lowe. (kihwal: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1513200)

          • /hadoop/common/trunk/dev-support/test-patch.sh
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #300 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/300/ ) HADOOP-9583 . test-patch gives +1 despite build failure when running tests. Contributed by Jason Lowe. (kihwal: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1513200 ) /hadoop/common/trunk/dev-support/test-patch.sh /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Hdfs-trunk #1490 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1490/)
          HADOOP-9583. test-patch gives +1 despite build failure when running tests. Contributed by Jason Lowe. (kihwal: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1513200)

          • /hadoop/common/trunk/dev-support/test-patch.sh
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk #1490 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1490/ ) HADOOP-9583 . test-patch gives +1 despite build failure when running tests. Contributed by Jason Lowe. (kihwal: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1513200 ) /hadoop/common/trunk/dev-support/test-patch.sh /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #1517 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1517/)
          HADOOP-9583. test-patch gives +1 despite build failure when running tests. Contributed by Jason Lowe. (kihwal: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1513200)

          • /hadoop/common/trunk/dev-support/test-patch.sh
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #1517 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1517/ ) HADOOP-9583 . test-patch gives +1 despite build failure when running tests. Contributed by Jason Lowe. (kihwal: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1513200 ) /hadoop/common/trunk/dev-support/test-patch.sh /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt

            People

            • Assignee:
              jlowe Jason Lowe
              Reporter:
              jlowe Jason Lowe
            • Votes:
              0 Vote for this issue
              Watchers:
              12 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development