Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-9583

test-patch gives +1 despite build failure when running tests

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-alpha1
    • Fix Version/s: 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      I've seen a couple of checkins recently where tests have timed out resulting in a Maven build failure yet test-patch reports an overall +1 on the patch. This is encouraging commits of patches that subsequently break builds.

        Attachments

        1. HADOOP-9583.patch
          3 kB
          Jason Lowe
        2. HADOOP-9583-dummy.patch
          4 kB
          Vinod Kumar Vavilapalli
        3. HADOOP-9583-dummy-without-changes.patch
          0.8 kB
          Vinod Kumar Vavilapalli
        4. HADOOP-9583.another_dummy.patch
          3 kB
          Kihwal Lee
        5. HADOOP-9583-dummy.patch
          4 kB
          Kihwal Lee

          Issue Links

            Activity

              People

              • Assignee:
                jlowe Jason Lowe
                Reporter:
                jlowe Jason Lowe
              • Votes:
                0 Vote for this issue
                Watchers:
                11 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: