Hadoop Common
  1. Hadoop Common
  2. HADOOP-9581

hadoop --config non-existent directory should result in error

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.0, 0.23.7, 2.0.4-alpha
    • Fix Version/s: 2.1.0-beta, 0.23.9
    • Component/s: scripts
    • Labels:
      None

      Description

      Courtesy : CW Chung

      Providing a non-existent config directory should result in error.

      $ hadoop dfs -ls / : shows Hadoop DFS directory
      $ hadoop --config bad_config_dir dfs -ls : successful, showing Linux directory

      1. HADOOP-9581.txt
        0.6 kB
        Ashwin Shankar

        Activity

        Hide
        Ashwin Shankar added a comment -

        I've added code to validate if the argument to "--config" option is a directory.
        If not,I throw an error.

        Show
        Ashwin Shankar added a comment - I've added code to validate if the argument to "--config" option is a directory. If not,I throw an error.
        Hide
        Ashwin Shankar added a comment -

        I've added code to validate if the argument to "--config" option is a directory.
        If not,I throw an error.

        Show
        Ashwin Shankar added a comment - I've added code to validate if the argument to "--config" option is a directory. If not,I throw an error.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12584188/HADOOP-9581.txt
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2556//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2556//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12584188/HADOOP-9581.txt against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2556//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2556//console This message is automatically generated.
        Hide
        Ashwin Shankar added a comment -

        This fix was in shell scripts which don't have unit tests.
        I've manually verified it.

        Show
        Ashwin Shankar added a comment - This fix was in shell scripts which don't have unit tests. I've manually verified it.
        Hide
        Jason Lowe added a comment -

        +1, lgtm.

        Show
        Jason Lowe added a comment - +1, lgtm.
        Hide
        Jason Lowe added a comment -

        Thanks, Ashwin! I committed this to trunk, branch-2, branch-2.1-beta, and branch-0.23

        Show
        Jason Lowe added a comment - Thanks, Ashwin! I committed this to trunk, branch-2, branch-2.1-beta, and branch-0.23
        Hide
        Hudson added a comment -

        Integrated in Hadoop-trunk-Commit #3890 (See https://builds.apache.org/job/Hadoop-trunk-Commit/3890/)
        HADOOP-9581. hadoop --config non-existent directory should result in error. Contributed by Ashwin Shankar (Revision 1491548)

        Result = SUCCESS
        jlowe : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1491548
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/bin/hadoop-config.sh
        Show
        Hudson added a comment - Integrated in Hadoop-trunk-Commit #3890 (See https://builds.apache.org/job/Hadoop-trunk-Commit/3890/ ) HADOOP-9581 . hadoop --config non-existent directory should result in error. Contributed by Ashwin Shankar (Revision 1491548) Result = SUCCESS jlowe : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1491548 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/bin/hadoop-config.sh
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Yarn-trunk #237 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/237/)
        HADOOP-9581. hadoop --config non-existent directory should result in error. Contributed by Ashwin Shankar (Revision 1491548)

        Result = SUCCESS
        jlowe : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1491548
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/bin/hadoop-config.sh
        Show
        Hudson added a comment - Integrated in Hadoop-Yarn-trunk #237 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/237/ ) HADOOP-9581 . hadoop --config non-existent directory should result in error. Contributed by Ashwin Shankar (Revision 1491548) Result = SUCCESS jlowe : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1491548 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/bin/hadoop-config.sh
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #1454 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1454/)
        HADOOP-9581. hadoop --config non-existent directory should result in error. Contributed by Ashwin Shankar (Revision 1491548)

        Result = SUCCESS
        jlowe : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1491548
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/bin/hadoop-config.sh
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1454 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1454/ ) HADOOP-9581 . hadoop --config non-existent directory should result in error. Contributed by Ashwin Shankar (Revision 1491548) Result = SUCCESS jlowe : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1491548 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/bin/hadoop-config.sh

          People

          • Assignee:
            Ashwin Shankar
            Reporter:
            Ashwin Shankar
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development