[HADOOP-9559] When metrics system is restarted MBean names get incorrectly flagged as dupes

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.4.0, 3.0.0-alpha1
• Fix Version/s: 2.5.0
• Component/s: metrics
• Target Version/s: 2.5.0
• Hadoop Flags: Reviewed
• Assignee: Mike Liddell
• Reporter: Mostafa Elhemali
• Created: 10/May/13 18:10
• Updated: 12/May/16 18:22
• Resolved: 20/Jun/14 18:27

Description

In the Metrics2 system, every source gets registered as an MBean name, which gets put into a unique name pool in the singleton DefaultMetricsSystem object. The problem is that when the metrics system is shutdown (which unregisters the MBeans) this unique name pool is left as is, so if the metrics system is started again every attempt to register the same MBean names fails (exception is eaten and a warning is logged).
I think the fix here is to remove the name from the unique name pool if an MBean is unregistered, since it's OK at this point to add it again.

Issue Links

• is depended upon by: HADOOP-10728 Metrics system for Windows Azure Storage Filesystem