Details
-
Bug
-
Status: Resolved
-
Major
-
Resolution: Fixed
-
1-win, 3.0.0-alpha1
-
None
-
Reviewed
Description
Certain tests for platform-specific functionality are either executed only on Windows or bypass on Windows using checks like "if (Path.WINDOWS)" e.g. TestNativeIO.
Prefer using jUnit assumptions instead.
Attachments
Attachments
- HADOOP-9427.001.patch
- 59 kB
- Gergely Novák
- HADOOP-9427.002.patch
- 64 kB
- Gergely Novák
- HADOOP-9427.003.patch
- 64 kB
- Gergely Novák
- HADOOP-9427.004.patch
- 64 kB
- Gergely Novák
- HADOOP-9427.005.patch
- 67 kB
- Gergely Novák
- HADOOP-9427.006.patch
- 67 kB
- Gergely Novák
- HADOOP-9427.007.patch
- 67 kB
- Gergely Novák
Activity
Cool idea. Thanks, Steve. That saves us from writing assumeTrue(!Shell.WINDOWS) everywhere.
-1 overall |
Vote | Subsystem | Runtime | Comment |
---|---|---|---|
0 | reexec | 0m 22s | Docker mode activated. |
+1 | @author | 0m 0s | The patch does not contain any @author tags. |
+1 | test4tests | 0m 0s | The patch appears to include 35 new or modified test files. |
0 | mvndep | 0m 35s | Maven dependency ordering for branch |
+1 | mvninstall | 7m 0s | trunk passed |
+1 | compile | 7m 30s | trunk passed |
+1 | checkstyle | 1m 52s | trunk passed |
+1 | mvnsite | 4m 1s | trunk passed |
+1 | mvneclipse | 1m 7s | trunk passed |
+1 | findbugs | 6m 23s | trunk passed |
+1 | javadoc | 3m 29s | trunk passed |
0 | mvndep | 0m 14s | Maven dependency ordering for patch |
+1 | mvninstall | 3m 13s | the patch passed |
+1 | compile | 8m 37s | the patch passed |
+1 | javac | 8m 37s | the patch passed |
-1 | checkstyle | 1m 43s | root: The patch generated 37 new + 935 unchanged - 10 fixed = 972 total (was 945) |
+1 | mvnsite | 3m 47s | the patch passed |
+1 | mvneclipse | 1m 3s | the patch passed |
+1 | whitespace | 0m 0s | The patch has no whitespace issues. |
+1 | findbugs | 7m 1s | the patch passed |
+1 | javadoc | 3m 23s | the patch passed |
-1 | unit | 9m 19s | hadoop-common in the patch failed. |
-1 | unit | 69m 11s | hadoop-hdfs in the patch failed. |
+1 | unit | 2m 29s | hadoop-yarn-common in the patch passed. |
+1 | unit | 11m 45s | hadoop-yarn-server-nodemanager in the patch passed. |
+1 | unit | 1m 33s | hadoop-azure in the patch passed. |
+1 | asflicense | 0m 24s | The patch does not generate ASF License warnings. |
157m 37s |
Reason | Tests |
---|---|
Failed junit tests | hadoop.ha.TestZKFailoverController |
hadoop.net.TestDNS | |
hadoop.hdfs.server.datanode.TestDataNodeUUID | |
Timed out junit tests | org.apache.hadoop.hdfs.TestLeaseRecovery2 |
This message was automatically generated.
-1 overall |
Vote | Subsystem | Runtime | Comment |
---|---|---|---|
0 | reexec | 0m 16s | Docker mode activated. |
+1 | @author | 0m 0s | The patch does not contain any @author tags. |
+1 | test4tests | 0m 0s | The patch appears to include 35 new or modified test files. |
0 | mvndep | 0m 25s | Maven dependency ordering for branch |
+1 | mvninstall | 6m 10s | trunk passed |
+1 | compile | 6m 13s | trunk passed |
+1 | checkstyle | 1m 31s | trunk passed |
+1 | mvnsite | 8m 16s | trunk passed |
+1 | mvneclipse | 0m 45s | trunk passed |
0 | findbugs | 0m 0s | Skipped patched modules with no Java source: . |
+1 | findbugs | 5m 2s | trunk passed |
+1 | javadoc | 4m 48s | trunk passed |
0 | mvndep | 0m 11s | Maven dependency ordering for patch |
+1 | mvninstall | 8m 17s | the patch passed |
+1 | compile | 6m 11s | the patch passed |
+1 | javac | 6m 11s | the patch passed |
-1 | checkstyle | 1m 33s | root: The patch generated 3 new + 934 unchanged - 11 fixed = 937 total (was 945) |
+1 | mvnsite | 8m 10s | the patch passed |
+1 | mvneclipse | 0m 32s | the patch passed |
-1 | whitespace | 0m 0s | The patch has 147 line(s) that end in whitespace. Use git apply --whitespace=fix. |
-1 | whitespace | 0m 3s | The patch 1 line(s) with tabs. |
0 | findbugs | 0m 0s | Skipped patched modules with no Java source: . |
+1 | findbugs | 5m 39s | the patch passed |
+1 | javadoc | 4m 53s | the patch passed |
-1 | unit | 86m 44s | root in the patch failed. |
-1 | asflicense | 0m 22s | The patch generated 1 ASF License warnings. |
157m 19s |
Reason | Tests |
---|---|
Failed junit tests | hadoop.hdfs.TestFileCreationDelete |
hadoop.hdfs.server.namenode.TestEditLog | |
hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistReplicaRecovery |
This message was automatically generated.
-1 overall |
Vote | Subsystem | Runtime | Comment |
---|---|---|---|
0 | reexec | 0m 0s | Docker mode activated. |
-1 | docker | 12m 28s | Docker failed to build yetus/hadoop:2c91fd8. |
Subsystem | Report/Notes |
---|---|
JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12808616/HADOOP-9427.002.patch |
JIRA Issue | |
Console output | https://builds.apache.org/job/PreCommit-HADOOP-Build/9677/console |
Powered by | Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
-1 overall |
Vote | Subsystem | Runtime | Comment |
---|---|---|---|
0 | reexec | 0m 22s | Docker mode activated. |
+1 | @author | 0m 0s | The patch does not contain any @author tags. |
+1 | test4tests | 0m 0s | The patch appears to include 35 new or modified test files. |
0 | mvndep | 0m 11s | Maven dependency ordering for branch |
+1 | mvninstall | 6m 45s | trunk passed |
+1 | compile | 7m 6s | trunk passed |
+1 | checkstyle | 1m 36s | trunk passed |
+1 | mvnsite | 3m 10s | trunk passed |
+1 | mvneclipse | 1m 4s | trunk passed |
+1 | findbugs | 5m 26s | trunk passed |
+1 | javadoc | 2m 58s | trunk passed |
0 | mvndep | 0m 12s | Maven dependency ordering for patch |
+1 | mvninstall | 2m 43s | the patch passed |
+1 | compile | 6m 58s | the patch passed |
+1 | javac | 6m 58s | the patch passed |
+1 | checkstyle | 1m 31s | root: The patch generated 0 new + 934 unchanged - 11 fixed = 934 total (was 945) |
+1 | mvnsite | 3m 35s | the patch passed |
+1 | mvneclipse | 1m 8s | the patch passed |
-1 | whitespace | 0m 0s | The patch has 20 line(s) that end in whitespace. Use git apply --whitespace=fix. |
+1 | findbugs | 7m 27s | the patch passed |
+1 | javadoc | 3m 32s | the patch passed |
-1 | unit | 8m 46s | hadoop-common in the patch failed. |
-1 | unit | 62m 43s | hadoop-hdfs in the patch failed. |
+1 | unit | 2m 15s | hadoop-yarn-common in the patch passed. |
-1 | unit | 12m 10s | hadoop-yarn-server-nodemanager in the patch failed. |
+1 | unit | 1m 23s | hadoop-azure in the patch passed. |
+1 | asflicense | 0m 23s | The patch does not generate ASF License warnings. |
144m 54s |
Reason | Tests |
---|---|
Failed junit tests | hadoop.ha.TestZKFailoverController |
hadoop.hdfs.server.datanode.TestDataNodeLifeline | |
hadoop.yarn.server.nodemanager.containermanager.queuing.TestQueuingContainerManager |
Subsystem | Report/Notes |
---|---|
Docker | Image:yetus/hadoop:2c91fd8 |
JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12809405/HADOOP-9427.003.patch |
JIRA Issue | |
Optional Tests | asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle |
uname | Linux bb1df20e2278 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
Build tool | maven |
Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh |
git revision | trunk / 9581fb7 |
Default Java | 1.8.0_91 |
findbugs | v3.0.0 |
whitespace | https://builds.apache.org/job/PreCommit-HADOOP-Build/9719/artifact/patchprocess/whitespace-eol.txt |
unit | https://builds.apache.org/job/PreCommit-HADOOP-Build/9719/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt |
unit | https://builds.apache.org/job/PreCommit-HADOOP-Build/9719/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt |
unit | https://builds.apache.org/job/PreCommit-HADOOP-Build/9719/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt |
Test Results | https://builds.apache.org/job/PreCommit-HADOOP-Build/9719/testReport/ |
modules | C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-tools/hadoop-azure U: . |
Console output | https://builds.apache.org/job/PreCommit-HADOOP-Build/9719/console |
Powered by | Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
arpitagarwal can you take a look at my patch? Is this what you had in mind?
As for the Hadoop QA report: the failing unit tests are unrelated and I didn't touch the ./hadoop-build-tools/src/main/resources/META-INF/LICENSE.txt file (which has whitespace errors).
Mostly looks good to me. Would you remove isWindows from TestLocalDirAllocator.java?
-1 overall |
Vote | Subsystem | Runtime | Comment |
---|---|---|---|
0 | reexec | 0m 27s | Docker mode activated. |
+1 | @author | 0m 0s | The patch does not contain any @author tags. |
+1 | test4tests | 0m 0s | The patch appears to include 35 new or modified test files. |
0 | mvndep | 0m 11s | Maven dependency ordering for branch |
+1 | mvninstall | 6m 46s | trunk passed |
+1 | compile | 7m 1s | trunk passed |
+1 | checkstyle | 1m 31s | trunk passed |
+1 | mvnsite | 3m 12s | trunk passed |
+1 | mvneclipse | 1m 5s | trunk passed |
+1 | findbugs | 5m 24s | trunk passed |
+1 | javadoc | 3m 4s | trunk passed |
0 | mvndep | 0m 12s | Maven dependency ordering for patch |
+1 | mvninstall | 3m 0s | the patch passed |
+1 | compile | 10m 49s | the patch passed |
+1 | javac | 10m 49s | the patch passed |
+1 | checkstyle | 1m 43s | root: The patch generated 0 new + 932 unchanged - 13 fixed = 932 total (was 945) |
+1 | mvnsite | 5m 4s | the patch passed |
+1 | mvneclipse | 1m 31s | the patch passed |
-1 | whitespace | 0m 0s | The patch has 20 line(s) that end in whitespace. Use git apply --whitespace=fix. |
+1 | findbugs | 7m 21s | the patch passed |
+1 | javadoc | 2m 48s | the patch passed |
+1 | unit | 8m 26s | hadoop-common in the patch passed. |
-1 | unit | 67m 30s | hadoop-hdfs in the patch failed. |
+1 | unit | 2m 12s | hadoop-yarn-common in the patch passed. |
+1 | unit | 13m 8s | hadoop-yarn-server-nodemanager in the patch passed. |
+1 | unit | 1m 23s | hadoop-azure in the patch passed. |
+1 | asflicense | 0m 22s | The patch does not generate ASF License warnings. |
155m 32s |
Reason | Tests |
---|---|
Failed junit tests | hadoop.hdfs.server.namenode.TestEditLog |
hadoop.hdfs.server.namenode.TestNameNodeMetadataConsistency | |
hadoop.hdfs.server.blockmanagement.TestRBWBlockInvalidation | |
hadoop.hdfs.server.datanode.TestDataNodeUUID |
Subsystem | Report/Notes |
---|---|
Docker | Image:yetus/hadoop:2c91fd8 |
JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12809815/HADOOP-9427.004.patch |
JIRA Issue | |
Optional Tests | asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle |
uname | Linux cb8a10b06440 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
Build tool | maven |
Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh |
git revision | trunk / 28b66ae |
Default Java | 1.8.0_91 |
findbugs | v3.0.0 |
whitespace | https://builds.apache.org/job/PreCommit-HADOOP-Build/9759/artifact/patchprocess/whitespace-eol.txt |
unit | https://builds.apache.org/job/PreCommit-HADOOP-Build/9759/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt |
Test Results | https://builds.apache.org/job/PreCommit-HADOOP-Build/9759/testReport/ |
modules | C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-tools/hadoop-azure U: . |
Console output | https://builds.apache.org/job/PreCommit-HADOOP-Build/9759/console |
Powered by | Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
Thanks ajisakaa, updated patch #4 with the unused isWindows field removed.
Hi GergelyNovak, yes this is what I had in mind and what Steve helpfully suggested. Thanks for taking this up. Minor comments:
- assumeNotWindows is a better name than assumeUnix, since Linux and OS X are technically Unix-like.
- A couple of explanatory comments are lost by the patch. We should retain these comments. e.g. in TestFileUtil.java.
- if(Shell.WINDOWS) { - // windows Dir.setWritable(false) does not work for directories - return; - } + assumeUnix();
Also it looks like there is one more YARN test (TestYARNRunner#testAMStandardEnv) that needs a similar fix. We can fix it in a separate YARN jira.
-1 overall |
Vote | Subsystem | Runtime | Comment |
---|---|---|---|
0 | reexec | 0m 13s | Docker mode activated. |
+1 | @author | 0m 0s | The patch does not contain any @author tags. |
+1 | test4tests | 0m 0s | The patch appears to include 36 new or modified test files. |
0 | mvndep | 0m 11s | Maven dependency ordering for branch |
+1 | mvninstall | 5m 59s | trunk passed |
+1 | compile | 6m 9s | trunk passed |
+1 | checkstyle | 1m 31s | trunk passed |
+1 | mvnsite | 3m 19s | trunk passed |
+1 | mvneclipse | 1m 10s | trunk passed |
+1 | findbugs | 5m 12s | trunk passed |
+1 | javadoc | 2m 45s | trunk passed |
0 | mvndep | 0m 11s | Maven dependency ordering for patch |
+1 | mvninstall | 2m 41s | the patch passed |
+1 | compile | 6m 7s | the patch passed |
+1 | javac | 6m 7s | the patch passed |
-1 | checkstyle | 1m 33s | root: The patch generated 1 new + 1004 unchanged - 17 fixed = 1005 total (was 1021) |
+1 | mvnsite | 3m 17s | the patch passed |
+1 | mvneclipse | 1m 8s | the patch passed |
+1 | whitespace | 0m 0s | The patch has no whitespace issues. |
+1 | findbugs | 5m 58s | the patch passed |
+1 | javadoc | 2m 47s | the patch passed |
+1 | unit | 7m 27s | hadoop-common in the patch passed. |
-1 | unit | 55m 36s | hadoop-hdfs in the patch failed. |
+1 | unit | 2m 8s | hadoop-yarn-common in the patch passed. |
+1 | unit | 12m 58s | hadoop-yarn-server-nodemanager in the patch passed. |
-1 | unit | 106m 45s | hadoop-mapreduce-client-jobclient in the patch failed. |
+1 | unit | 1m 40s | hadoop-azure in the patch passed. |
+1 | asflicense | 0m 33s | The patch does not generate ASF License warnings. |
238m 40s |
Reason | Tests |
---|---|
Failed junit tests | hadoop.hdfs.server.namenode.TestDecommissioningStatus |
hadoop.hdfs.server.datanode.TestFsDatasetCache | |
hadoop.mapred.TestMRCJCFileOutputCommitter |
Subsystem | Report/Notes |
---|---|
Docker | Image:yetus/hadoop:2c91fd8 |
JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12810270/HADOOP-9427.005.patch |
JIRA Issue | |
Optional Tests | asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle |
uname | Linux c7adfe9be782 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
Build tool | maven |
Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh |
git revision | trunk / ee55b74 |
Default Java | 1.8.0_91 |
findbugs | v3.0.0 |
checkstyle | https://builds.apache.org/job/PreCommit-HADOOP-Build/9766/artifact/patchprocess/diff-checkstyle-root.txt |
unit | https://builds.apache.org/job/PreCommit-HADOOP-Build/9766/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt |
unit | https://builds.apache.org/job/PreCommit-HADOOP-Build/9766/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient.txt |
Test Results | https://builds.apache.org/job/PreCommit-HADOOP-Build/9766/testReport/ |
modules | C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient hadoop-tools/hadoop-azure U: . |
Console output | https://builds.apache.org/job/PreCommit-HADOOP-Build/9766/console |
Powered by | Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
Thanks arpitagarwal, uploaded patch #6 with your suggestions (assumeNotWindows, retained comments, TestYARNRunner#testAMStandardEnv) and some tiny refactor in PlatformAssumptions.
-1 overall |
Vote | Subsystem | Runtime | Comment |
---|---|---|---|
0 | reexec | 0m 11s | Docker mode activated. |
+1 | @author | 0m 0s | The patch does not contain any @author tags. |
+1 | test4tests | 0m 0s | The patch appears to include 36 new or modified test files. |
0 | mvndep | 0m 11s | Maven dependency ordering for branch |
+1 | mvninstall | 6m 10s | trunk passed |
+1 | compile | 6m 22s | trunk passed |
+1 | checkstyle | 1m 34s | trunk passed |
+1 | mvnsite | 3m 31s | trunk passed |
+1 | mvneclipse | 1m 8s | trunk passed |
+1 | findbugs | 5m 15s | trunk passed |
+1 | javadoc | 2m 56s | trunk passed |
0 | mvndep | 0m 11s | Maven dependency ordering for patch |
+1 | mvninstall | 2m 55s | the patch passed |
+1 | compile | 6m 59s | the patch passed |
+1 | javac | 6m 59s | the patch passed |
+1 | checkstyle | 1m 35s | root: The patch generated 0 new + 1004 unchanged - 17 fixed = 1004 total (was 1021) |
+1 | mvnsite | 3m 35s | the patch passed |
+1 | mvneclipse | 1m 9s | the patch passed |
+1 | whitespace | 0m 0s | The patch has no whitespace issues. |
+1 | findbugs | 6m 16s | the patch passed |
+1 | javadoc | 2m 53s | the patch passed |
+1 | unit | 7m 49s | hadoop-common in the patch passed. |
-1 | unit | 56m 57s | hadoop-hdfs in the patch failed. |
+1 | unit | 2m 13s | hadoop-yarn-common in the patch passed. |
+1 | unit | 13m 0s | hadoop-yarn-server-nodemanager in the patch passed. |
-1 | unit | 106m 24s | hadoop-mapreduce-client-jobclient in the patch failed. |
+1 | unit | 1m 37s | hadoop-azure in the patch passed. |
+1 | asflicense | 0m 32s | The patch does not generate ASF License warnings. |
242m 48s |
Reason | Tests |
---|---|
Failed junit tests | hadoop.hdfs.server.datanode.TestLargeBlockReport |
hadoop.mapred.TestMRCJCFileOutputCommitter |
Subsystem | Report/Notes |
---|---|
Docker | Image:yetus/hadoop:2c91fd8 |
JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12810388/HADOOP-9427.006.patch |
JIRA Issue | |
Optional Tests | asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle |
uname | Linux 1d3ead4fbf6d 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
Build tool | maven |
Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh |
git revision | trunk / 8e8cb4c |
Default Java | 1.8.0_91 |
findbugs | v3.0.0 |
unit | https://builds.apache.org/job/PreCommit-HADOOP-Build/9768/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt |
unit | https://builds.apache.org/job/PreCommit-HADOOP-Build/9768/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient.txt |
Test Results | https://builds.apache.org/job/PreCommit-HADOOP-Build/9768/testReport/ |
modules | C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient hadoop-tools/hadoop-azure U: . |
Console output | https://builds.apache.org/job/PreCommit-HADOOP-Build/9768/console |
Powered by | Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
Thank you for updating the patch GergelyNovak. +1 lgtm.
I will hold off committing for a couple of days in case ajisakaa or stevel@apache.org have further comments.
Updated new patch to apply to the current state of trunk. arpitagarwal could you have a look at it?
-1 overall |
Vote | Subsystem | Runtime | Comment |
---|---|---|---|
0 | reexec | 12m 18s | Docker mode activated. |
+1 | @author | 0m 1s | The patch does not contain any @author tags. |
+1 | test4tests | 0m 0s | The patch appears to include 36 new or modified test files. |
0 | mvndep | 1m 39s | Maven dependency ordering for branch |
+1 | mvninstall | 6m 59s | trunk passed |
+1 | compile | 6m 47s | trunk passed |
+1 | checkstyle | 1m 38s | trunk passed |
+1 | mvnsite | 3m 37s | trunk passed |
+1 | mvneclipse | 1m 29s | trunk passed |
+1 | findbugs | 5m 36s | trunk passed |
+1 | javadoc | 3m 4s | trunk passed |
0 | mvndep | 0m 16s | Maven dependency ordering for patch |
+1 | mvninstall | 3m 5s | the patch passed |
+1 | compile | 6m 45s | the patch passed |
+1 | javac | 6m 45s | the patch passed |
+1 | checkstyle | 1m 43s | root: The patch generated 0 new + 999 unchanged - 16 fixed = 999 total (was 1015) |
+1 | mvnsite | 3m 52s | the patch passed |
+1 | mvneclipse | 1m 44s | the patch passed |
+1 | whitespace | 0m 0s | The patch has no whitespace issues. |
+1 | findbugs | 6m 39s | the patch passed |
+1 | javadoc | 3m 24s | the patch passed |
-1 | unit | 7m 22s | hadoop-common in the patch failed. |
-1 | unit | 56m 28s | hadoop-hdfs in the patch failed. |
+1 | unit | 2m 29s | hadoop-yarn-common in the patch passed. |
-1 | unit | 13m 12s | hadoop-yarn-server-nodemanager in the patch failed. |
-1 | unit | 112m 18s | hadoop-mapreduce-client-jobclient in the patch failed. |
+1 | unit | 1m 35s | hadoop-azure in the patch passed. |
+1 | asflicense | 0m 38s | The patch does not generate ASF License warnings. |
289m 11s |
Reason | Tests |
---|---|
Failed junit tests | hadoop.net.TestDNS |
hadoop.cli.TestHDFSCLI | |
hadoop.yarn.server.nodemanager.TestDirectoryCollection | |
hadoop.mapred.TestMRCJCFileOutputCommitter |
Subsystem | Report/Notes |
---|---|
Docker | Image:yetus/hadoop:9560f25 |
JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12820181/HADOOP-9427.007.patch |
JIRA Issue | |
Optional Tests | asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle |
uname | Linux 9ca777b6bf4e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
Build tool | maven |
Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh |
git revision | trunk / 8e26145 |
Default Java | 1.8.0_101 |
findbugs | v3.0.0 |
unit | https://builds.apache.org/job/PreCommit-HADOOP-Build/10086/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt |
unit | https://builds.apache.org/job/PreCommit-HADOOP-Build/10086/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt |
unit | https://builds.apache.org/job/PreCommit-HADOOP-Build/10086/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt |
unit | https://builds.apache.org/job/PreCommit-HADOOP-Build/10086/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient.txt |
Test Results | https://builds.apache.org/job/PreCommit-HADOOP-Build/10086/testReport/ |
modules | C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient hadoop-tools/hadoop-azure U: . |
Console output | https://builds.apache.org/job/PreCommit-HADOOP-Build/10086/console |
Powered by | Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
+1, the test failures are not related to the patch. Checking this in.
Committed this to trunk. Thanks GergelyNovak for the contribution and thanks arpiagariu for the review!
SUCCESS: Integrated in Hadoop-trunk-Commit #10163 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10163/)
HADOOP-9427. Use JUnit assumptions to skip platform-specific tests. (aajisaka: rev 54fe17a607ecbf90145bfc5364b25f0a5aee98f4)
- hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeHotSwapVolumes.java
- hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestLocalFileSystemPermission.java
- hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/nativeio/TestNativeIO.java
- hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSUtil.java
- hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestSymlinkLocalFS.java
- hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/launcher/TestContainerLaunch.java
- hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestSymlinkLocalFSFileContext.java
- hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeVolumeFailureReporting.java
- hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestRBWBlockInvalidation.java
- hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeVolumeFailure.java
- hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestYARNRunner.java
- hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestFsDatasetCacheRevocation.java
- hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestLocalDirAllocator.java
- hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestScrLazyPersistFiles.java
- hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/test/PlatformAssumptions.java
- hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/sftp/TestSFTPFileSystem.java
- hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestPath.java
- hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tracing/TestTracingShortCircuitLocalRead.java
- hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeVolumeFailureToleration.java
- hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/shell/TestPathData.java
- hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFsShellCopy.java
- hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/TestShellDecryptionKeyProvider.java
- hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/TestGlobPaths.java
- hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/util/TestWindowsBasedProcessTree.java
- hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestShellBasedIdMapping.java
- hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestSymlinkLocalFSFileSystem.java
- hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestLocalFileSystem.java
- hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/util/TestAtomicFileOutputStream.java
- hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancer.java
- hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestWinUtils.java
- hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/FileContextPermissionBase.java
- hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestLinuxContainerExecutorWithMocks.java
- hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestContainerExecutor.java
- hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/TestNativeAzureFileSystemOperationsMocked.java
- hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/TestDNS.java
- hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFileUtil.java
+1 to this. Can you tease out platform assumption tests into their own methods, eg PlatformAssumptions.assumeUnix(), assumeWindows(). You don't need to use the @Assume tags to implement the logic, as you can just throw an AssumptionViolatedException in any method you feel like. That helps you test the assumption logic.