Hadoop Common
  1. Hadoop Common
  2. HADOOP-9406

hadoop-client leaks dependency on JDK tools jar

        Details

        • Type: Bug Bug
        • Status: Closed
        • Priority: Major Major
        • Resolution: Fixed
        • Affects Version/s: 2.0.3-alpha
        • Fix Version/s: 0.23.7, 2.0.4-alpha
        • Component/s: build
        • Labels:
          None
        • Hadoop Flags:
          Reviewed

          Description

          hadoop-client leaks out JDK tools jar as dependency.

          JDK tools jar is defined as a system dependency for hadoop-annotation/jdiff/javadocs purposes, if not done javadoc generation fails.

          The problem is that in the way it is defined now, this dependency ends up leaking to hadoop-client and downstream projects that depend on hadoop-client may end up including/bundling JDK tools JAR.

          1. Text File
            HADOOP-9406.patch
            2 kB
            Alejandro Abdelnur

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            Alejandro Abdelnur added a comment -

            verified tools dependency leak is gone from hadoop-client.

            created full binary, source builds and site documentation successfully.

            Show
            Alejandro Abdelnur added a comment - verified tools dependency leak is gone from hadoop-client. created full binary, source builds and site documentation successfully.
            Hide
            Permalink
            Hadoop QA added a comment -

            -1 overall. Here are the results of testing the latest attachment
            http://issues.apache.org/jira/secure/attachment/12573762/HADOOP-9406.patch
            against trunk revision .

            +1 @author. The patch does not contain any @author tags.

            -1 tests included. The patch doesn't appear to include any new or modified tests.
            Please justify why no new tests are needed for this patch.
            Also please list what manual steps were performed to verify this patch.

            +1 javac. The applied patch does not increase the total number of javac compiler warnings.

            +1 javadoc. The javadoc tool did not generate any warning messages.

            +1 eclipse:eclipse. The patch built with eclipse:eclipse.

            +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

            +1 release audit. The applied patch does not increase the total number of release audit warnings.

            +1 core tests. The patch passed unit tests in hadoop-client hadoop-common-project/hadoop-annotations.

            +1 contrib tests. The patch passed contrib unit tests.

            Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2328//testReport/
            Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2328//console

            This message is automatically generated.

            Show
            Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12573762/HADOOP-9406.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-client hadoop-common-project/hadoop-annotations. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2328//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2328//console This message is automatically generated.
            Hide
            Permalink
            Aaron T. Myers added a comment -

            I'm no Maven expert, but in the abstract this change makes sense to me.

            +1

            Show
            Aaron T. Myers added a comment - I'm no Maven expert, but in the abstract this change makes sense to me. +1
            Hide
            Permalink
            Hudson added a comment -

            Integrated in Hadoop-trunk-Commit #3476 (See https://builds.apache.org/job/Hadoop-trunk-Commit/3476/)
            HADOOP-9406. hadoop-client leaks dependency on JDK tools jar. (tucu) (Revision 1456729)

            Result = SUCCESS
            tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1456729
            Files :

            • /hadoop/common/trunk/hadoop-client/pom.xml
            • /hadoop/common/trunk/hadoop-common-project/hadoop-annotations/pom.xml
            • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
            • /hadoop/common/trunk/hadoop-project/pom.xml
            Show
            Hudson added a comment - Integrated in Hadoop-trunk-Commit #3476 (See https://builds.apache.org/job/Hadoop-trunk-Commit/3476/ ) HADOOP-9406 . hadoop-client leaks dependency on JDK tools jar. (tucu) (Revision 1456729) Result = SUCCESS tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1456729 Files : /hadoop/common/trunk/hadoop-client/pom.xml /hadoop/common/trunk/hadoop-common-project/hadoop-annotations/pom.xml /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-project/pom.xml
            Hide
            Permalink
            Hudson added a comment -

            Integrated in Hadoop-Yarn-trunk #156 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/156/)
            HADOOP-9406. hadoop-client leaks dependency on JDK tools jar. (tucu) (Revision 1456729)

            Result = SUCCESS
            tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1456729
            Files :

            • /hadoop/common/trunk/hadoop-client/pom.xml
            • /hadoop/common/trunk/hadoop-common-project/hadoop-annotations/pom.xml
            • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
            • /hadoop/common/trunk/hadoop-project/pom.xml
            Show
            Hudson added a comment - Integrated in Hadoop-Yarn-trunk #156 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/156/ ) HADOOP-9406 . hadoop-client leaks dependency on JDK tools jar. (tucu) (Revision 1456729) Result = SUCCESS tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1456729 Files : /hadoop/common/trunk/hadoop-client/pom.xml /hadoop/common/trunk/hadoop-common-project/hadoop-annotations/pom.xml /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-project/pom.xml
            Hide
            Permalink
            Hudson added a comment -

            Integrated in Hadoop-Hdfs-trunk #1345 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1345/)
            HADOOP-9406. hadoop-client leaks dependency on JDK tools jar. (tucu) (Revision 1456729)

            Result = FAILURE
            tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1456729
            Files :

            • /hadoop/common/trunk/hadoop-client/pom.xml
            • /hadoop/common/trunk/hadoop-common-project/hadoop-annotations/pom.xml
            • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
            • /hadoop/common/trunk/hadoop-project/pom.xml
            Show
            Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1345 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1345/ ) HADOOP-9406 . hadoop-client leaks dependency on JDK tools jar. (tucu) (Revision 1456729) Result = FAILURE tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1456729 Files : /hadoop/common/trunk/hadoop-client/pom.xml /hadoop/common/trunk/hadoop-common-project/hadoop-annotations/pom.xml /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-project/pom.xml
            Hide
            Permalink
            Hudson added a comment -

            Integrated in Hadoop-Mapreduce-trunk #1373 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1373/)
            HADOOP-9406. hadoop-client leaks dependency on JDK tools jar. (tucu) (Revision 1456729)

            Result = FAILURE
            tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1456729
            Files :

            • /hadoop/common/trunk/hadoop-client/pom.xml
            • /hadoop/common/trunk/hadoop-common-project/hadoop-annotations/pom.xml
            • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
            • /hadoop/common/trunk/hadoop-project/pom.xml
            Show
            Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1373 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1373/ ) HADOOP-9406 . hadoop-client leaks dependency on JDK tools jar. (tucu) (Revision 1456729) Result = FAILURE tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1456729 Files : /hadoop/common/trunk/hadoop-client/pom.xml /hadoop/common/trunk/hadoop-common-project/hadoop-annotations/pom.xml /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-project/pom.xml
            Hide
            Permalink
            Hudson added a comment -

            Integrated in Hadoop-Hdfs-0.23-Build #555 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/555/)
            HADOOP-9406. hadoop-client leaks dependency on JDK tools jar. (tucu) (Revision 1456976)

            Result = SUCCESS
            tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1456976
            Files :

            • /hadoop/common/branches/branch-0.23/hadoop-client/pom.xml
            • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-annotations/pom.xml
            • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
            • /hadoop/common/branches/branch-0.23/hadoop-project/pom.xml
            Show
            Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #555 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/555/ ) HADOOP-9406 . hadoop-client leaks dependency on JDK tools jar. (tucu) (Revision 1456976) Result = SUCCESS tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1456976 Files : /hadoop/common/branches/branch-0.23/hadoop-client/pom.xml /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-annotations/pom.xml /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-project/pom.xml

              People

              • Assignee:
                Alejandro Abdelnur
                Reporter:
                Alejandro Abdelnur
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Development