Hadoop Common
  1. Hadoop Common
  2. HADOOP-9405

TestGridmixSummary#testExecutionSummarizer is broken

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.4-alpha, 3.0.0
    • Fix Version/s: 2.0.4-alpha
    • Component/s: test, tools
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      HADOOP-9252 changed how human readable numbers are printed, and required updating a number of test cases. This one was missed because the Jenkins precommit job apparently isn't running the tests in hadoop-tools.

        Issue Links

          Activity

          Andrew Wang created issue -
          Hide
          Andrew Wang added a comment -

          Trivial patch attached. There are more broken tests in hadoop-tools too.

          Show
          Andrew Wang added a comment - Trivial patch attached. There are more broken tests in hadoop-tools too.
          Andrew Wang made changes -
          Field Original Value New Value
          Attachment hdfs-4599-1.patch [ 12573562 ]
          Andrew Wang made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12573562/hdfs-4599-1.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 tests included appear to have a timeout.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          -1 findbugs. The patch appears to introduce 11 new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-tools/hadoop-gridmix.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/4097//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/4097//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-gridmix.html
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/4097//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12573562/hdfs-4599-1.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 tests included appear to have a timeout. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. -1 findbugs . The patch appears to introduce 11 new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-tools/hadoop-gridmix. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/4097//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/4097//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-gridmix.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/4097//console This message is automatically generated.
          Hide
          Andrew Wang added a comment -

          Pretty sure this patch is not the cause of the additional Findbugs warnings.

          Show
          Andrew Wang added a comment - Pretty sure this patch is not the cause of the additional Findbugs warnings.
          Hide
          Chris Nauroth added a comment -

          +1 for the patch. I verified that it fixes the test. I agree that the Findbugs warnings are unrelated.

          Show
          Chris Nauroth added a comment - +1 for the patch. I verified that it fixes the test. I agree that the Findbugs warnings are unrelated.
          Chris Nauroth made changes -
          Link This issue is broken by HADOOP-9252 [ HADOOP-9252 ]
          Hide
          Aaron T. Myers added a comment -

          Agreed - findbugs warning is unrelated.

          +1, the patch looks good to me. I'm going to commit this momentarily.

          Show
          Aaron T. Myers added a comment - Agreed - findbugs warning is unrelated. +1, the patch looks good to me. I'm going to commit this momentarily.
          Aaron T. Myers made changes -
          Project Hadoop HDFS [ 12310942 ] Hadoop Common [ 12310240 ]
          Key HDFS-4599 HADOOP-9405
          Affects Version/s 3.0.0 [ 12320357 ]
          Affects Version/s 3.0.0 [ 12320356 ]
          Component/s test [ 12311440 ]
          Component/s tools [ 12319643 ]
          Component/s tools [ 12312944 ]
          Hide
          Aaron T. Myers added a comment -

          I've just committed this to trunk.

          Thanks a lot for the contribution, Andrew.

          Show
          Aaron T. Myers added a comment - I've just committed this to trunk. Thanks a lot for the contribution, Andrew.
          Aaron T. Myers made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Hadoop Flags Reviewed [ 10343 ]
          Fix Version/s 3.0.0 [ 12320357 ]
          Resolution Fixed [ 1 ]
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12573562/hdfs-4599-1.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 tests included appear to have a timeout.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          -1 findbugs. The patch appears to introduce 11 new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-tools/hadoop-gridmix.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2327//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/2327//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-gridmix.html
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2327//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12573562/hdfs-4599-1.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 tests included appear to have a timeout. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. -1 findbugs . The patch appears to introduce 11 new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-tools/hadoop-gridmix. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2327//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/2327//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-gridmix.html Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2327//console This message is automatically generated.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-trunk-Commit #3474 (See https://builds.apache.org/job/Hadoop-trunk-Commit/3474/)
          HADOOP-9405. TestGridmixSummary#testExecutionSummarizer is broken. Contributed by Andrew Wang. (Revision 1456639)

          Result = SUCCESS
          atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1456639
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/src/test/java/org/apache/hadoop/mapred/gridmix/TestGridmixSummary.java
          Show
          Hudson added a comment - Integrated in Hadoop-trunk-Commit #3474 (See https://builds.apache.org/job/Hadoop-trunk-Commit/3474/ ) HADOOP-9405 . TestGridmixSummary#testExecutionSummarizer is broken. Contributed by Andrew Wang. (Revision 1456639) Result = SUCCESS atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1456639 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/src/test/java/org/apache/hadoop/mapred/gridmix/TestGridmixSummary.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Yarn-trunk #156 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/156/)
          HADOOP-9405. TestGridmixSummary#testExecutionSummarizer is broken. Contributed by Andrew Wang. (Revision 1456639)

          Result = SUCCESS
          atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1456639
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/src/test/java/org/apache/hadoop/mapred/gridmix/TestGridmixSummary.java
          Show
          Hudson added a comment - Integrated in Hadoop-Yarn-trunk #156 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/156/ ) HADOOP-9405 . TestGridmixSummary#testExecutionSummarizer is broken. Contributed by Andrew Wang. (Revision 1456639) Result = SUCCESS atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1456639 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/src/test/java/org/apache/hadoop/mapred/gridmix/TestGridmixSummary.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #1345 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1345/)
          HADOOP-9405. TestGridmixSummary#testExecutionSummarizer is broken. Contributed by Andrew Wang. (Revision 1456639)

          Result = FAILURE
          atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1456639
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/src/test/java/org/apache/hadoop/mapred/gridmix/TestGridmixSummary.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1345 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1345/ ) HADOOP-9405 . TestGridmixSummary#testExecutionSummarizer is broken. Contributed by Andrew Wang. (Revision 1456639) Result = FAILURE atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1456639 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/src/test/java/org/apache/hadoop/mapred/gridmix/TestGridmixSummary.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #1373 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1373/)
          HADOOP-9405. TestGridmixSummary#testExecutionSummarizer is broken. Contributed by Andrew Wang. (Revision 1456639)

          Result = FAILURE
          atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1456639
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/src/test/java/org/apache/hadoop/mapred/gridmix/TestGridmixSummary.java
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1373 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1373/ ) HADOOP-9405 . TestGridmixSummary#testExecutionSummarizer is broken. Contributed by Andrew Wang. (Revision 1456639) Result = FAILURE atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1456639 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/src/test/java/org/apache/hadoop/mapred/gridmix/TestGridmixSummary.java
          Hide
          Thomas Graves added a comment -

          this was broken in branch-2 also so I merged this back.

          Show
          Thomas Graves added a comment - this was broken in branch-2 also so I merged this back.
          Thomas Graves made changes -
          Fix Version/s 2.0.5-beta [ 12324030 ]
          Hide
          Konstantin Boudnik added a comment -

          Need to backport to branch-2.0.4

          Show
          Konstantin Boudnik added a comment - Need to backport to branch-2.0.4
          Konstantin Boudnik made changes -
          Resolution Fixed [ 1 ]
          Status Resolved [ 5 ] Reopened [ 4 ]
          Konstantin Boudnik made changes -
          Fix Version/s 2.0.4-alpha [ 12324135 ]
          Konstantin Boudnik made changes -
          Affects Version/s 2.0.4-alpha [ 12324135 ]
          Hide
          Konstantin Boudnik added a comment -

          I have committed the patch to 2.0.4-alpha branch

          Show
          Konstantin Boudnik added a comment - I have committed the patch to 2.0.4-alpha branch
          Konstantin Boudnik made changes -
          Status Reopened [ 4 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Arun C Murthy made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Allen Wittenauer made changes -
          Fix Version/s 3.0.0 [ 12320357 ]
          Fix Version/s 2.1.0-beta [ 12324030 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Patch Available Patch Available
          5h 55m 1 Andrew Wang 14/Mar/13 00:31
          Patch Available Patch Available Resolved Resolved
          19h 42m 1 Aaron T. Myers 14/Mar/13 20:13
          Resolved Resolved Reopened Reopened
          18d 16m 1 Konstantin Boudnik 01/Apr/13 21:30
          Reopened Reopened Resolved Resolved
          43s 1 Konstantin Boudnik 01/Apr/13 21:31
          Resolved Resolved Closed Closed
          24d 5h 43m 1 Arun C Murthy 26/Apr/13 03:14

            People

            • Assignee:
              Andrew Wang
              Reporter:
              Andrew Wang
            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development