Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-alpha1
    • Fix Version/s: 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Since the test order is different with JDK7, we hit an error in TestRPC#testStopsAllThreads on the initial assertEquals. This is because testRPCInterruptedSimple and testRPCInterrupted don't stop the server after they finish, leaving some threads around.

      1. hadoop-9393-1.patch
        5 kB
        Andrew Wang
      2. hadoop-9393-1-whitespace.patch
        2 kB
        Andrew Wang

        Activity

        Hide
        andrew.wang Andrew Wang added a comment -

        Patch attached. It's simply wrapping these tests in a try/finally with #server.stop(). The whitespace changes make this look huge, but I attached a git diff -w version of the patch for easy review.

        Tested by running TestRPC 10 times with JDK7, all passed.

        Show
        andrew.wang Andrew Wang added a comment - Patch attached. It's simply wrapping these tests in a try/finally with #server.stop(). The whitespace changes make this look huge, but I attached a git diff -w version of the patch for easy review. Tested by running TestRPC 10 times with JDK7, all passed.
        Hide
        hadoopqa Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12573178/hadoop-9393-1.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 tests included appear to have a timeout.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2313//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2313//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12573178/hadoop-9393-1.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 tests included appear to have a timeout. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2313//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2313//console This message is automatically generated.
        Hide
        atm Aaron T. Myers added a comment -

        +1, the patch looks good to me. I'm going to commit this momentarily.

        Show
        atm Aaron T. Myers added a comment - +1, the patch looks good to me. I'm going to commit this momentarily.
        Hide
        atm Aaron T. Myers added a comment -

        I've just committed this to trunk.

        Thanks a lot for the contribution, Andrew.

        Show
        atm Aaron T. Myers added a comment - I've just committed this to trunk. Thanks a lot for the contribution, Andrew.
        Hide
        hudson Hudson added a comment -

        Integrated in Hadoop-trunk-Commit #3450 (See https://builds.apache.org/job/Hadoop-trunk-Commit/3450/)
        HADOOP-9393. TestRPC fails with JDK7. Contributed by Andrew Wang. (Revision 1455418)

        Result = SUCCESS
        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1455418
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPC.java
        Show
        hudson Hudson added a comment - Integrated in Hadoop-trunk-Commit #3450 (See https://builds.apache.org/job/Hadoop-trunk-Commit/3450/ ) HADOOP-9393 . TestRPC fails with JDK7. Contributed by Andrew Wang. (Revision 1455418) Result = SUCCESS atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1455418 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPC.java
        Hide
        hudson Hudson added a comment -

        Integrated in Hadoop-Yarn-trunk #153 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/153/)
        HADOOP-9393. TestRPC fails with JDK7. Contributed by Andrew Wang. (Revision 1455418)

        Result = SUCCESS
        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1455418
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPC.java
        Show
        hudson Hudson added a comment - Integrated in Hadoop-Yarn-trunk #153 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/153/ ) HADOOP-9393 . TestRPC fails with JDK7. Contributed by Andrew Wang. (Revision 1455418) Result = SUCCESS atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1455418 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPC.java
        Hide
        hudson Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #1342 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1342/)
        HADOOP-9393. TestRPC fails with JDK7. Contributed by Andrew Wang. (Revision 1455418)

        Result = FAILURE
        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1455418
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPC.java
        Show
        hudson Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1342 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1342/ ) HADOOP-9393 . TestRPC fails with JDK7. Contributed by Andrew Wang. (Revision 1455418) Result = FAILURE atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1455418 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPC.java
        Hide
        hudson Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #1370 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1370/)
        HADOOP-9393. TestRPC fails with JDK7. Contributed by Andrew Wang. (Revision 1455418)

        Result = SUCCESS
        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1455418
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPC.java
        Show
        hudson Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1370 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1370/ ) HADOOP-9393 . TestRPC fails with JDK7. Contributed by Andrew Wang. (Revision 1455418) Result = SUCCESS atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1455418 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPC.java

          People

          • Assignee:
            andrew.wang Andrew Wang
            Reporter:
            andrew.wang Andrew Wang
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development