Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: trunk-win, 3.0.0-alpha1
    • Fix Version/s: 2.1.0-beta
    • Component/s: None
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      TestHAZKUtil#testConfIndirectionfails on the following validation:

      assertTrue(fnfe.getMessage().startsWith(BOGUS_FILE));

      because the path separators do not match:

      Expected: /xxxx-this-does-not-exist
      Actual: \xxxx-this-does-not-exist

        Issue Links

          Activity

          Hide
          ivanmi Ivan Mitic added a comment -

          Attaching the test fix. The issue is that the test assumes unix path separator for a local path.

          Show
          ivanmi Ivan Mitic added a comment - Attaching the test fix. The issue is that the test assumes unix path separator for a local path.
          Hide
          cnauroth Chris Nauroth added a comment -

          +1 for the patch.

          Thanks, Ivan! I tested the patch on Mac and Windows. This can commit to trunk and then merge to branch-trunk-win.

          Show
          cnauroth Chris Nauroth added a comment - +1 for the patch. Thanks, Ivan! I tested the patch on Mac and Windows. This can commit to trunk and then merge to branch-trunk-win.
          Hide
          hadoopqa Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12572149/HADOOP-9365.branch-trunk-win.hazkutil.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 tests included appear to have a timeout.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2275//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2275//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12572149/HADOOP-9365.branch-trunk-win.hazkutil.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 tests included appear to have a timeout. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2275//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2275//console This message is automatically generated.
          Hide
          arpitagarwal Arpit Agarwal added a comment -

          +1

          Show
          arpitagarwal Arpit Agarwal added a comment - +1
          Hide
          sureshms Suresh Srinivas added a comment -

          +1 for the patch. I will commit it shortly.

          Show
          sureshms Suresh Srinivas added a comment - +1 for the patch. I will commit it shortly.
          Hide
          sureshms Suresh Srinivas added a comment -

          Committed the patch to trunk. Thank you Ivan.

          Show
          sureshms Suresh Srinivas added a comment - Committed the patch to trunk. Thank you Ivan.
          Hide
          hudson Hudson added a comment -

          Integrated in Hadoop-trunk-Commit #3431 (See https://builds.apache.org/job/Hadoop-trunk-Commit/3431/)
          HADOOP-9365. TestHAZKUtil fails on Windows. Contributed by Ivan Mitic. (Revision 1453676)

          Result = SUCCESS
          suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1453676
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ha/TestHAZKUtil.java
          Show
          hudson Hudson added a comment - Integrated in Hadoop-trunk-Commit #3431 (See https://builds.apache.org/job/Hadoop-trunk-Commit/3431/ ) HADOOP-9365 . TestHAZKUtil fails on Windows. Contributed by Ivan Mitic. (Revision 1453676) Result = SUCCESS suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1453676 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ha/TestHAZKUtil.java
          Hide
          hudson Hudson added a comment -

          Integrated in Hadoop-Yarn-trunk #148 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/148/)
          HADOOP-9365. TestHAZKUtil fails on Windows. Contributed by Ivan Mitic. (Revision 1453676)

          Result = SUCCESS
          suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1453676
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ha/TestHAZKUtil.java
          Show
          hudson Hudson added a comment - Integrated in Hadoop-Yarn-trunk #148 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/148/ ) HADOOP-9365 . TestHAZKUtil fails on Windows. Contributed by Ivan Mitic. (Revision 1453676) Result = SUCCESS suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1453676 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ha/TestHAZKUtil.java
          Hide
          hudson Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #1337 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1337/)
          HADOOP-9365. TestHAZKUtil fails on Windows. Contributed by Ivan Mitic. (Revision 1453676)

          Result = SUCCESS
          suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1453676
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ha/TestHAZKUtil.java
          Show
          hudson Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1337 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1337/ ) HADOOP-9365 . TestHAZKUtil fails on Windows. Contributed by Ivan Mitic. (Revision 1453676) Result = SUCCESS suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1453676 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ha/TestHAZKUtil.java
          Hide
          hudson Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #1365 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1365/)
          HADOOP-9365. TestHAZKUtil fails on Windows. Contributed by Ivan Mitic. (Revision 1453676)

          Result = SUCCESS
          suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1453676
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ha/TestHAZKUtil.java
          Show
          hudson Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1365 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1365/ ) HADOOP-9365 . TestHAZKUtil fails on Windows. Contributed by Ivan Mitic. (Revision 1453676) Result = SUCCESS suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1453676 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ha/TestHAZKUtil.java
          Hide
          sureshms Suresh Srinivas added a comment -

          Merged the change to branch-2

          Show
          sureshms Suresh Srinivas added a comment - Merged the change to branch-2

            People

            • Assignee:
              ivanmi Ivan Mitic
              Reporter:
              ivanmi Ivan Mitic
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development