Details

    • Type: Sub-task Sub-task
    • Status: In Progress
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: native
    • Labels:
      None

      Description

      The "test-patch" utility is triggered by "Patch Available" state in Jira, and runs nine different sets of builds, tests, and static analysis tools. Currently only the Linux environment is tested. Need to add tests for Java build under Windows, and unit test execution under Windows.

      At this time, the community has decided that "-1" on these new additional tests shall not block commits to the code base. However, contributors and code reviewers are encouraged to utilize the information provided by these tests to help keep Hadoop cross-platform compatible. Modify http://wiki.apache.org/hadoop/HowToContribute to document this.

        Activity

        Show
        Suresh Srinivas added a comment - Please see https://issues.apache.org/jira/browse/HDFS-4615?focusedCommentId=13612650&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13612650 for details on build error.
        Hide
        Konstantin Boudnik added a comment -

        The branch-2 build seems to be broken now because of

        hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSShell.java:[895,15] WINDOWS is not public in org.apache.hadoop.fs.Path; cannot be accessed from outside package

        Show
        Konstantin Boudnik added a comment - The branch-2 build seems to be broken now because of hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSShell.java: [895,15] WINDOWS is not public in org.apache.hadoop.fs.Path; cannot be accessed from outside package
        Hide
        Nigel Daley added a comment -

        +1

        Show
        Nigel Daley added a comment - +1
        Hide
        Matt Foley added a comment -

        In order to keep execution time down and isolate the new functionality, Giri and I intend the following design:
        A separate powershell script, modeled on the existing test-patch.sh, but invoking only java build and unit tests, shall be added. The new file will be called test-patch-win.ps1. Existing functionality of test-patch.sh will be unchanged.

        The Jenkins job that invokes test-patch.sh will be modified to also invoke test-patch-win.ps1 in parallel, utilizing a Windows Jenkins slave. This avoids slowing down the user-visible speed of the pre-commit test response. The current linux results will be reported in a comment as usual. The new windows results will be reported in a separate comment.

        Show
        Matt Foley added a comment - In order to keep execution time down and isolate the new functionality, Giri and I intend the following design: A separate powershell script, modeled on the existing test-patch.sh, but invoking only java build and unit tests, shall be added. The new file will be called test-patch-win.ps1. Existing functionality of test-patch.sh will be unchanged. The Jenkins job that invokes test-patch.sh will be modified to also invoke test-patch-win.ps1 in parallel, utilizing a Windows Jenkins slave. This avoids slowing down the user-visible speed of the pre-commit test response. The current linux results will be reported in a comment as usual. The new windows results will be reported in a separate comment.

          People

          • Assignee:
            Matt Foley
            Reporter:
            Matt Foley
          • Votes:
            0 Vote for this issue
            Watchers:
            8 Start watching this issue

            Dates

            • Created:
              Updated:

              Development