Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-9348

address TODO in winutils to add more command line usage and examples

Details

    • Improvement
    • Status: Resolved
    • Trivial
    • Resolution: Fixed
    • trunk-win
    • trunk-win
    • native
    • None
    • Reviewed

    Description

      A TODO was marked in hadoop-common-project/hadoop-common/src/main/winutils/main.c to add more command line usage and examples. This issue tracks resolution of this TODO.

      Attachments

        Issue Links

          Activity

            cnauroth Chris Nauroth created issue -
            cnauroth Chris Nauroth added a comment -
            static void Usage(LPCWSTR program)
            {
              //
              // TODO: add more command line usages and examples for each command.
              //
            

            At this point, the output from winutils with no arguments is quite thorough, so perhaps we can just drop the TODO without making any changes. I've added a few people as watchers who might have opinions on this.

            cnauroth Chris Nauroth added a comment - static void Usage(LPCWSTR program) { // // TODO: add more command line usages and examples for each command. // At this point, the output from winutils with no arguments is quite thorough, so perhaps we can just drop the TODO without making any changes. I've added a few people as watchers who might have opinions on this.
            cnauroth Chris Nauroth made changes -
            Field Original Value New Value
            Link This issue is part of HADOOP-8562 [ HADOOP-8562 ]
            arp Arpit Agarwal added a comment -

            +1

            arp Arpit Agarwal added a comment - +1
            cnauroth Chris Nauroth added a comment -

            Tentatively attaching a patch that just drops the TODO.

            ivanmi and chuanliu, do you have any other thoughts on this, or are you OK with dropping the TODO?

            cnauroth Chris Nauroth added a comment - Tentatively attaching a patch that just drops the TODO. ivanmi and chuanliu , do you have any other thoughts on this, or are you OK with dropping the TODO?
            cnauroth Chris Nauroth made changes -
            Attachment HADOOP-9348-branch-trunk-win.1.patch [ 12571460 ]
            arp Arpit Agarwal added a comment -

            +1 from me.

            arp Arpit Agarwal added a comment - +1 from me.
            ivanmi Ivan Mitic added a comment -

            This is fine, thanks Chris, every command also displays additional usage info, +1

            ivanmi Ivan Mitic added a comment - This is fine, thanks Chris, every command also displays additional usage info, +1
            cnauroth Chris Nauroth made changes -
            Assignee Chris Nauroth [ cnauroth ]
            cnauroth Chris Nauroth made changes -
            Priority Major [ 3 ] Trivial [ 5 ]

            +1. Committed the patch to branch-trunk-win.

            sureshms Suresh Srinivas added a comment - +1. Committed the patch to branch-trunk-win.
            sureshms Suresh Srinivas made changes -
            Fix Version/s trunk-win [ 12323306 ]
            Hadoop Flags Reviewed [ 10343 ]
            Resolution Fixed [ 1 ]
            Status Open [ 1 ] Resolved [ 5 ]

            People

              cnauroth Chris Nauroth
              cnauroth Chris Nauroth
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: