Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-9320

Hadoop native build failure on ARM hard-float

    Details

    • Type: Bug
    • Status: Patch Available
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: 2.0.3-alpha
    • Fix Version/s: None
    • Component/s: native
    • Environment:

      Description

      ARM JVM float ABI detection is failing in JNIFlags.cmake because JAVA_JVM_LIBRARY is not set at that point. The failure currently causes CMake to assume a soft-float JVM. This causes the build to fail with hard-float OpenJDK (but don't use that) and Oracle Java 8 Preview for ARM. Hopefully the April update of Oracle Java 7 will support hard-float as well.

      1. HADOOP-9320.patch
        4 kB
        Trevor Robinson

        Issue Links

          Activity

          Hide
          scurrilous Trevor Robinson added a comment -

          Attached a patch that moves the ARM JVM float ABI detection down below the search for JAVA_JVM_LIBRARY. It also improves the diagnostics a bit by reporting which library it's examining and positively confirms if it finds a hard-float JVM.

          Show
          scurrilous Trevor Robinson added a comment - Attached a patch that moves the ARM JVM float ABI detection down below the search for JAVA_JVM_LIBRARY. It also improves the diagnostics a bit by reporting which library it's examining and positively confirms if it finds a hard-float JVM.
          Hide
          scurrilous Trevor Robinson added a comment -

          Note that I tested the attached patch with both JDK7 soft-float and JDK8 (preview) hard-float on ARM and with JDK7 on x86-64.

          Show
          scurrilous Trevor Robinson added a comment - Note that I tested the attached patch with both JDK7 soft-float and JDK8 (preview) hard-float on ARM and with JDK7 on x86-64.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12570212/HADOOP-9320.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2216//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2216//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12570212/HADOOP-9320.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2216//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2216//console This message is automatically generated.
          Hide
          scurrilous Trevor Robinson added a comment -

          Could someone please commit this patch? The build is broken for ARM hard-float systems, which are now the default. (Oracle 7u40 supports armhf.) This fix trivially reorders two chunks of JNIFlags.cmake so that JAVA_JVM_LIBRARY is defined before it is used, and it has no effect on other platforms. Thanks.

          Show
          scurrilous Trevor Robinson added a comment - Could someone please commit this patch? The build is broken for ARM hard-float systems, which are now the default. (Oracle 7u40 supports armhf.) This fix trivially reorders two chunks of JNIFlags.cmake so that JAVA_JVM_LIBRARY is defined before it is used, and it has no effect on other platforms. Thanks.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12570212/HADOOP-9320.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/3349//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3349//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12570212/HADOOP-9320.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/3349//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3349//console This message is automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 5m 11s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 javac 7m 28s There were no new javac warning messages.
          +1 release audit 0m 19s The applied patch does not increase the total number of release audit warnings.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 30s mvn install still works.
          +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
          +1 common tests 22m 34s Tests passed in hadoop-common.
              37m 39s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12570212/HADOOP-9320.patch
          Optional Tests javac unit
          git revision trunk / 6ae2a0d
          hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6409/artifact/patchprocess/testrun_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6409/testReport/
          Java 1.7.0_55
          uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6409/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 5m 11s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 28s There were no new javac warning messages. +1 release audit 0m 19s The applied patch does not increase the total number of release audit warnings. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 30s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 common tests 22m 34s Tests passed in hadoop-common.     37m 39s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12570212/HADOOP-9320.patch Optional Tests javac unit git revision trunk / 6ae2a0d hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6409/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6409/testReport/ Java 1.7.0_55 uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6409/console This message was automatically generated.
          Hide
          wheat9 Haohui Mai added a comment -

          Hi Trevor Robinson, can you please rebase the patch? Thanks.

          Show
          wheat9 Haohui Mai added a comment - Hi Trevor Robinson , can you please rebase the patch? Thanks.
          Hide
          scurrilous Trevor Robinson added a comment -

          I no longer have the ability to test this patch, as I have no access to an ARM Linux environment. I don't really work on Hadoop anymore either, for that matter, so I'm not sure of the status of this issue.

          Show
          scurrilous Trevor Robinson added a comment - I no longer have the ability to test this patch, as I have no access to an ARM Linux environment. I don't really work on Hadoop anymore either, for that matter, so I'm not sure of the status of this issue.
          Hide
          amuttsch Andreas Muttscheller added a comment - - edited

          This problem still exist with Hadoop 2.8. Unfortunatelly, the patch doesn't work for this version. I updated the patch to work with Hadoop 2.8:

          HADOOP-9320-v2.8.patch
          diff -Naur a/hadoop-common-project/hadoop-common/HadoopCommon.cmake b/hadoop-common-project/hadoop-common/HadoopCommon.cmake
          --- a/hadoop-common-project/hadoop-common/HadoopCommon.cmake	2017-03-16 19:43:23.000000000 +0000
          +++ b/hadoop-common-project/hadoop-common/HadoopCommon.cmake	2017-05-21 15:22:32.832162322 +0000
          @@ -154,35 +154,6 @@
                   endif()
               endif()
           
          -    # Determine float ABI of JVM on ARM.
          -    if(CMAKE_SYSTEM_PROCESSOR MATCHES "^arm")
          -        find_program(READELF readelf)
          -        if(READELF MATCHES "NOTFOUND")
          -            message(WARNING "readelf not found; JVM float ABI detection disabled")
          -        else(READELF MATCHES "NOTFOUND")
          -            execute_process(
          -                COMMAND ${READELF} -A ${JAVA_JVM_LIBRARY}
          -                OUTPUT_VARIABLE JVM_ELF_ARCH
          -                ERROR_QUIET)
          -            if(NOT JVM_ELF_ARCH MATCHES "Tag_ABI_VFP_args: VFP registers")
          -                # Test compilation with -mfloat-abi=softfp using an arbitrary libc function
          -                # (typically fails with "fatal error: bits/predefs.h: No such file or directory"
          -                # if soft-float dev libraries are not installed)
          -                message("Soft-float JVM detected")
          -                include(CMakePushCheckState)
          -                cmake_push_check_state()
          -                set(CMAKE_REQUIRED_FLAGS "${CMAKE_REQUIRED_FLAGS} -mfloat-abi=softfp")
          -                include(CheckSymbolExists)
          -                check_symbol_exists(exit stdlib.h SOFTFP_AVAILABLE)
          -                if(NOT SOFTFP_AVAILABLE)
          -                    message(FATAL_ERROR "Soft-float dev libraries required (e.g. 'apt-get install libc6-dev-armel' on Debian/Ubuntu)")
          -                endif()
          -                cmake_pop_check_state()
          -                hadoop_add_compiler_flags("-mfloat-abi=softfp")
          -            endif()
          -        endif()
          -    endif()
          -
           #
           # Solaris-specific configuration.
           #
          diff -Naur a/hadoop-common-project/hadoop-common/HadoopJNI.cmake b/hadoop-common-project/hadoop-common/HadoopJNI.cmake
          --- a/hadoop-common-project/hadoop-common/HadoopJNI.cmake	2017-01-11 19:33:37.000000000 +0000
          +++ b/hadoop-common-project/hadoop-common/HadoopJNI.cmake	2017-05-21 15:23:01.612140922 +0000
          @@ -95,3 +95,38 @@
           else()
               find_package(JNI REQUIRED)
           endif()
          +
          +# Determine float ABI of JVM on ARM Linux
          +if (CMAKE_SYSTEM_PROCESSOR MATCHES "^arm" AND CMAKE_SYSTEM_NAME STREQUAL "Linux")
          +    find_program(READELF readelf)
          +    if (READELF MATCHES "NOTFOUND")
          +        message(WARNING "readelf not found; JVM float ABI detection disabled")
          +    else (READELF MATCHES "NOTFOUND")
          +        message(STATUS "Checking float ABI of ${JAVA_JVM_LIBRARY}")
          +        execute_process(
          +            COMMAND ${READELF} -A ${JAVA_JVM_LIBRARY}
          +            OUTPUT_VARIABLE JVM_ELF_ARCH
          +            ERROR_QUIET)
          +        if (JVM_ELF_ARCH MATCHES "Tag_ABI_VFP_args: VFP registers")
          +           message(STATUS "Hard-float JVM detected")
          +        else ()
          +            message(STATUS "Soft-float JVM detected")
          +
          +            # Test compilation with -mfloat-abi=softfp using an arbitrary libc function
          +            # (typically fails with "fatal error: bits/predefs.h: No such file or directory"
          +            # if soft-float dev libraries are not installed)
          +            include(CMakePushCheckState)
          +            cmake_push_check_state()
          +            set(CMAKE_REQUIRED_FLAGS "${CMAKE_REQUIRED_FLAGS} -mfloat-abi=softfp")
          +            include(CheckSymbolExists)
          +            check_symbol_exists(exit stdlib.h SOFTFP_AVAILABLE)
          +            if (NOT SOFTFP_AVAILABLE)
          +                message(FATAL_ERROR "Soft-float dev libraries required (e.g. 'apt-get install libc6-dev-armel' on Debian/Ubuntu)")
          +            endif (NOT SOFTFP_AVAILABLE)
          +            cmake_pop_check_state()
          +
          +            set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -mfloat-abi=softfp")
          +        endif ()
          +    endif (READELF MATCHES "NOTFOUND")
          +endif (CMAKE_SYSTEM_PROCESSOR MATCHES "^arm" AND CMAKE_SYSTEM_NAME STREQUAL "Linux")
          +
          

          I added a Pull Request on github: https://github.com/apache/hadoop/pull/224

          Show
          amuttsch Andreas Muttscheller added a comment - - edited This problem still exist with Hadoop 2.8. Unfortunatelly, the patch doesn't work for this version. I updated the patch to work with Hadoop 2.8: HADOOP-9320 -v2.8.patch diff -Naur a/hadoop-common-project/hadoop-common/HadoopCommon.cmake b/hadoop-common-project/hadoop-common/HadoopCommon.cmake --- a/hadoop-common-project/hadoop-common/HadoopCommon.cmake 2017-03-16 19:43:23.000000000 +0000 +++ b/hadoop-common-project/hadoop-common/HadoopCommon.cmake 2017-05-21 15:22:32.832162322 +0000 @@ -154,35 +154,6 @@ endif() endif() - # Determine float ABI of JVM on ARM. - if (CMAKE_SYSTEM_PROCESSOR MATCHES "^arm" ) - find_program(READELF readelf) - if (READELF MATCHES "NOTFOUND" ) - message(WARNING "readelf not found; JVM float ABI detection disabled" ) - else (READELF MATCHES "NOTFOUND" ) - execute_process( - COMMAND ${READELF} -A ${JAVA_JVM_LIBRARY} - OUTPUT_VARIABLE JVM_ELF_ARCH - ERROR_QUIET) - if (NOT JVM_ELF_ARCH MATCHES "Tag_ABI_VFP_args: VFP registers" ) - # Test compilation with -mfloat-abi=softfp using an arbitrary libc function - # (typically fails with "fatal error: bits/predefs.h: No such file or directory" - # if soft- float dev libraries are not installed) - message( "Soft- float JVM detected" ) - include(CMakePushCheckState) - cmake_push_check_state() - set(CMAKE_REQUIRED_FLAGS "${CMAKE_REQUIRED_FLAGS} -mfloat-abi=softfp" ) - include(CheckSymbolExists) - check_symbol_exists(exit stdlib.h SOFTFP_AVAILABLE) - if (NOT SOFTFP_AVAILABLE) - message(FATAL_ERROR "Soft- float dev libraries required (e.g. 'apt-get install libc6-dev-armel' on Debian/Ubuntu)" ) - endif() - cmake_pop_check_state() - hadoop_add_compiler_flags( "-mfloat-abi=softfp" ) - endif() - endif() - endif() - # # Solaris-specific configuration. # diff -Naur a/hadoop-common-project/hadoop-common/HadoopJNI.cmake b/hadoop-common-project/hadoop-common/HadoopJNI.cmake --- a/hadoop-common-project/hadoop-common/HadoopJNI.cmake 2017-01-11 19:33:37.000000000 +0000 +++ b/hadoop-common-project/hadoop-common/HadoopJNI.cmake 2017-05-21 15:23:01.612140922 +0000 @@ -95,3 +95,38 @@ else () find_package(JNI REQUIRED) endif() + +# Determine float ABI of JVM on ARM Linux + if (CMAKE_SYSTEM_PROCESSOR MATCHES "^arm" AND CMAKE_SYSTEM_NAME STREQUAL "Linux" ) + find_program(READELF readelf) + if (READELF MATCHES "NOTFOUND" ) + message(WARNING "readelf not found; JVM float ABI detection disabled" ) + else (READELF MATCHES "NOTFOUND" ) + message(STATUS "Checking float ABI of ${JAVA_JVM_LIBRARY}" ) + execute_process( + COMMAND ${READELF} -A ${JAVA_JVM_LIBRARY} + OUTPUT_VARIABLE JVM_ELF_ARCH + ERROR_QUIET) + if (JVM_ELF_ARCH MATCHES "Tag_ABI_VFP_args: VFP registers" ) + message(STATUS "Hard- float JVM detected" ) + else () + message(STATUS "Soft- float JVM detected" ) + + # Test compilation with -mfloat-abi=softfp using an arbitrary libc function + # (typically fails with "fatal error: bits/predefs.h: No such file or directory" + # if soft- float dev libraries are not installed) + include(CMakePushCheckState) + cmake_push_check_state() + set(CMAKE_REQUIRED_FLAGS "${CMAKE_REQUIRED_FLAGS} -mfloat-abi=softfp" ) + include(CheckSymbolExists) + check_symbol_exists(exit stdlib.h SOFTFP_AVAILABLE) + if (NOT SOFTFP_AVAILABLE) + message(FATAL_ERROR "Soft- float dev libraries required (e.g. 'apt-get install libc6-dev-armel' on Debian/Ubuntu)" ) + endif (NOT SOFTFP_AVAILABLE) + cmake_pop_check_state() + + set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -mfloat-abi=softfp" ) + endif () + endif (READELF MATCHES "NOTFOUND" ) +endif (CMAKE_SYSTEM_PROCESSOR MATCHES "^arm" AND CMAKE_SYSTEM_NAME STREQUAL "Linux" ) + I added a Pull Request on github: https://github.com/apache/hadoop/pull/224
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user amuttsch opened a pull request:

          https://github.com/apache/hadoop/pull/224

          HADOOP-9320 Fix Hadoop native build failure on ARM hard-float

          Moved the ARM JVM float ABI detection from `HadoopCommon.cmake` to `HadoopJNI.cmake`, because `$

          {JAVA_JVM_LIBRARY}

          ` is not available in `HadoopCommon.cmake` yet and therefore the build fails.

          This commit fixes this issue.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/amuttsch/hadoop HADOOP-9320

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/hadoop/pull/224.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #224


          commit f40c8db28b382c21efa97bd892f778a1e51fedf7
          Author: Andreas Muttscheller <andreas.muttscheller@gmail.com>
          Date: 2017-05-21T15:45:41Z

          HADOOP-9320 Fix Hadoop native build failure on ARM hard-float


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user amuttsch opened a pull request: https://github.com/apache/hadoop/pull/224 HADOOP-9320 Fix Hadoop native build failure on ARM hard-float Moved the ARM JVM float ABI detection from `HadoopCommon.cmake` to `HadoopJNI.cmake`, because `$ {JAVA_JVM_LIBRARY} ` is not available in `HadoopCommon.cmake` yet and therefore the build fails. This commit fixes this issue. You can merge this pull request into a Git repository by running: $ git pull https://github.com/amuttsch/hadoop HADOOP-9320 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/hadoop/pull/224.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #224 commit f40c8db28b382c21efa97bd892f778a1e51fedf7 Author: Andreas Muttscheller <andreas.muttscheller@gmail.com> Date: 2017-05-21T15:45:41Z HADOOP-9320 Fix Hadoop native build failure on ARM hard-float
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 17s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 14m 28s trunk passed
          +1 compile 14m 59s trunk passed
          +1 mvnsite 1m 8s trunk passed
          +1 mvneclipse 0m 21s trunk passed
          +1 mvninstall 0m 40s the patch passed
          +1 compile 12m 41s the patch passed
          +1 cc 12m 41s the patch passed
          +1 javac 12m 41s the patch passed
          +1 mvnsite 1m 3s the patch passed
          +1 mvneclipse 0m 20s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 unit 7m 29s hadoop-common in the patch passed.
          +1 asflicense 0m 36s The patch does not generate ASF License warnings.
          54m 48s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue HADOOP-9320
          GITHUB PR https://github.com/apache/hadoop/pull/224
          Optional Tests asflicense compile cc mvnsite javac unit
          uname Linux fa57587d6636 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 46d9c4c
          Default Java 1.8.0_131
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12368/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12368/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 14m 28s trunk passed +1 compile 14m 59s trunk passed +1 mvnsite 1m 8s trunk passed +1 mvneclipse 0m 21s trunk passed +1 mvninstall 0m 40s the patch passed +1 compile 12m 41s the patch passed +1 cc 12m 41s the patch passed +1 javac 12m 41s the patch passed +1 mvnsite 1m 3s the patch passed +1 mvneclipse 0m 20s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 unit 7m 29s hadoop-common in the patch passed. +1 asflicense 0m 36s The patch does not generate ASF License warnings. 54m 48s Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HADOOP-9320 GITHUB PR https://github.com/apache/hadoop/pull/224 Optional Tests asflicense compile cc mvnsite javac unit uname Linux fa57587d6636 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 46d9c4c Default Java 1.8.0_131 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12368/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12368/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.

            People

            • Assignee:
              scurrilous Trevor Robinson
              Reporter:
              scurrilous Trevor Robinson
            • Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

              • Created:
                Updated:

                Development