Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: None
-
Fix Version/s: 0.23.7, 2.1.0-beta
-
Component/s: None
-
Labels:None
-
Target Version/s:
Description
Generating the latest site docs it doesn't show the -restoreFailedStorage option under the dfsadmin section of commands_manual.html
Also it appears the table header is concatenated with the first row:
COMMAND_OPTION -report
Activity
- All
- Comments
- Work Log
- History
- Activity
- Transitions
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12567514/hdfs4459.txt
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/3936//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3936//console
This message is automatically generated.
Hey Tom, does this patch look OK to you?
move to common since that is where changes are.
Looks good. +1 Thanks Andy!
Note made minor addition at checkin to add -restoreFailedStorage to the usage above the Command Options table.
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12567514/hdfs4459.txt
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2184//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2184//console
This message is automatically generated.
Integrated in Hadoop-trunk-Commit #3352 (See https://builds.apache.org/job/Hadoop-trunk-Commit/3352/)
HADOOP-9303. command manual dfsadmin missing entry for restoreFailedStorage option (Andy Isaacson via tgraves) (Revision 1445656)
Result = SUCCESS
tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1445656
Files :
- /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
- /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/site/apt/CommandsManual.apt.vm
Integrated in Hadoop-Yarn-trunk #127 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/127/)
HADOOP-9303. command manual dfsadmin missing entry for restoreFailedStorage option (Andy Isaacson via tgraves) (Revision 1445656)
Result = SUCCESS
tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1445656
Files :
- /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
- /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/site/apt/CommandsManual.apt.vm
Integrated in Hadoop-Hdfs-0.23-Build #525 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/525/)
HADOOP-9303. command manual dfsadmin missing entry for restoreFailedStorage option (Andy Isaacson via tgraves) (Revision 1445658)
Result = SUCCESS
tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1445658
Files :
- /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
- /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/site/apt/CommandsManual.apt.vm
Integrated in Hadoop-Hdfs-trunk #1316 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1316/)
HADOOP-9303. command manual dfsadmin missing entry for restoreFailedStorage option (Andy Isaacson via tgraves) (Revision 1445656)
Result = FAILURE
tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1445656
Files :
- /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
- /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/site/apt/CommandsManual.apt.vm
Integrated in Hadoop-Mapreduce-trunk #1344 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1344/)
HADOOP-9303. command manual dfsadmin missing entry for restoreFailedStorage option (Andy Isaacson via tgraves) (Revision 1445656)
Result = SUCCESS
tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1445656
Files :
- /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
- /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/site/apt/CommandsManual.apt.vm
Fix the table and add restoreFailedStorage docs. I'm a bit concerned how the -resetoreFailedStorage got dropped, but I did do a bunch of manual massaging of the APT markup and perhaps I just deleted it by accident.