Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-9233

Cover package org.apache.hadoop.io.compress.zlib with unit tests

    Details

    • Type: Test
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.3-alpha, 0.23.6, 3.0.0-alpha1
    • Fix Version/s: 2.1.0-beta, 0.23.8
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    1. HADOOP-9233-trunk-d.patch
      38 kB
      Vadim Bondarev
    2. HADOOP-9233-trunk-c.patch
      37 kB
      Vadim Bondarev
    3. HADOOP-9233-trunk-b.patch
      38 kB
      Vadim Bondarev
    4. HADOOP-9233-trunk-a.patch
      38 kB
      Vadim Bondarev
    5. HADOOP-9233-branch-2-b.patch
      38 kB
      Vadim Bondarev
    6. HADOOP-9233-branch-2-a.patch
      38 kB
      Vadim Bondarev
    7. HADOOP-9233-branch-0.23-b.patch
      38 kB
      Vadim Bondarev

      Activity

      Hide
      hadoopqa Hadoop QA added a comment -

      +1 overall. Here are the results of testing the latest attachment
      http://issues.apache.org/jira/secure/attachment/12565925/YAHOO-9233-trunk-a.patch
      against trunk revision .

      +1 @author. The patch does not contain any @author tags.

      +1 tests included. The patch appears to include 3 new or modified test files.

      +1 javac. The applied patch does not increase the total number of javac compiler warnings.

      +1 javadoc. The javadoc tool did not generate any warning messages.

      +1 eclipse:eclipse. The patch built with eclipse:eclipse.

      +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

      +1 release audit. The applied patch does not increase the total number of release audit warnings.

      +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.

      +1 contrib tests. The patch passed contrib unit tests.

      Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2077//testReport/
      Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2077//console

      This message is automatically generated.

      Show
      hadoopqa Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12565925/YAHOO-9233-trunk-a.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2077//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2077//console This message is automatically generated.
      Hide
      hadoopqa Hadoop QA added a comment -

      +1 overall. Here are the results of testing the latest attachment
      http://issues.apache.org/jira/secure/attachment/12567332/HADOOP-9233-trunk-a.patch
      against trunk revision .

      +1 @author. The patch does not contain any @author tags.

      +1 tests included. The patch appears to include 3 new or modified test files.

      +1 javac. The applied patch does not increase the total number of javac compiler warnings.

      +1 javadoc. The javadoc tool did not generate any warning messages.

      +1 eclipse:eclipse. The patch built with eclipse:eclipse.

      +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

      +1 release audit. The applied patch does not increase the total number of release audit warnings.

      +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.

      +1 contrib tests. The patch passed contrib unit tests.

      Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2123//testReport/
      Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2123//console

      This message is automatically generated.

      Show
      hadoopqa Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12567332/HADOOP-9233-trunk-a.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2123//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2123//console This message is automatically generated.
      Hide
      hadoopqa Hadoop QA added a comment -

      +1 overall. Here are the results of testing the latest attachment
      http://issues.apache.org/jira/secure/attachment/12568215/HADOOP-9233-trunk-a.patch
      against trunk revision .

      +1 @author. The patch does not contain any @author tags.

      +1 tests included. The patch appears to include 3 new or modified test files.

      +1 javac. The applied patch does not increase the total number of javac compiler warnings.

      +1 javadoc. The javadoc tool did not generate any warning messages.

      +1 eclipse:eclipse. The patch built with eclipse:eclipse.

      +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

      +1 release audit. The applied patch does not increase the total number of release audit warnings.

      +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.

      +1 contrib tests. The patch passed contrib unit tests.

      Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2156//testReport/
      Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2156//console

      This message is automatically generated.

      Show
      hadoopqa Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12568215/HADOOP-9233-trunk-a.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2156//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2156//console This message is automatically generated.
      Hide
      hadoopqa Hadoop QA added a comment -

      +1 overall. Here are the results of testing the latest attachment
      http://issues.apache.org/jira/secure/attachment/12576570/HADOOP-9233-trunk-b.patch
      against trunk revision .

      +1 @author. The patch does not contain any @author tags.

      +1 tests included. The patch appears to include 3 new or modified test files.

      +1 javac. The applied patch does not increase the total number of javac compiler warnings.

      +1 javadoc. The javadoc tool did not generate any warning messages.

      +1 eclipse:eclipse. The patch built with eclipse:eclipse.

      +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

      +1 release audit. The applied patch does not increase the total number of release audit warnings.

      +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.

      +1 contrib tests. The patch passed contrib unit tests.

      Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2397//testReport/
      Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2397//console

      This message is automatically generated.

      Show
      hadoopqa Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12576570/HADOOP-9233-trunk-b.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2397//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2397//console This message is automatically generated.
      Hide
      jlowe Jason Lowe added a comment -

      Thanks for posting a patch for this, Vadim. A few comments:

      CompressDecompressTester.java:

      • The Visitor interface has exactly one class that implements it, exactly one instance of that class, and exactly one function that calls the interface. This seems like abstraction layers that are making the code harder to read and not adding any value, or do you have future expansion plans for this? It would be a lot simpler to just have a static function that takes compressor object and returns a boolean on whether it's available.

      TestCompressorDecompressor.java:

      • Nit: Any reason why line 110 isn't just:
          byte[] array = new byte[size];
        
      • Rather than an explicit array with values from 0x0-0xF, can't we just use the value returned from rnd.nextInt(15) directly?
      • There are a number of unused imports.

      TestZlibCompressorDecompressor.java:

      • There are a number of unused imports.
      • In testZlibCompressorDecompressorWithConfiguration and testZlibCompressorDecompressorSetDictionary we are using assertFalse on a condition that was just checked by the if statement as false so this assert will never fire.

      Also note that it's unnecessary to post separate patches for branch-2 and branch-0.23 if the trunk patch will apply to them as well.

      Show
      jlowe Jason Lowe added a comment - Thanks for posting a patch for this, Vadim. A few comments: CompressDecompressTester.java: The Visitor interface has exactly one class that implements it, exactly one instance of that class, and exactly one function that calls the interface. This seems like abstraction layers that are making the code harder to read and not adding any value, or do you have future expansion plans for this? It would be a lot simpler to just have a static function that takes compressor object and returns a boolean on whether it's available. TestCompressorDecompressor.java: Nit: Any reason why line 110 isn't just: byte [] array = new byte [size]; Rather than an explicit array with values from 0x0-0xF, can't we just use the value returned from rnd.nextInt(15) directly? There are a number of unused imports. TestZlibCompressorDecompressor.java: There are a number of unused imports. In testZlibCompressorDecompressorWithConfiguration and testZlibCompressorDecompressorSetDictionary we are using assertFalse on a condition that was just checked by the if statement as false so this assert will never fire. Also note that it's unnecessary to post separate patches for branch-2 and branch-0.23 if the trunk patch will apply to them as well.
      Hide
      vbondarev Vadim Bondarev added a comment -

      New patch version was attached.

      Show
      vbondarev Vadim Bondarev added a comment - New patch version was attached.
      Hide
      hadoopqa Hadoop QA added a comment -

      +1 overall. Here are the results of testing the latest attachment
      http://issues.apache.org/jira/secure/attachment/12577518/HADOOP-9233-trunk-c.patch
      against trunk revision .

      +1 @author. The patch does not contain any @author tags.

      +1 tests included. The patch appears to include 3 new or modified test files.

      +1 javac. The applied patch does not increase the total number of javac compiler warnings.

      +1 javadoc. The javadoc tool did not generate any warning messages.

      +1 eclipse:eclipse. The patch built with eclipse:eclipse.

      +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

      +1 release audit. The applied patch does not increase the total number of release audit warnings.

      +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.

      +1 contrib tests. The patch passed contrib unit tests.

      Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2426//testReport/
      Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2426//console

      This message is automatically generated.

      Show
      hadoopqa Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12577518/HADOOP-9233-trunk-c.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2426//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2426//console This message is automatically generated.
      Hide
      jlowe Jason Lowe added a comment -

      Thanks for the update, Vadim. Another issue I ran into while trying out the patch is running the unit tests when native code support is not compiled. TestCompressorDecompressor fails in this case:

      java.lang.UnsatisfiedLinkError: org.apache.hadoop.io.compress.zlib.ZlibCompressor.init(III)J
      	at org.apache.hadoop.io.compress.zlib.ZlibCompressor.init(Native Method)
      	at org.apache.hadoop.io.compress.zlib.ZlibCompressor.<init>(ZlibCompressor.java:228)
      	at org.apache.hadoop.io.compress.zlib.ZlibCompressor.<init>(ZlibCompressor.java:198)
      	at org.apache.hadoop.io.compress.TestCompressorDecompressor.testCompressorDecompressor(TestCompressorDecompressor.java:44)
      

      We can't construct a ZlibCompressor or ZlibDecompressor without native code support, which is why ZlibFactory hides this in its getZlibCompressor and getZlibDecompressor methods. We either need to use those methods (with conf settings to get the two types we want) or have the code conditionally exclude the native codec support based on ZLibFactory#isNativeZlibLoaded.

      Arguably the acceptor function should also be checking this otherwise we run the risk of the native code being loaded but zlib libraries are for some reason unavailable.

      Show
      jlowe Jason Lowe added a comment - Thanks for the update, Vadim. Another issue I ran into while trying out the patch is running the unit tests when native code support is not compiled. TestCompressorDecompressor fails in this case: java.lang.UnsatisfiedLinkError: org.apache.hadoop.io.compress.zlib.ZlibCompressor.init(III)J at org.apache.hadoop.io.compress.zlib.ZlibCompressor.init(Native Method) at org.apache.hadoop.io.compress.zlib.ZlibCompressor.<init>(ZlibCompressor.java:228) at org.apache.hadoop.io.compress.zlib.ZlibCompressor.<init>(ZlibCompressor.java:198) at org.apache.hadoop.io.compress.TestCompressorDecompressor.testCompressorDecompressor(TestCompressorDecompressor.java:44) We can't construct a ZlibCompressor or ZlibDecompressor without native code support, which is why ZlibFactory hides this in its getZlibCompressor and getZlibDecompressor methods. We either need to use those methods (with conf settings to get the two types we want) or have the code conditionally exclude the native codec support based on ZLibFactory#isNativeZlibLoaded . Arguably the acceptor function should also be checking this otherwise we run the risk of the native code being loaded but zlib libraries are for some reason unavailable.
      Hide
      vbondarev Vadim Bondarev added a comment -

      1.ZlibCompressor/ZlibDecompressor was replaced in TestZlibCompressorDecompressor class
      2.Used ZlibFactory for check on native code
      3.Created static function "generate" instead ByteGenerator class

      Show
      vbondarev Vadim Bondarev added a comment - 1.ZlibCompressor/ZlibDecompressor was replaced in TestZlibCompressorDecompressor class 2.Used ZlibFactory for check on native code 3.Created static function "generate" instead ByteGenerator class
      Hide
      hadoopqa Hadoop QA added a comment -

      +1 overall. Here are the results of testing the latest attachment
      http://issues.apache.org/jira/secure/attachment/12577783/HADOOP-9233-trunk-d.patch
      against trunk revision .

      +1 @author. The patch does not contain any @author tags.

      +1 tests included. The patch appears to include 3 new or modified test files.

      +1 javac. The applied patch does not increase the total number of javac compiler warnings.

      +1 javadoc. The javadoc tool did not generate any warning messages.

      +1 eclipse:eclipse. The patch built with eclipse:eclipse.

      +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

      +1 release audit. The applied patch does not increase the total number of release audit warnings.

      +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.

      +1 contrib tests. The patch passed contrib unit tests.

      Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2436//testReport/
      Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2436//console

      This message is automatically generated.

      Show
      hadoopqa Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12577783/HADOOP-9233-trunk-d.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2436//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2436//console This message is automatically generated.
      Hide
      jlowe Jason Lowe added a comment -

      +1, lgtm. There are still unused imports in CompressDecompressTester which I'll cleanup during the commit.

      Show
      jlowe Jason Lowe added a comment - +1, lgtm. There are still unused imports in CompressDecompressTester which I'll cleanup during the commit.
      Hide
      hudson Hudson added a comment -

      Integrated in Hadoop-trunk-Commit #3600 (See https://builds.apache.org/job/Hadoop-trunk-Commit/3600/)
      HADOOP-9233. Cover package org.apache.hadoop.io.compress.zlib with unit tests. Contributed by Vadim Bondarev (Revision 1467090)

      Result = SUCCESS
      jlowe : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1467090
      Files :

      • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
      • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/CompressDecompressTester.java
      • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/TestCompressorDecompressor.java
      • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/zlib
      • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/zlib/TestZlibCompressorDecompressor.java
      Show
      hudson Hudson added a comment - Integrated in Hadoop-trunk-Commit #3600 (See https://builds.apache.org/job/Hadoop-trunk-Commit/3600/ ) HADOOP-9233 . Cover package org.apache.hadoop.io.compress.zlib with unit tests. Contributed by Vadim Bondarev (Revision 1467090) Result = SUCCESS jlowe : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1467090 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/CompressDecompressTester.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/TestCompressorDecompressor.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/zlib /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/zlib/TestZlibCompressorDecompressor.java
      Hide
      jlowe Jason Lowe added a comment -

      Thansk, Vadim! I committed this to trunk, branch-2, and branch-0.23.

      Show
      jlowe Jason Lowe added a comment - Thansk, Vadim! I committed this to trunk, branch-2, and branch-0.23.
      Hide
      hudson Hudson added a comment -

      Integrated in Hadoop-Yarn-trunk #181 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/181/)
      HADOOP-9233. Cover package org.apache.hadoop.io.compress.zlib with unit tests. Contributed by Vadim Bondarev (Revision 1467090)

      Result = SUCCESS
      jlowe : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1467090
      Files :

      • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
      • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/CompressDecompressTester.java
      • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/TestCompressorDecompressor.java
      • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/zlib
      • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/zlib/TestZlibCompressorDecompressor.java
      Show
      hudson Hudson added a comment - Integrated in Hadoop-Yarn-trunk #181 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/181/ ) HADOOP-9233 . Cover package org.apache.hadoop.io.compress.zlib with unit tests. Contributed by Vadim Bondarev (Revision 1467090) Result = SUCCESS jlowe : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1467090 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/CompressDecompressTester.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/TestCompressorDecompressor.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/zlib /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/zlib/TestZlibCompressorDecompressor.java
      Hide
      hudson Hudson added a comment -

      Integrated in Hadoop-Hdfs-0.23-Build #579 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/579/)
      svn merge -c 1467090 FIXES: HADOOP-9233. Cover package org.apache.hadoop.io.compress.zlib with unit tests. Contributed by Vadim Bondarev (Revision 1467102)

      Result = SUCCESS
      jlowe : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1467102
      Files :

      • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
      • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/CompressDecompressTester.java
      • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/TestCompressorDecompressor.java
      • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/zlib
      • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/zlib/TestZlibCompressorDecompressor.java
      Show
      hudson Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #579 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/579/ ) svn merge -c 1467090 FIXES: HADOOP-9233 . Cover package org.apache.hadoop.io.compress.zlib with unit tests. Contributed by Vadim Bondarev (Revision 1467102) Result = SUCCESS jlowe : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1467102 Files : /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/CompressDecompressTester.java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/TestCompressorDecompressor.java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/zlib /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/zlib/TestZlibCompressorDecompressor.java
      Hide
      hudson Hudson added a comment -

      Integrated in Hadoop-Hdfs-trunk #1370 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1370/)
      HADOOP-9233. Cover package org.apache.hadoop.io.compress.zlib with unit tests. Contributed by Vadim Bondarev (Revision 1467090)

      Result = FAILURE
      jlowe : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1467090
      Files :

      • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
      • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/CompressDecompressTester.java
      • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/TestCompressorDecompressor.java
      • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/zlib
      • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/zlib/TestZlibCompressorDecompressor.java
      Show
      hudson Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1370 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1370/ ) HADOOP-9233 . Cover package org.apache.hadoop.io.compress.zlib with unit tests. Contributed by Vadim Bondarev (Revision 1467090) Result = FAILURE jlowe : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1467090 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/CompressDecompressTester.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/TestCompressorDecompressor.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/zlib /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/zlib/TestZlibCompressorDecompressor.java
      Hide
      hudson Hudson added a comment -

      Integrated in Hadoop-Mapreduce-trunk #1397 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1397/)
      HADOOP-9233. Cover package org.apache.hadoop.io.compress.zlib with unit tests. Contributed by Vadim Bondarev (Revision 1467090)

      Result = SUCCESS
      jlowe : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1467090
      Files :

      • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
      • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/CompressDecompressTester.java
      • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/TestCompressorDecompressor.java
      • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/zlib
      • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/zlib/TestZlibCompressorDecompressor.java
      Show
      hudson Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1397 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1397/ ) HADOOP-9233 . Cover package org.apache.hadoop.io.compress.zlib with unit tests. Contributed by Vadim Bondarev (Revision 1467090) Result = SUCCESS jlowe : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1467090 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/CompressDecompressTester.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/TestCompressorDecompressor.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/zlib /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/zlib/TestZlibCompressorDecompressor.java

        People

        • Assignee:
          vbondarev Vadim Bondarev
          Reporter:
          vbondarev Vadim Bondarev
        • Votes:
          0 Vote for this issue
          Watchers:
          6 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development