Hadoop Common
  1. Hadoop Common
  2. HADOOP-9216

CompressionCodecFactory#getCodecClasses should trim the result of parsing by Configuration.

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.3-alpha, 0.23.6, 3.0.0
    • Fix Version/s: 2.0.3-alpha, 0.23.7
    • Component/s: io
    • Labels:
      None

      Description

      CompressionCodecFactory#getCodecClasses doesn't trim its input.
      This can confuse users of CompressionCodecFactory. For example, The setting as follows can cause error because of spaces in the values.

      conf.set("io.compression.codecs",
      " org.apache.hadoop.io.compress.GzipCodec , " +
      " org.apache.hadoop.io.compress.DefaultCodec , " +
      "org.apache.hadoop.io.compress.BZip2Codec ");

      This ticket deals with this problem.

      1. HADOOP-9216.patch
        3 kB
        Tsuyoshi Ozawa

        Activity

        Tsuyoshi Ozawa created issue -
        Hide
        Tsuyoshi Ozawa added a comment -

        Attach test and fix.

        Show
        Tsuyoshi Ozawa added a comment - Attach test and fix.
        Tsuyoshi Ozawa made changes -
        Field Original Value New Value
        Attachment HADOOP-9216.patch [ 12565001 ]
        Tsuyoshi Ozawa made changes -
        Description CompressionCodecFactory#getCodecClasses doesn't trim its input.
        This can confuse users of CompressionCodecFactory.
        CompressionCodecFactory#getCodecClasses doesn't trim its input.
        This can confuse users of CompressionCodecFactory. For example, The setting as follows can cause error because of spaces in the values.

        {quote}
             conf.set("io.compression.codecs",
                " org.apache.hadoop.io.compress.GzipCodec , " +
                " org.apache.hadoop.io.compress.DefaultCodec , " +
                "org.apache.hadoop.io.compress.BZip2Codec ");
        {quote}


        This ticket deals with this problem.
        Todd Lipcon made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Todd Lipcon added a comment -

        Looks good to me. +1 pending Jenkins.

        Show
        Todd Lipcon added a comment - Looks good to me. +1 pending Jenkins.
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12565001/HADOOP-9216.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2055//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2055//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12565001/HADOOP-9216.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2055//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2055//console This message is automatically generated.
        Thomas Graves made changes -
        Target Version/s 3.0.0, 2.0.3-alpha, 0.23.6 [ 12320357, 12323273, 12323504 ] 3.0.0, 2.0.3-alpha, 0.23.7 [ 12320357, 12323273, 12323956 ]
        Hide
        Todd Lipcon added a comment -

        Committed to branch-2 and trunk. Thanks, Tsuyoshi!

        Show
        Todd Lipcon added a comment - Committed to branch-2 and trunk. Thanks, Tsuyoshi!
        Todd Lipcon made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags Reviewed [ 10343 ]
        Fix Version/s 3.0.0 [ 12320357 ]
        Fix Version/s 2.0.3-alpha [ 12323273 ]
        Resolution Fixed [ 1 ]
        Todd Lipcon made changes -
        Assignee Tsuyoshi OZAWA [ ozawa ]
        Hide
        Hudson added a comment -

        Integrated in Hadoop-trunk-Commit #3254 (See https://builds.apache.org/job/Hadoop-trunk-Commit/3254/)
        HADOOP-9216. CompressionCodecFactory#getCodecClasses should trim the result of parsing by Configuration. Contributed by Tsuyoshi Ozawa. (Revision 1434569)

        Result = SUCCESS
        todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1434569
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/CompressionCodecFactory.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/TestCodecFactory.java
        Show
        Hudson added a comment - Integrated in Hadoop-trunk-Commit #3254 (See https://builds.apache.org/job/Hadoop-trunk-Commit/3254/ ) HADOOP-9216 . CompressionCodecFactory#getCodecClasses should trim the result of parsing by Configuration. Contributed by Tsuyoshi Ozawa. (Revision 1434569) Result = SUCCESS todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1434569 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/CompressionCodecFactory.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/TestCodecFactory.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Yarn-trunk #99 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/99/)
        HADOOP-9216. CompressionCodecFactory#getCodecClasses should trim the result of parsing by Configuration. Contributed by Tsuyoshi Ozawa. (Revision 1434569)

        Result = SUCCESS
        todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1434569
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/CompressionCodecFactory.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/TestCodecFactory.java
        Show
        Hudson added a comment - Integrated in Hadoop-Yarn-trunk #99 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/99/ ) HADOOP-9216 . CompressionCodecFactory#getCodecClasses should trim the result of parsing by Configuration. Contributed by Tsuyoshi Ozawa. (Revision 1434569) Result = SUCCESS todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1434569 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/CompressionCodecFactory.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/TestCodecFactory.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #1288 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1288/)
        HADOOP-9216. CompressionCodecFactory#getCodecClasses should trim the result of parsing by Configuration. Contributed by Tsuyoshi Ozawa. (Revision 1434569)

        Result = FAILURE
        todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1434569
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/CompressionCodecFactory.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/TestCodecFactory.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1288 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1288/ ) HADOOP-9216 . CompressionCodecFactory#getCodecClasses should trim the result of parsing by Configuration. Contributed by Tsuyoshi Ozawa. (Revision 1434569) Result = FAILURE todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1434569 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/CompressionCodecFactory.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/TestCodecFactory.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #1316 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1316/)
        HADOOP-9216. CompressionCodecFactory#getCodecClasses should trim the result of parsing by Configuration. Contributed by Tsuyoshi Ozawa. (Revision 1434569)

        Result = FAILURE
        todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1434569
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/CompressionCodecFactory.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/TestCodecFactory.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1316 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1316/ ) HADOOP-9216 . CompressionCodecFactory#getCodecClasses should trim the result of parsing by Configuration. Contributed by Tsuyoshi Ozawa. (Revision 1434569) Result = FAILURE todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1434569 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/CompressionCodecFactory.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/TestCodecFactory.java
        Hide
        Thomas Graves added a comment -

        merged to branch-0.23

        Show
        Thomas Graves added a comment - merged to branch-0.23
        Thomas Graves made changes -
        Fix Version/s 0.23.7 [ 12323956 ]
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-0.23-Build #498 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/498/)
        HADOOP-9216. CompressionCodecFactory#getCodecClasses should trim the result of parsing by Configuration. (Tsuyoshi Ozawa via todd) (Revision 1434893)

        Result = FAILURE
        tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1434893
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/CompressionCodecFactory.java
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/TestCodecFactory.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #498 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/498/ ) HADOOP-9216 . CompressionCodecFactory#getCodecClasses should trim the result of parsing by Configuration. (Tsuyoshi Ozawa via todd) (Revision 1434893) Result = FAILURE tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1434893 Files : /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/CompressionCodecFactory.java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/TestCodecFactory.java
        Arun C Murthy made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Allen Wittenauer made changes -
        Fix Version/s 3.0.0 [ 12320357 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        4h 35m 1 Todd Lipcon 16/Jan/13 01:45
        Patch Available Patch Available Resolved Resolved
        1d 5h 35m 1 Todd Lipcon 17/Jan/13 07:20
        Resolved Resolved Closed Closed
        29d 5h 52m 1 Arun C Murthy 15/Feb/13 13:12

          People

          • Assignee:
            Tsuyoshi Ozawa
            Reporter:
            Tsuyoshi Ozawa
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development