Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-9202

test-patch.sh fails during mvn eclipse:eclipse if patch adds a new module to the build

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-alpha1
    • Fix Version/s: 3.0.0-alpha1
    • Component/s: build
    • Labels:
      None
    • Target Version/s:

      Description

      test-patch.sh tries running mvn eclipse:eclipse after applying the patch. It runs this before running mvn install. The mvn eclipse:eclipse command doesn't actually build the code, so if the patch in question is adding a whole new module, then any other modules dependent on finding it in the reactor will fail.

      1. HADOOP-9202.1.patch
        0.5 kB
        Chris Nauroth

        Issue Links

          Activity

          Hide
          hudson Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #1314 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1314/)
          HADOOP-9202. test-patch.sh fails during mvn eclipse:eclipse if patch adds a new module to the build (Chris Nauroth via bobby) (Revision 1432949)

          Result = FAILURE
          bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1432949
          Files :

          • /hadoop/common/trunk/dev-support/test-patch.sh
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1314 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1314/ ) HADOOP-9202 . test-patch.sh fails during mvn eclipse:eclipse if patch adds a new module to the build (Chris Nauroth via bobby) (Revision 1432949) Result = FAILURE bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1432949 Files : /hadoop/common/trunk/dev-support/test-patch.sh /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #1286 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1286/)
          HADOOP-9202. test-patch.sh fails during mvn eclipse:eclipse if patch adds a new module to the build (Chris Nauroth via bobby) (Revision 1432949)

          Result = FAILURE
          bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1432949
          Files :

          • /hadoop/common/trunk/dev-support/test-patch.sh
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1286 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1286/ ) HADOOP-9202 . test-patch.sh fails during mvn eclipse:eclipse if patch adds a new module to the build (Chris Nauroth via bobby) (Revision 1432949) Result = FAILURE bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1432949 Files : /hadoop/common/trunk/dev-support/test-patch.sh /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          Integrated in Hadoop-Yarn-trunk #97 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/97/)
          HADOOP-9202. test-patch.sh fails during mvn eclipse:eclipse if patch adds a new module to the build (Chris Nauroth via bobby) (Revision 1432949)

          Result = SUCCESS
          bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1432949
          Files :

          • /hadoop/common/trunk/dev-support/test-patch.sh
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - Integrated in Hadoop-Yarn-trunk #97 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/97/ ) HADOOP-9202 . test-patch.sh fails during mvn eclipse:eclipse if patch adds a new module to the build (Chris Nauroth via bobby) (Revision 1432949) Result = SUCCESS bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1432949 Files : /hadoop/common/trunk/dev-support/test-patch.sh /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          Integrated in Hadoop-trunk-Commit #3225 (See https://builds.apache.org/job/Hadoop-trunk-Commit/3225/)
          HADOOP-9202. test-patch.sh fails during mvn eclipse:eclipse if patch adds a new module to the build (Chris Nauroth via bobby) (Revision 1432949)

          Result = SUCCESS
          bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1432949
          Files :

          • /hadoop/common/trunk/dev-support/test-patch.sh
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - Integrated in Hadoop-trunk-Commit #3225 (See https://builds.apache.org/job/Hadoop-trunk-Commit/3225/ ) HADOOP-9202 . test-patch.sh fails during mvn eclipse:eclipse if patch adds a new module to the build (Chris Nauroth via bobby) (Revision 1432949) Result = SUCCESS bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1432949 Files : /hadoop/common/trunk/dev-support/test-patch.sh /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          revans2 Robert Joseph Evans added a comment -

          I put this into trunk

          Show
          revans2 Robert Joseph Evans added a comment - I put this into trunk
          Hide
          revans2 Robert Joseph Evans added a comment -

          The change looks fine to me +1

          I'll check it in. Thanks for finding this.

          Show
          revans2 Robert Joseph Evans added a comment - The change looks fine to me +1 I'll check it in. Thanks for finding this.
          Hide
          hadoopqa Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12564576/HADOOP-9202.1.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in .

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2032//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2032//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12564576/HADOOP-9202.1.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in . +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2032//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2032//console This message is automatically generated.
          Hide
          cnauroth Chris Nauroth added a comment -

          I found this while working on HADOOP-8924, which adds a new module for a custom Maven plugin used to generate version info. This patch solves the problem by moving the mvn eclipse:eclipse check after the mvn install.

          Show
          cnauroth Chris Nauroth added a comment - I found this while working on HADOOP-8924 , which adds a new module for a custom Maven plugin used to generate version info. This patch solves the problem by moving the mvn eclipse:eclipse check after the mvn install.

            People

            • Assignee:
              cnauroth Chris Nauroth
              Reporter:
              cnauroth Chris Nauroth
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development