Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-9199

Cover package org.apache.hadoop.io with unit tests

    Details

    • Type: Test
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.3-alpha, 0.23.6, 3.0.0-alpha1
    • Fix Version/s: 2.3.0
    • Component/s: None
    • Labels:
      None
    1. HADOOP-9199-branch-0.23-a.patch
      65 kB
      Vadim Bondarev
    2. HADOOP-9199-branch-0.23-b.patch
      69 kB
      Vadim Bondarev
    3. HADOOP-9199-branch-0.23-c.patch
      75 kB
      Vadim Bondarev
    4. HADOOP-9199-branch-0.23-e.patch
      75 kB
      Vadim Bondarev
    5. HADOOP-9199-branch-2-a.patch
      64 kB
      Vadim Bondarev
    6. HADOOP-9199-branch-2-b.patch
      69 kB
      Vadim Bondarev
    7. HADOOP-9199-branch-2-c.patch
      75 kB
      Vadim Bondarev
    8. HADOOP-9199-branch-2-e.patch
      75 kB
      Vadim Bondarev
    9. HADOOP-9199-trunk-a.patch
      64 kB
      Vadim Bondarev
    10. HADOOP-9199-trunk-b.patch
      69 kB
      Vadim Bondarev
    11. HADOOP-9199-trunk-c.patch
      75 kB
      Vadim Bondarev
    12. HADOOP-9199-trunk-e.patch
      75 kB
      Vadim Bondarev
    13. HADOOP-9199-trunk--n6.patch
      78 kB
      Andrey Klochkov
    14. HADOOP-9199-trunk--n7.patch
      81 kB
      Andrey Klochkov

      Activity

      Hide
      hadoopqa Hadoop QA added a comment -

      -1 overall. Here are the results of testing the latest attachment
      http://issues.apache.org/jira/secure/attachment/12564441/HADOOP-9199-trunk-a.patch
      against trunk revision .

      +1 @author. The patch does not contain any @author tags.

      +1 tests included. The patch appears to include 16 new or modified test files.

      +1 javac. The applied patch does not increase the total number of javac compiler warnings.

      +1 javadoc. The javadoc tool did not generate any warning messages.

      +1 eclipse:eclipse. The patch built with eclipse:eclipse.

      +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

      +1 release audit. The applied patch does not increase the total number of release audit warnings.

      -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common:

      org.apache.hadoop.ha.TestZKFailoverController

      +1 contrib tests. The patch passed contrib unit tests.

      Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2026//testReport/
      Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2026//console

      This message is automatically generated.

      Show
      hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12564441/HADOOP-9199-trunk-a.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 16 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-common-project/hadoop-common: org.apache.hadoop.ha.TestZKFailoverController +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2026//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2026//console This message is automatically generated.
      Hide
      sureshms Suresh Srinivas added a comment -

      Can you please add a brief description of changes you are making in this patch?

      Show
      sureshms Suresh Srinivas added a comment - Can you please add a brief description of changes you are making in this patch?
      Hide
      sureshms Suresh Srinivas added a comment -

      One more quick comment looking at the patch - please add brief description to every test on what it is testing. Tests become harder to understand and maintain without this.

      Show
      sureshms Suresh Srinivas added a comment - One more quick comment looking at the patch - please add brief description to every test on what it is testing. Tests become harder to understand and maintain without this.
      Hide
      vbondarev Vadim Bondarev added a comment -

      add description in issue or in test source code ?

      Show
      vbondarev Vadim Bondarev added a comment - add description in issue or in test source code ?
      Hide
      vbondarev Vadim Bondarev added a comment -

      Classes Method Desc

      TestArrayFile testArrayFileIteration test ArrayFile.Reader methods next(); reader reader.seek() in range and out of range.

      TestArrayWritable testArrayWritableStringConstructor test ArrayWritable constructor with String[] as a parameter
      testNullArgument test TextArrayWritable with null parameter
      testArrayWritableToArray test TextArrayWritable toArray() method

      TestBloomMapFile testBloomMapFileConstructors test all BloomMapFile.Writer available constructors.
      testDeleteFile test method BloomMapFile.delete.
      testGetBloomMapFile test BloomMapFile.Reader method get(Writable wr) in range and out of range.
      testIOExceptionInWriterConstructor test BloomMapFile.Reader constructor with throw IOException in filesystem.getFileSystem(conf);

      TestBooleanWritable testCommonMethods test methods hashCode(), equals(), compareTo() against instance of type BooleanWritable

      TestBytesWritable testObjectCommonMethods test methods compareTo(), toString(), equals() against instance of type ByteWritable

      TestCompressedWritable testCompressedWritableWriteHeader test CompressedWritable write(DataOutputBuffer) method
      testCompressedWritableReadFields test CompressedWritable readFields() method

      TestEnumSetWritable testEnumSetWritableEquals test equals() method against instance of type EnumSetWritable
      testEnumSetWritableWriteRead test EnumSetWritable write(DataOutputBuffer out) and iteration by TestEnumSet through iterator().

      TestMapFile
      testDeprecatedConstructors test all available constructor of type MapFile.Writer.
      testDescOrderWithThrowExceptionWriterAppend test MapFile.Writer method append(Writable wr) in desc order (2, 1);
      testFix test MapFile.fix() method which attempts to re-creating MapFile index.
      testGetClosestOnCurrentApi test method reader.getClosest(WritableComparable wrc) variations.
      testKeyLessWriterCreation test MapFile.Writer constructor without varargs paramereters (SequenceFile.Writer.Option... opts).
      testKeyValueClasses test on verification key and value classes for MapFile.Writer type.
      testMainMethodMapFile test for static void main() method.
      testMidKeyOnCurrentApi test MapFile.Reader method reader.midKey() which get key in the middle of the file.
      testOnFinalKey test MapFile.Reader method reader.finalKey() which get key in the end of file.
      testPathExplosionWriterCreation test IOException in MapFile.Writer constructor
      testReaderKeyIteration test MapFile.Reader method reader.next(key, value) for iteration.
      testReaderWithWrongKeyClass test MapFile.Reader method reader.getClosest() whith wrond class key
      testReaderWithWrongValueClass test MapFile.Writer method writer.append() with wrong type key instance
      testRename test MapFile.rename() method
      testRenameWithException test MapFile.rename() method with throw IOException
      testRenameWithFalse test MapFile.rename() method with FleSystem.rename return false
      testWriteWithFailDirCreation test MapFile.Writer constructor with throw IOException
      TestMultipleIOException
      testEmptyParamIOException test MultipleIOException.createIOException() method
      testSingleParamIOException test MultipleIOException.testSingleParamIOException() method
      testMultipleIOException test MultipleIOException.createIOException() method

      TestNullWritable
      testNullableWritable test uncovered methods in class NullWritable

      TestOutputBuffer testOutputBufferWithoutResize test OutputBuffer methods write(InputStream in, int), out.getData()
      testOutputBufferReset test just like previous only with adding out.reset() call

      TestSetFile testSetFileAccessMethods test SetFile.Reader next(), get() combination method

      TestText testBytesToCodePoint test static method Text.bytesToCodePoint();
      testCharAt test Text class method charAt in range and out of range
      testReadWriteOperations test Text readFields()/write() methods combination
      testUtf8Length test Text.utf8Length() static method
      testbytesToCodePointWithInvalidUTF test static method with invalid utf value (throw BufferUnderflowException)

      TestTwoDArrayWritable test2DArrayConstructor test TwoDArrayWritable constructor with Text[][] parameter
      test2DArrayToArray test TwoDArrayWritable toArray() method
      test2DArrayWriteRead test TwoDArrayWritable methods combination
      testIllegalAccessException test IllegalAccessException in TwoDArrayWritable.readFields() method
      testInstantiationException test InstantiationException in TwoDArrayWritable.readFields() method

      TestVLongWritable testReadFields test VLongWritable.readFields(in) method
      testSetGetVLong test VLongWritable combination of methods set()/get() equals(), compareTo()

      TestWritableComparator
      testReadTypes test static methods readUnsignedShort()/readVInt()/readVLong with different parameters
      testShouldThrowsException test WritableComparator.compare with Exception
      testWritableComparator test WritableComparator.compare with >, <, = results

      Show
      vbondarev Vadim Bondarev added a comment - Classes Method Desc TestArrayFile testArrayFileIteration test ArrayFile.Reader methods next(); reader reader.seek() in range and out of range. TestArrayWritable testArrayWritableStringConstructor test ArrayWritable constructor with String[] as a parameter testNullArgument test TextArrayWritable with null parameter testArrayWritableToArray test TextArrayWritable toArray() method TestBloomMapFile testBloomMapFileConstructors test all BloomMapFile.Writer available constructors. testDeleteFile test method BloomMapFile.delete. testGetBloomMapFile test BloomMapFile.Reader method get(Writable wr) in range and out of range. testIOExceptionInWriterConstructor test BloomMapFile.Reader constructor with throw IOException in filesystem.getFileSystem(conf); TestBooleanWritable testCommonMethods test methods hashCode(), equals(), compareTo() against instance of type BooleanWritable TestBytesWritable testObjectCommonMethods test methods compareTo(), toString(), equals() against instance of type ByteWritable TestCompressedWritable testCompressedWritableWriteHeader test CompressedWritable write(DataOutputBuffer) method testCompressedWritableReadFields test CompressedWritable readFields() method TestEnumSetWritable testEnumSetWritableEquals test equals() method against instance of type EnumSetWritable testEnumSetWritableWriteRead test EnumSetWritable write(DataOutputBuffer out) and iteration by TestEnumSet through iterator(). TestMapFile testDeprecatedConstructors test all available constructor of type MapFile.Writer. testDescOrderWithThrowExceptionWriterAppend test MapFile.Writer method append(Writable wr) in desc order (2, 1); testFix test MapFile.fix() method which attempts to re-creating MapFile index. testGetClosestOnCurrentApi test method reader.getClosest(WritableComparable wrc) variations. testKeyLessWriterCreation test MapFile.Writer constructor without varargs paramereters (SequenceFile.Writer.Option... opts). testKeyValueClasses test on verification key and value classes for MapFile.Writer type. testMainMethodMapFile test for static void main() method. testMidKeyOnCurrentApi test MapFile.Reader method reader.midKey() which get key in the middle of the file. testOnFinalKey test MapFile.Reader method reader.finalKey() which get key in the end of file. testPathExplosionWriterCreation test IOException in MapFile.Writer constructor testReaderKeyIteration test MapFile.Reader method reader.next(key, value) for iteration. testReaderWithWrongKeyClass test MapFile.Reader method reader.getClosest() whith wrond class key testReaderWithWrongValueClass test MapFile.Writer method writer.append() with wrong type key instance testRename test MapFile.rename() method testRenameWithException test MapFile.rename() method with throw IOException testRenameWithFalse test MapFile.rename() method with FleSystem.rename return false testWriteWithFailDirCreation test MapFile.Writer constructor with throw IOException TestMultipleIOException testEmptyParamIOException test MultipleIOException.createIOException() method testSingleParamIOException test MultipleIOException.testSingleParamIOException() method testMultipleIOException test MultipleIOException.createIOException() method TestNullWritable testNullableWritable test uncovered methods in class NullWritable TestOutputBuffer testOutputBufferWithoutResize test OutputBuffer methods write(InputStream in, int), out.getData() testOutputBufferReset test just like previous only with adding out.reset() call TestSetFile testSetFileAccessMethods test SetFile.Reader next(), get() combination method TestText testBytesToCodePoint test static method Text.bytesToCodePoint(); testCharAt test Text class method charAt in range and out of range testReadWriteOperations test Text readFields()/write() methods combination testUtf8Length test Text.utf8Length() static method testbytesToCodePointWithInvalidUTF test static method with invalid utf value (throw BufferUnderflowException) TestTwoDArrayWritable test2DArrayConstructor test TwoDArrayWritable constructor with Text[][] parameter test2DArrayToArray test TwoDArrayWritable toArray() method test2DArrayWriteRead test TwoDArrayWritable methods combination testIllegalAccessException test IllegalAccessException in TwoDArrayWritable.readFields() method testInstantiationException test InstantiationException in TwoDArrayWritable.readFields() method TestVLongWritable testReadFields test VLongWritable.readFields(in) method testSetGetVLong test VLongWritable combination of methods set()/get() equals(), compareTo() TestWritableComparator testReadTypes test static methods readUnsignedShort()/readVInt()/readVLong with different parameters testShouldThrowsException test WritableComparator.compare with Exception testWritableComparator test WritableComparator.compare with >, <, = results
      Hide
      vbondarev Vadim Bondarev added a comment -

      test method description

      Show
      vbondarev Vadim Bondarev added a comment - test method description
      Hide
      vbondarev Vadim Bondarev added a comment -

      look at test method description in attach

      Show
      vbondarev Vadim Bondarev added a comment - look at test method description in attach
      Hide
      hadoopqa Hadoop QA added a comment -

      -1 overall. Here are the results of testing the latest attachment
      http://issues.apache.org/jira/secure/attachment/12564699/Test_Desc
      against trunk revision .

      -1 patch. The patch command could not apply the patch.

      Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2038//console

      This message is automatically generated.

      Show
      hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12564699/Test_Desc against trunk revision . -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2038//console This message is automatically generated.
      Hide
      hadoopqa Hadoop QA added a comment -

      -1 overall. Here are the results of testing the latest attachment
      http://issues.apache.org/jira/secure/attachment/12565287/HADOOP-9199-trunk-a.patch
      against trunk revision .

      +1 @author. The patch does not contain any @author tags.

      +1 tests included. The patch appears to include 16 new or modified test files.

      +1 javac. The applied patch does not increase the total number of javac compiler warnings.

      +1 javadoc. The javadoc tool did not generate any warning messages.

      +1 eclipse:eclipse. The patch built with eclipse:eclipse.

      +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

      -1 release audit. The applied patch generated 6 release audit warnings.

      +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.

      +1 contrib tests. The patch passed contrib unit tests.

      Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2063//testReport/
      Release audit warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/2063//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
      Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2063//console

      This message is automatically generated.

      Show
      hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12565287/HADOOP-9199-trunk-a.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 16 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. -1 release audit . The applied patch generated 6 release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2063//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/2063//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2063//console This message is automatically generated.
      Hide
      hadoopqa Hadoop QA added a comment -

      +1 overall. Here are the results of testing the latest attachment
      http://issues.apache.org/jira/secure/attachment/12565303/HADOOP-9199-trunk-b.patch
      against trunk revision .

      +1 @author. The patch does not contain any @author tags.

      +1 tests included. The patch appears to include 16 new or modified test files.

      +1 javac. The applied patch does not increase the total number of javac compiler warnings.

      +1 javadoc. The javadoc tool did not generate any warning messages.

      +1 eclipse:eclipse. The patch built with eclipse:eclipse.

      +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

      +1 release audit. The applied patch does not increase the total number of release audit warnings.

      +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.

      +1 contrib tests. The patch passed contrib unit tests.

      Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2064//testReport/
      Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2064//console

      This message is automatically generated.

      Show
      hadoopqa Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12565303/HADOOP-9199-trunk-b.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 16 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2064//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2064//console This message is automatically generated.
      Hide
      sureshms Suresh Srinivas added a comment -

      Sorry, I had lost track of this jira.

      add description in issue or in test source code ?

      Javadoc to the test method, to describe briefly what the test is testing.

      Show
      sureshms Suresh Srinivas added a comment - Sorry, I had lost track of this jira. add description in issue or in test source code ? Javadoc to the test method, to describe briefly what the test is testing.
      Hide
      hadoopqa Hadoop QA added a comment -

      +1 overall. Here are the results of testing the latest attachment
      http://issues.apache.org/jira/secure/attachment/12566265/HADOOP-9199-trunk-c.patch
      against trunk revision .

      +1 @author. The patch does not contain any @author tags.

      +1 tests included. The patch appears to include 16 new or modified test files.

      +1 javac. The applied patch does not increase the total number of javac compiler warnings.

      +1 javadoc. The javadoc tool did not generate any warning messages.

      +1 eclipse:eclipse. The patch built with eclipse:eclipse.

      +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

      +1 release audit. The applied patch does not increase the total number of release audit warnings.

      +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.

      +1 contrib tests. The patch passed contrib unit tests.

      Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2083//testReport/
      Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2083//console

      This message is automatically generated.

      Show
      hadoopqa Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12566265/HADOOP-9199-trunk-c.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 16 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2083//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2083//console This message is automatically generated.
      Hide
      hadoopqa Hadoop QA added a comment -

      -1 overall. Here are the results of testing the latest attachment
      http://issues.apache.org/jira/secure/attachment/12576561/HADOOP-9199-branch-0.23-e.patch
      against trunk revision .

      -1 patch. The patch command could not apply the patch.

      Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2396//console

      This message is automatically generated.

      Show
      hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12576561/HADOOP-9199-branch-0.23-e.patch against trunk revision . -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2396//console This message is automatically generated.
      Hide
      hadoopqa Hadoop QA added a comment -

      +1 overall. Here are the results of testing the latest attachment
      http://issues.apache.org/jira/secure/attachment/12576574/HADOOP-9199-trunk-e.patch
      against trunk revision .

      +1 @author. The patch does not contain any @author tags.

      +1 tests included. The patch appears to include 16 new or modified test files.

      +1 javac. The applied patch does not increase the total number of javac compiler warnings.

      +1 javadoc. The javadoc tool did not generate any warning messages.

      +1 eclipse:eclipse. The patch built with eclipse:eclipse.

      +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

      +1 release audit. The applied patch does not increase the total number of release audit warnings.

      +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.

      +1 contrib tests. The patch passed contrib unit tests.

      Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2398//testReport/
      Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2398//console

      This message is automatically generated.

      Show
      hadoopqa Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12576574/HADOOP-9199-trunk-e.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 16 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2398//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2398//console This message is automatically generated.
      Hide
      robsparker Robert Parker added a comment -

      Vadim Bondarev thanks for the patch, one small change:

      for the TestEnumWritable#testEnumSetWritableWriteRead:

      The readFields operation should go to a new EnumWritableSet so the source in not contaminated by the read. For example:

            EnumSetWritable<TestEnumSet> eset = 
                new EnumSetWritable<TestEnumSet>(EnumSet.of(TestEnumSet.APPEND, 
                       TestEnumSet.CREATE), TestEnumSet.class);
            EnumSetWritable<TestEnumSet> oset = new EnumSetWritable<TestEnumSet>();
            eset.write(out);
            in.reset(out.getData(), out.getLength());
            oset.readFields(in); 
      
            EnumSet<TestEnumSet> result = oset.get();
      
      Show
      robsparker Robert Parker added a comment - Vadim Bondarev thanks for the patch, one small change: for the TestEnumWritable#testEnumSetWritableWriteRead: The readFields operation should go to a new EnumWritableSet so the source in not contaminated by the read. For example: EnumSetWritable<TestEnumSet> eset = new EnumSetWritable<TestEnumSet>(EnumSet.of(TestEnumSet.APPEND, TestEnumSet.CREATE), TestEnumSet.class); EnumSetWritable<TestEnumSet> oset = new EnumSetWritable<TestEnumSet>(); eset.write(out); in.reset(out.getData(), out.getLength()); oset.readFields(in); EnumSet<TestEnumSet> result = oset.get();
      Hide
      aklochkov Andrey Klochkov added a comment -

      Updated the patch according to Robert's comment. The same patch is applicable to branch-2.

      Show
      aklochkov Andrey Klochkov added a comment - Updated the patch according to Robert's comment. The same patch is applicable to branch-2.
      Hide
      hadoopqa Hadoop QA added a comment -

      +1 overall. Here are the results of testing the latest attachment
      http://issues.apache.org/jira/secure/attachment/12606686/HADOOP-9199-trunk--n6.patch
      against trunk revision .

      +1 @author. The patch does not contain any @author tags.

      +1 tests included. The patch appears to include 16 new or modified test files.

      +1 javac. The applied patch does not increase the total number of javac compiler warnings.

      +1 javadoc. The javadoc tool did not generate any warning messages.

      +1 eclipse:eclipse. The patch built with eclipse:eclipse.

      +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

      +1 release audit. The applied patch does not increase the total number of release audit warnings.

      +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.

      +1 contrib tests. The patch passed contrib unit tests.

      Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/3166//testReport/
      Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3166//console

      This message is automatically generated.

      Show
      hadoopqa Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12606686/HADOOP-9199-trunk--n6.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 16 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/3166//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3166//console This message is automatically generated.
      Hide
      robsparker Robert Parker added a comment -

      Andrey Klochkov mvn test -Dtest=TestMapFile; mvn test -Dtest=TestMapFile shows the that TestMapFile is not quite cleaning up. Additionally the '/' is missing between the "test.build.data" dir and the test file name.

      Running org.apache.hadoop.io.TestMapFile
      Tests run: 20, Failures: 3, Errors: 0, Skipped: 0, Time elapsed: 4.362 sec <<< FAILURE! - in org.apache.hadoop.io.TestMapFile
      testRenameWithFalse(org.apache.hadoop.io.TestMapFile)  Time elapsed: 2.37 sec  <<< FAILURE!
      junit.framework.AssertionFailedError: testRenameWithFalse invalid IOExceptionMessage error !!!
      	at junit.framework.Assert.fail(Assert.java:50)
      	at junit.framework.Assert.assertTrue(Assert.java:20)
      	at org.apache.hadoop.io.TestMapFile.testRenameWithFalse(TestMapFile.java:255)
      
      testRename(org.apache.hadoop.io.TestMapFile)  Time elapsed: 0.04 sec  <<< FAILURE!
      junit.framework.AssertionFailedError: testRename error java.io.IOException: Target /home/rparker/Y/hadoop-gitdev/hadoop-common-project/hadoop-common/target/test/datatest-new.mapfile/datatest-old.mapfile is a directory
      	at junit.framework.Assert.fail(Assert.java:50)
      	at org.apache.hadoop.io.TestMapFile.testRename(TestMapFile.java:199)
      
      testRenameWithException(org.apache.hadoop.io.TestMapFile)  Time elapsed: 0.037 sec  <<< FAILURE!
      junit.framework.ComparisonFailure: testRenameWithException invalid IOExceptionMessage !!! expected:<[Target /home/rparker/Y/hadoop-gitdev/hadoop-common-project/hadoop-common/target/test/datatest-new.mapfile/datatest-old.mapfile is a directory]> but was:<[Can't rename file]>
      	at junit.framework.Assert.assertEquals(Assert.java:85)
      	at org.apache.hadoop.io.TestMapFile.testRenameWithException(TestMapFile.java:229)
      
      
      Results :
      
      Failed tests: 
        TestMapFile.testRenameWithFalse:255 testRenameWithFalse invalid IOExceptionMessage error !!!
        TestMapFile.testRename:199 testRename error java.io.IOException: Target /home/rparker/Y/hadoop-gitdev/hadoop-common-project/hadoop-common/target/test/datatest-new.mapfile/datatest-old.mapfile is a directory
        TestMapFile.testRenameWithException:229 testRenameWithException invalid IOExceptionMessage !!! expected:<[Target /home/rparker/Y/hadoop-gitdev/hadoop-common-project/hadoop-common/target/test/datatest-new.mapfile/datatest-old.mapfile is a directory]> but was:<[Can't rename file]>
      
      Tests run: 20, Failures: 3, Errors: 0, Skipped: 0
      

      The '/' is missing in several other tests (TestArrayFile,TestBloomMapFile),. I used to notice the difference between TestSetFile (which is correct) and TestMapFile

      grep  test.build.data hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestArrayFile.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestArrayWritable.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestBloomMapFile.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestBooleanWritable.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestBytesWritable.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestEnumSetWritable.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestMapFile.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestSetFile.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestText.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestCompressedWritable.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestMultipleIOException.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestNullWritable.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestOutputBuffer.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestTwoDArrayWritable.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestVLongWritable.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestWritableComparator.java
      

      Thanks for correcting the >80 lines and please remove the tabs. Sorry I missed these items on the first review.

      Show
      robsparker Robert Parker added a comment - Andrey Klochkov mvn test -Dtest=TestMapFile; mvn test -Dtest=TestMapFile shows the that TestMapFile is not quite cleaning up. Additionally the '/' is missing between the "test.build.data" dir and the test file name. Running org.apache.hadoop.io.TestMapFile Tests run: 20, Failures: 3, Errors: 0, Skipped: 0, Time elapsed: 4.362 sec <<< FAILURE! - in org.apache.hadoop.io.TestMapFile testRenameWithFalse(org.apache.hadoop.io.TestMapFile) Time elapsed: 2.37 sec <<< FAILURE! junit.framework.AssertionFailedError: testRenameWithFalse invalid IOExceptionMessage error !!! at junit.framework.Assert.fail(Assert.java:50) at junit.framework.Assert.assertTrue(Assert.java:20) at org.apache.hadoop.io.TestMapFile.testRenameWithFalse(TestMapFile.java:255) testRename(org.apache.hadoop.io.TestMapFile) Time elapsed: 0.04 sec <<< FAILURE! junit.framework.AssertionFailedError: testRename error java.io.IOException: Target /home/rparker/Y/hadoop-gitdev/hadoop-common-project/hadoop-common/target/test/datatest- new .mapfile/datatest-old.mapfile is a directory at junit.framework.Assert.fail(Assert.java:50) at org.apache.hadoop.io.TestMapFile.testRename(TestMapFile.java:199) testRenameWithException(org.apache.hadoop.io.TestMapFile) Time elapsed: 0.037 sec <<< FAILURE! junit.framework.ComparisonFailure: testRenameWithException invalid IOExceptionMessage !!! expected:<[Target /home/rparker/Y/hadoop-gitdev/hadoop-common-project/hadoop-common/target/test/datatest- new .mapfile/datatest-old.mapfile is a directory]> but was:<[Can't rename file]> at junit.framework.Assert.assertEquals(Assert.java:85) at org.apache.hadoop.io.TestMapFile.testRenameWithException(TestMapFile.java:229) Results : Failed tests: TestMapFile.testRenameWithFalse:255 testRenameWithFalse invalid IOExceptionMessage error !!! TestMapFile.testRename:199 testRename error java.io.IOException: Target /home/rparker/Y/hadoop-gitdev/hadoop-common-project/hadoop-common/target/test/datatest- new .mapfile/datatest-old.mapfile is a directory TestMapFile.testRenameWithException:229 testRenameWithException invalid IOExceptionMessage !!! expected:<[Target /home/rparker/Y/hadoop-gitdev/hadoop-common-project/hadoop-common/target/test/datatest- new .mapfile/datatest-old.mapfile is a directory]> but was:<[Can't rename file]> Tests run: 20, Failures: 3, Errors: 0, Skipped: 0 The '/' is missing in several other tests (TestArrayFile,TestBloomMapFile),. I used to notice the difference between TestSetFile (which is correct) and TestMapFile grep test.build.data hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestArrayFile.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestArrayWritable.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestBloomMapFile.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestBooleanWritable.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestBytesWritable.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestEnumSetWritable.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestMapFile.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestSetFile.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestText.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestCompressedWritable.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestMultipleIOException.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestNullWritable.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestOutputBuffer.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestTwoDArrayWritable.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestVLongWritable.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestWritableComparator.java Thanks for correcting the >80 lines and please remove the tabs. Sorry I missed these items on the first review.
      Hide
      aklochkov Andrey Klochkov added a comment -

      Robert, thanks for capturing all these! Uploading the patch with fixes.

      Show
      aklochkov Andrey Klochkov added a comment - Robert, thanks for capturing all these! Uploading the patch with fixes.
      Hide
      hadoopqa Hadoop QA added a comment -

      +1 overall. Here are the results of testing the latest attachment
      http://issues.apache.org/jira/secure/attachment/12606853/HADOOP-9199-trunk--n7.patch
      against trunk revision .

      +1 @author. The patch does not contain any @author tags.

      +1 tests included. The patch appears to include 16 new or modified test files.

      +1 javac. The applied patch does not increase the total number of javac compiler warnings.

      +1 javadoc. The javadoc tool did not generate any warning messages.

      +1 eclipse:eclipse. The patch built with eclipse:eclipse.

      +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

      +1 release audit. The applied patch does not increase the total number of release audit warnings.

      +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.

      +1 contrib tests. The patch passed contrib unit tests.

      Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/3171//testReport/
      Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3171//console

      This message is automatically generated.

      Show
      hadoopqa Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12606853/HADOOP-9199-trunk--n7.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 16 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/3171//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3171//console This message is automatically generated.
      Hide
      robsparker Robert Parker added a comment -

      Thanks Andrey.
      +1 (non-binding)
      lgtm

      Show
      robsparker Robert Parker added a comment - Thanks Andrey . +1 (non-binding) lgtm
      Hide
      jeagles Jonathan Eagles added a comment -

      putting this into 2.3 and 3.0

      Show
      jeagles Jonathan Eagles added a comment - putting this into 2.3 and 3.0
      Hide
      hudson Hudson added a comment -

      SUCCESS: Integrated in Hadoop-trunk-Commit #4566 (See https://builds.apache.org/job/Hadoop-trunk-Commit/4566/)
      HADOOP-9199. Cover package org.apache.hadoop.io with unit tests (Andrey Klochkov via jeagles) (jeagles: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1530404)

      • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
      • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestArrayFile.java
      • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestArrayWritable.java
      • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestBloomMapFile.java
      • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestBooleanWritable.java
      • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestBytesWritable.java
      • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestEnumSetWritable.java
      • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestMapFile.java
      • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestSetFile.java
      • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestText.java
      Show
      hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #4566 (See https://builds.apache.org/job/Hadoop-trunk-Commit/4566/ ) HADOOP-9199 . Cover package org.apache.hadoop.io with unit tests (Andrey Klochkov via jeagles) (jeagles: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1530404 ) /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestArrayFile.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestArrayWritable.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestBloomMapFile.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestBooleanWritable.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestBytesWritable.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestEnumSetWritable.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestMapFile.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestSetFile.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestText.java
      Hide
      hudson Hudson added a comment -

      SUCCESS: Integrated in Hadoop-Yarn-trunk #357 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/357/)
      HADOOP-9199. Cover package org.apache.hadoop.io with unit tests (Andrey Klochkov via jeagles) (jeagles: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1530404)

      • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
      • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestArrayFile.java
      • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestArrayWritable.java
      • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestBloomMapFile.java
      • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestBooleanWritable.java
      • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestBytesWritable.java
      • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestEnumSetWritable.java
      • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestMapFile.java
      • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestSetFile.java
      • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestText.java
      Show
      hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #357 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/357/ ) HADOOP-9199 . Cover package org.apache.hadoop.io with unit tests (Andrey Klochkov via jeagles) (jeagles: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1530404 ) /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestArrayFile.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestArrayWritable.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestBloomMapFile.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestBooleanWritable.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestBytesWritable.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestEnumSetWritable.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestMapFile.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestSetFile.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestText.java
      Hide
      hudson Hudson added a comment -

      FAILURE: Integrated in Hadoop-Mapreduce-trunk #1573 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1573/)
      HADOOP-9199. Cover package org.apache.hadoop.io with unit tests (Andrey Klochkov via jeagles) (jeagles: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1530404)

      • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
      • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestArrayFile.java
      • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestArrayWritable.java
      • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestBloomMapFile.java
      • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestBooleanWritable.java
      • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestBytesWritable.java
      • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestEnumSetWritable.java
      • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestMapFile.java
      • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestSetFile.java
      • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestText.java
      Show
      hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #1573 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1573/ ) HADOOP-9199 . Cover package org.apache.hadoop.io with unit tests (Andrey Klochkov via jeagles) (jeagles: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1530404 ) /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestArrayFile.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestArrayWritable.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestBloomMapFile.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestBooleanWritable.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestBytesWritable.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestEnumSetWritable.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestMapFile.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestSetFile.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestText.java
      Hide
      hudson Hudson added a comment -

      SUCCESS: Integrated in Hadoop-Hdfs-trunk #1547 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1547/)
      HADOOP-9199. Cover package org.apache.hadoop.io with unit tests (Andrey Klochkov via jeagles) (jeagles: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1530404)

      • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
      • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestArrayFile.java
      • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestArrayWritable.java
      • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestBloomMapFile.java
      • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestBooleanWritable.java
      • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestBytesWritable.java
      • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestEnumSetWritable.java
      • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestMapFile.java
      • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestSetFile.java
      • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestText.java
      Show
      hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk #1547 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1547/ ) HADOOP-9199 . Cover package org.apache.hadoop.io with unit tests (Andrey Klochkov via jeagles) (jeagles: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1530404 ) /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestArrayFile.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestArrayWritable.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestBloomMapFile.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestBooleanWritable.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestBytesWritable.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestEnumSetWritable.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestMapFile.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestSetFile.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestText.java

        People

        • Assignee:
          aklochkov Andrey Klochkov
          Reporter:
          vbondarev Vadim Bondarev
        • Votes:
          0 Vote for this issue
          Watchers:
          8 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development