Hadoop Common
  1. Hadoop Common
  2. HADOOP-9191

TestAccessControlList and TestJobHistoryConfig fail with JDK7

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.2.0, 1-win
    • Fix Version/s: 1.2.0
    • Component/s: test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Individual test cases have dependencies on a specific order of execution and fail when the order is changed.

      TestAccessControlList.testNetGroups relies on Groups being initialized with a hard-coded test class that subsequent test cases depend on.

      TestJobHistoryConfig.testJobHistoryLogging fails to shutdown the MiniDFSCluster on exit.

      1. HADOOP-9191.patch
        8 kB
        Arpit Agarwal
      2. HADOOP-9191-branch-1.001.patch
        6 kB
        Arpit Agarwal
      3. HADOOP-9191-branch-1-win.001.patch
        5 kB
        Arpit Agarwal

        Activity

        Hide
        Arpit Agarwal added a comment -

        Fixes:
        1. Shutdown MiniDFSCluster in TestJobHistory.
        2. use setUp routine to initialize test dependencies in TestAccessContrlList.

        Show
        Arpit Agarwal added a comment - Fixes: 1. Shutdown MiniDFSCluster in TestJobHistory. 2. use setUp routine to initialize test dependencies in TestAccessContrlList.
        Hide
        Suresh Srinivas added a comment -

        Arpit, this patch does not apply branch-1. Also there are many empty line changes, that are not necessary. See:

             assertEquals(groups.iterator().next(), "tardis");
        -    
        +
             acl = new AccessControlList("drwho");
        
        Show
        Suresh Srinivas added a comment - Arpit, this patch does not apply branch-1. Also there are many empty line changes, that are not necessary. See: assertEquals(groups.iterator().next(), "tardis" ); - + acl = new AccessControlList( "drwho" );
        Hide
        Arpit Agarwal added a comment -

        Thanks Suresh. I fixed the whitespace issue and attached separate patches for branch-1 and branch-1-win.

        Show
        Arpit Agarwal added a comment - Thanks Suresh. I fixed the whitespace issue and attached separate patches for branch-1 and branch-1-win.
        Hide
        Suresh Srinivas added a comment -

        Thanks for addressing the comments. +1 for the patch.

        Show
        Suresh Srinivas added a comment - Thanks for addressing the comments. +1 for the patch.
        Hide
        Suresh Srinivas added a comment -

        I committed the patch to both branch-1 and branch-1-win.

        Show
        Suresh Srinivas added a comment - I committed the patch to both branch-1 and branch-1-win.
        Hide
        Matt Foley added a comment -

        Closed upon release of Hadoop 1.2.0.

        Show
        Matt Foley added a comment - Closed upon release of Hadoop 1.2.0.

          People

          • Assignee:
            Arpit Agarwal
            Reporter:
            Arpit Agarwal
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development