Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-9186

test-patch.sh should report build failure to JIRA

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.2-alpha
    • Fix Version/s: 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Target Version/s:

      Description

      When I submit a patch to JIRA, jenkins haven't give any response, after checking jenkins page, I found it is because of build failure, the reason is in:
      http://mail-archives.apache.org/mod_mbox/hadoop-common-dev/201301.mbox/%3CCADY20s6Z7iEp10=zgbOXQ60fu8TP1zxHjw3FMS=Lk3ZVhVmsEA@mail.gmail.com%3E
      This affects HADOOP-9155 and HADOOP-9164.
      I checked test-patch.sh, it seams it exit directly if compile failed, without reporting it JIRA. I think this should be fixed.

      1. HADOOP-9186.patch
        2 kB
        Binglin Chang
      2. HADOOP-9186.v2.patch
        2 kB
        Binglin Chang

        Activity

        Hide
        decster Binglin Chang added a comment -

        Initial patch, changes:

        1. rename function buildWithPatch to prebuildWithoutPatch, cause this function actually doesn't "build with patch"
        2. if build failed, add jira comment and return 1, rather than exit directly
        3. after calling prebuildWithoutPatch, check status an report failure if result != 0
        Show
        decster Binglin Chang added a comment - Initial patch, changes: rename function buildWithPatch to prebuildWithoutPatch, cause this function actually doesn't "build with patch" if build failed, add jira comment and return 1, rather than exit directly after calling prebuildWithoutPatch, check status an report failure if result != 0
        Hide
        hadoopqa Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12563687/HADOOP-9186.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2005//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2005//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12563687/HADOOP-9186.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in . +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2005//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2005//console This message is automatically generated.
        Hide
        cmccabe Colin P. McCabe added a comment -

        Looks reasonable.

        +    {color:red}-1 patch{color}.  Top-level trunk compilation maybe broken."
        

        Should be "may be broken"

        Show
        cmccabe Colin P. McCabe added a comment - Looks reasonable. + {color:red}-1 patch{color}. Top-level trunk compilation maybe broken." Should be "may be broken"
        Hide
        decster Binglin Chang added a comment -

        Thanks for the review. Here is the updated version.

        Show
        decster Binglin Chang added a comment - Thanks for the review. Here is the updated version.
        Hide
        hadoopqa Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12563857/HADOOP-9186.v2.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2015//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2015//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12563857/HADOOP-9186.v2.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in . +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2015//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2015//console This message is automatically generated.
        Hide
        decster Binglin Chang added a comment -

        @Colin or @Luke, this patch has waited a long time, if there is no more comments, could this jira get committed? Thanks!

        Show
        decster Binglin Chang added a comment - @Colin or @Luke, this patch has waited a long time, if there is no more comments, could this jira get committed? Thanks!
        Hide
        cmccabe Colin P. McCabe added a comment -

        +1.

        Show
        cmccabe Colin P. McCabe added a comment - +1.
        Hide
        cmccabe Colin P. McCabe added a comment -

        I did a trial run with test-patch.sh and nothing blew up. I'm going to go for it. thanks, Binglin.

        Show
        cmccabe Colin P. McCabe added a comment - I did a trial run with test-patch.sh and nothing blew up. I'm going to go for it. thanks, Binglin.
        Hide
        hudson Hudson added a comment -

        Integrated in Hadoop-trunk-Commit #4070 (See https://builds.apache.org/job/Hadoop-trunk-Commit/4070/)
        update CHANGES.txt to reflect the fact that HADOOP-9186 is only in trunk at the moment (Revision 1502326)
        HADOOP-9186. test-patch.sh should report build failure to JIRA. (Binglin Chang via Colin Patrick McCabe) (Revision 1502325)

        Result = SUCCESS
        cmccabe : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1502326
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt

        cmccabe : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1502325
        Files :

        • /hadoop/common/trunk/dev-support/test-patch.sh
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - Integrated in Hadoop-trunk-Commit #4070 (See https://builds.apache.org/job/Hadoop-trunk-Commit/4070/ ) update CHANGES.txt to reflect the fact that HADOOP-9186 is only in trunk at the moment (Revision 1502326) HADOOP-9186 . test-patch.sh should report build failure to JIRA. (Binglin Chang via Colin Patrick McCabe) (Revision 1502325) Result = SUCCESS cmccabe : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1502326 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt cmccabe : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1502325 Files : /hadoop/common/trunk/dev-support/test-patch.sh /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk #268 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/268/)
        update CHANGES.txt to reflect the fact that HADOOP-9186 is only in trunk at the moment (cmccabe: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1502326)

        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #268 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/268/ ) update CHANGES.txt to reflect the fact that HADOOP-9186 is only in trunk at the moment (cmccabe: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1502326 ) /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt HADOOP-9186 . test-patch.sh should report build failure to JIRA. (Binglin Chang via Colin Patrick McCabe) (cmccabe: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1502325 ) /hadoop/common/trunk/dev-support/test-patch.sh /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #1458 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1458/)
        update CHANGES.txt to reflect the fact that HADOOP-9186 is only in trunk at the moment (cmccabe: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1502326)

        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #1458 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1458/ ) update CHANGES.txt to reflect the fact that HADOOP-9186 is only in trunk at the moment (cmccabe: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1502326 ) /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt HADOOP-9186 . test-patch.sh should report build failure to JIRA. (Binglin Chang via Colin Patrick McCabe) (cmccabe: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1502325 ) /hadoop/common/trunk/dev-support/test-patch.sh /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Mapreduce-trunk #1485 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1485/)
        update CHANGES.txt to reflect the fact that HADOOP-9186 is only in trunk at the moment (cmccabe: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1502326)

        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk #1485 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1485/ ) update CHANGES.txt to reflect the fact that HADOOP-9186 is only in trunk at the moment (cmccabe: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1502326 ) /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt HADOOP-9186 . test-patch.sh should report build failure to JIRA. (Binglin Chang via Colin Patrick McCabe) (cmccabe: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1502325 ) /hadoop/common/trunk/dev-support/test-patch.sh /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt

          People

          • Assignee:
            decster Binglin Chang
            Reporter:
            decster Binglin Chang
          • Votes:
            0 Vote for this issue
            Watchers:
            8 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development