To clarify, this patch fixes these 2 FindBugs warnings:
Comparison of String parameter using == or != in org.apache.hadoop.fs.Path.normalizePath(String, String)
Bug type ES_COMPARING_PARAMETER_STRING_WITH_EQ (click for details)
In class org.apache.hadoop.fs.Path
In method org.apache.hadoop.fs.Path.normalizePath(String, String)
Actual type String
At Path.java:[line 202]
org.apache.hadoop.fs.FileUtil.setPermission(File, FsPermission) ignores exceptional return value of java.io.File.setWritable(boolean, boolean)
Bug type RV_RETURN_VALUE_IGNORED_BAD_PRACTICE (click for details)
In class org.apache.hadoop.fs.FileUtil
In method org.apache.hadoop.fs.FileUtil.setPermission(File, FsPermission)
Called method java.io.File.setWritable(boolean, boolean)
At FileUtil.java:[line 705]
https://builds.apache.org/job/PreCommit-HADOOP-Build/1871//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-common.html
For the string comparisons in Path, we can replace == with String#equals.
For FileUtil#setPermission, we need to make sure that all paths through the code use checkReturnValue after each API call to change permissions.