Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-9139

improve script hadoop-common-project/hadoop-common/src/test/resources/kdc/killKdc.sh

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-alpha1
    • Fix Version/s: 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None

      Description

      Script hadoop-common-project/hadoop-common/src/test/resources/kdc/killKdc.sh is used in "internal" Kerberos tests to kill started apacheds server.
      There are 2 problems in the script:
      1) it invokes "kill" even if there are no running apacheds servers;
      2) it does not work correctly on all Linux platforms since "cut -f4 -d ' '" command relies upon the exact number of spaces in the ps potput, but this number can be different.

      1. HADOOP-9139.patch
        0.5 kB
        Ivan A. Veselovsky
      2. HADOOP-9139--b.patch
        0.5 kB
        Ivan A. Veselovsky

        Activity

        Hide
        hudson Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #1311 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1311/)
        HADOOP-9139 improve killKdc.sh (Ivan A. Veselovsky via bobby) (Revision 1432151)

        Result = FAILURE
        bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1432151
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/resources/kdc/killKdc.sh
        Show
        hudson Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1311 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1311/ ) HADOOP-9139 improve killKdc.sh (Ivan A. Veselovsky via bobby) (Revision 1432151) Result = FAILURE bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1432151 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/resources/kdc/killKdc.sh
        Hide
        hudson Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #1283 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1283/)
        HADOOP-9139 improve killKdc.sh (Ivan A. Veselovsky via bobby) (Revision 1432151)

        Result = FAILURE
        bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1432151
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/resources/kdc/killKdc.sh
        Show
        hudson Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1283 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1283/ ) HADOOP-9139 improve killKdc.sh (Ivan A. Veselovsky via bobby) (Revision 1432151) Result = FAILURE bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1432151 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/resources/kdc/killKdc.sh
        Hide
        hudson Hudson added a comment -

        Integrated in Hadoop-Yarn-trunk #94 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/94/)
        HADOOP-9139 improve killKdc.sh (Ivan A. Veselovsky via bobby) (Revision 1432151)

        Result = SUCCESS
        bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1432151
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/resources/kdc/killKdc.sh
        Show
        hudson Hudson added a comment - Integrated in Hadoop-Yarn-trunk #94 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/94/ ) HADOOP-9139 improve killKdc.sh (Ivan A. Veselovsky via bobby) (Revision 1432151) Result = SUCCESS bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1432151 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/resources/kdc/killKdc.sh
        Hide
        hudson Hudson added a comment -

        Integrated in Hadoop-trunk-Commit #3217 (See https://builds.apache.org/job/Hadoop-trunk-Commit/3217/)
        HADOOP-9139 improve killKdc.sh (Ivan A. Veselovsky via bobby) (Revision 1432151)

        Result = SUCCESS
        bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1432151
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/resources/kdc/killKdc.sh
        Show
        hudson Hudson added a comment - Integrated in Hadoop-trunk-Commit #3217 (See https://builds.apache.org/job/Hadoop-trunk-Commit/3217/ ) HADOOP-9139 improve killKdc.sh (Ivan A. Veselovsky via bobby) (Revision 1432151) Result = SUCCESS bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1432151 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/resources/kdc/killKdc.sh
        Hide
        revans2 Robert Joseph Evans added a comment -

        Thanks Ivan for the patch. I put this into trunk.

        Show
        revans2 Robert Joseph Evans added a comment - Thanks Ivan for the patch. I put this into trunk.
        Hide
        revans2 Robert Joseph Evans added a comment -

        The change looks fine to me. +1 I'll check it in.

        Show
        revans2 Robert Joseph Evans added a comment - The change looks fine to me. +1 I'll check it in.
        Hide
        hadoopqa Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12560952/HADOOP-9139--b.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1873//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1873//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12560952/HADOOP-9139--b.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1873//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1873//console This message is automatically generated.
        Hide
        iveselovsky Ivan A. Veselovsky added a comment -

        Hi, Thomas,
        the test org.apache.hadoop.ha.TestZKFailoverController seems to be falky, it fails from time to time.
        I suppose, in pre-commit verification jobs the killKdc.sh skript affected by the patch is not even ever invoked because the profile -PstartKdc is not specified.
        So, I suppose this failure is not anyhow related to the patch.

        Show
        iveselovsky Ivan A. Veselovsky added a comment - Hi, Thomas, the test org.apache.hadoop.ha.TestZKFailoverController seems to be falky, it fails from time to time. I suppose, in pre-commit verification jobs the killKdc.sh skript affected by the patch is not even ever invoked because the profile -PstartKdc is not specified. So, I suppose this failure is not anyhow related to the patch.
        Hide
        tgraves Thomas Graves added a comment -

        Can you look at the test failure please?

        Show
        tgraves Thomas Graves added a comment - Can you look at the test failure please?
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12560952/HADOOP-9139--b.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common:

        org.apache.hadoop.ha.TestZKFailoverController

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1872//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1872//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12560952/HADOOP-9139--b.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-common-project/hadoop-common: org.apache.hadoop.ha.TestZKFailoverController +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1872//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1872//console This message is automatically generated.
        Hide
        iveselovsky Ivan A. Veselovsky added a comment -

        the "HADOOP-9139--b.patch" version of the patch adds "-t" option to xargs command, so that it prints the command to be executed.

        Show
        iveselovsky Ivan A. Veselovsky added a comment - the " HADOOP-9139 --b.patch" version of the patch adds "-t" option to xargs command, so that it prints the command to be executed.
        Hide
        hadoopqa Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12560826/HADOOP-9139.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1864//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1864//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12560826/HADOOP-9139.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1864//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1864//console This message is automatically generated.

          People

          • Assignee:
            iveselovsky Ivan A. Veselovsky
            Reporter:
            iveselovsky Ivan A. Veselovsky
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development