[HADOOP-9110] winutils ls off-by-one error indexing MONTHS array can cause access violation

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1-win, trunk-win
• Fix Version/s: 1-win, trunk-win
• Component/s: util
• Target Version/s: 1-win, trunk-win
• Hadoop Flags: Reviewed
• Assignee: Chris Nauroth
• Reporter: Chris Nauroth
• Created: 01/Dec/12 03:38
• Updated: 02/Dec/12 03:05
• Resolved: 02/Dec/12 03:05

Description

In ls.c, the LsPrintLine function uses the wMonth field of a SYSTEMTIME struct to index into MONTHS, an array of 12 elements containing string representations of the months. The wMonth field is 1-based (1=January), but indexing into an array is zero-based. This gives the wrong month, and since we just crossed into month 12, it also has started causing an access violation.

Issue Links

• is part of: HADOOP-8562 Enhancements to support Hadoop on Windows Server and Windows Azure environments