Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 1.1.1
    • Fix Version/s: 1.2.0
    • Component/s: build
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      There are missing license headers in some source files (e.g. TestUnderReplicatedBlocks.java is one) according to the RAT report.

      1. HADOOP-9098.patch
        88 kB
        Arpit Agarwal
      2. missing-headers.txt
        46 kB
        Suresh Srinivas

        Activity

        Hide
        Matt Foley added a comment -

        Closed upon release of Hadoop 1.2.0.

        Show
        Matt Foley added a comment - Closed upon release of Hadoop 1.2.0.
        Hide
        Arpit Agarwal added a comment -

        I did not examine each of the ~380 remaining files that release-audit is flagging as unlicensed but I believe most of them are either:
        1. Auto-generated.
        2. Test output files.
        3. Files that have a non-Apache licence e.g. sorttable.js

        Show
        Arpit Agarwal added a comment - I did not examine each of the ~380 remaining files that release-audit is flagging as unlicensed but I believe most of them are either: 1. Auto-generated. 2. Test output files. 3. Files that have a non-Apache licence e.g. sorttable.js
        Hide
        Suresh Srinivas added a comment -

        I committed the patch to trunk-1.

        Thank you Arpit!

        Show
        Suresh Srinivas added a comment - I committed the patch to trunk-1. Thank you Arpit!
        Hide
        Tom White added a comment -

        +1. Thanks, Arpit.

        Show
        Tom White added a comment - +1. Thanks, Arpit.
        Hide
        Suresh Srinivas added a comment -

        Attaching a file that lists files that are flagged as missing license headers.

        Before the patch:

        releaseaudit:
             [java] 
             [java] *****************************************************
             [java] Summary
             [java] -------
             [java] Notes: 33
             [java] Binaries: 200
             [java] Archives: 116
             [java] Standards: 5791
             [java] 
             [java] Apache Licensed: 2838
             [java] Generated Documents: 2460
             [java] 
             [java] JavaDocs are generated and so license header is optional
             [java] Generated files do not required license headers
             [java] 
             [java] 493 Unknown Licenses
        

        With the patch:

        releaseaudit:
             [java] 
             [java] *****************************************************
             [java] Summary
             [java] -------
             [java] Notes: 33
             [java] Binaries: 200
             [java] Archives: 116
             [java] Standards: 5791
             [java] 
             [java] Apache Licensed: 2959
             [java] Generated Documents: 2460
             [java] 
             [java] JavaDocs are generated and so license header is optional
             [java] Generated files do not required license headers
             [java] 
             [java] 372 Unknown Licenses
        

        +1 for the patch. It reduces the number of warnings. I am going to commit this in a day or two.

        I do not think it is worth the effort fixing the rest of the files to get the warning down to zero.

        Show
        Suresh Srinivas added a comment - Attaching a file that lists files that are flagged as missing license headers. Before the patch: releaseaudit: [java] [java] ***************************************************** [java] Summary [java] ------- [java] Notes: 33 [java] Binaries: 200 [java] Archives: 116 [java] Standards: 5791 [java] [java] Apache Licensed: 2838 [java] Generated Documents: 2460 [java] [java] JavaDocs are generated and so license header is optional [java] Generated files do not required license headers [java] [java] 493 Unknown Licenses With the patch: releaseaudit: [java] [java] ***************************************************** [java] Summary [java] ------- [java] Notes: 33 [java] Binaries: 200 [java] Archives: 116 [java] Standards: 5791 [java] [java] Apache Licensed: 2959 [java] Generated Documents: 2460 [java] [java] JavaDocs are generated and so license header is optional [java] Generated files do not required license headers [java] [java] 372 Unknown Licenses +1 for the patch. It reduces the number of warnings. I am going to commit this in a day or two. I do not think it is worth the effort fixing the rest of the files to get the warning down to zero.
        Hide
        Suresh Srinivas added a comment -

        Patch looks good to me. Tom, do you want take a quick look or run a RAT report with this patch?

        Show
        Suresh Srinivas added a comment - Patch looks good to me. Tom, do you want take a quick look or run a RAT report with this patch?
        Hide
        Arpit Agarwal added a comment -

        Submitted a patch that adds missing licenses to Java, HTML, jsp, jr, xsl and a few config files. I tried to maintain the same format as trunk.

        Show
        Arpit Agarwal added a comment - Submitted a patch that adds missing licenses to Java, HTML, jsp, jr, xsl and a few config files. I tried to maintain the same format as trunk.

          People

          • Assignee:
            Arpit Agarwal
            Reporter:
            Tom White
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development