Hadoop Common
  1. Hadoop Common
  2. HADOOP-9097

Maven RAT plugin is not checking all source files

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 2.0.3-alpha, 0.23.5
    • Fix Version/s: 3.0.0, 2.0.3-alpha, 0.23.6
    • Component/s: build
    • Labels:
      None

      Description

      Running 'mvn apache-rat:check' passes, but running RAT by hand (by downloading the JAR) produces some warnings for Java files, amongst others.

      1. HADOOP-9097-remove-entire.sh
        0.5 kB
        Thomas Graves
      2. HADOOP-9097-remove-branch23.sh
        0.4 kB
        Thomas Graves
      3. HADOOP-9097-remove-branch2.sh
        0.4 kB
        Thomas Graves
      4. HADOOP-9097-entire.patch
        80 kB
        Thomas Graves
      5. HADOOP-9097-entire.patch
        82 kB
        Thomas Graves
      6. HADOOP-9097-branch-0.23-entire.patch
        68 kB
        Thomas Graves
      7. HADOOP-9097-branch-0.23-entire.patch
        70 kB
        Thomas Graves
      8. HADOOP-9097-branch-0.23.patch
        18 kB
        Thomas Graves
      9. HADOOP-9097-branch-0.23.patch
        18 kB
        Thomas Graves
      10. HADOOP-9097.patch
        23 kB
        Thomas Graves
      11. HADOOP-9097.patch
        23 kB
        Thomas Graves

        Issue Links

          Activity

          Hide
          Thomas Graves added a comment -

          Todd, I filed HDFS-4399 to handle. I would be greatful for a review if you have time.

          Show
          Thomas Graves added a comment - Todd, I filed HDFS-4399 to handle. I would be greatful for a review if you have time.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #1314 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1314/)
          HADOOP-9097. Maven RAT plugin is not checking all source files (tgraves) (Revision 1432934)

          Result = FAILURE
          tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1432934
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/pom.xml
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/config.h.cmake
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/resources/META-INF/services/org.apache.hadoop.security.SecurityInfo
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestDelegationTokenRenewer.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/resources/META-INF/services/org.apache.hadoop.security.token.TokenIdentifier
          • /hadoop/common/trunk/hadoop-common-project/pom.xml
          • /hadoop/common/trunk/hadoop-dist/pom.xml
          • /hadoop/common/trunk/hadoop-tools/hadoop-distcp/src/main/resources/distcp-default.xml
          • /hadoop/common/trunk/hadoop-tools/hadoop-distcp/src/site/xdoc/appendix.xml
          • /hadoop/common/trunk/hadoop-tools/hadoop-distcp/src/site/xdoc/architecture.xml
          • /hadoop/common/trunk/hadoop-tools/hadoop-distcp/src/site/xdoc/cli.xml
          • /hadoop/common/trunk/hadoop-tools/hadoop-distcp/src/site/xdoc/index.xml
          • /hadoop/common/trunk/hadoop-tools/hadoop-distcp/src/site/xdoc/usage.xml
          • /hadoop/common/trunk/hadoop-tools/hadoop-distcp/src/test/resources/sslConfig.xml
          • /hadoop/common/trunk/hadoop-tools/hadoop-pipes/src/main/native/examples/conf/word-part.xml
          • /hadoop/common/trunk/hadoop-tools/hadoop-pipes/src/main/native/examples/conf/word.xml
          • /hadoop/common/trunk/hadoop-tools/hadoop-pipes/src/main/native/pipes/debug/pipes-default-gdb-commands.txt
          • /hadoop/common/trunk/hadoop-tools/hadoop-pipes/src/main/native/pipes/debug/pipes-default-script
          • /hadoop/common/trunk/hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/anonymization/WordList.java
          • /hadoop/common/trunk/hadoop-tools/hadoop-tools-dist/pom.xml
          • /hadoop/common/trunk/hadoop-tools/pom.xml
          • /hadoop/common/trunk/pom.xml
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1314 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1314/ ) HADOOP-9097 . Maven RAT plugin is not checking all source files (tgraves) (Revision 1432934) Result = FAILURE tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1432934 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/pom.xml /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/config.h.cmake /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/resources/META-INF/services/org.apache.hadoop.security.SecurityInfo /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestDelegationTokenRenewer.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/resources/META-INF/services/org.apache.hadoop.security.token.TokenIdentifier /hadoop/common/trunk/hadoop-common-project/pom.xml /hadoop/common/trunk/hadoop-dist/pom.xml /hadoop/common/trunk/hadoop-tools/hadoop-distcp/src/main/resources/distcp-default.xml /hadoop/common/trunk/hadoop-tools/hadoop-distcp/src/site/xdoc/appendix.xml /hadoop/common/trunk/hadoop-tools/hadoop-distcp/src/site/xdoc/architecture.xml /hadoop/common/trunk/hadoop-tools/hadoop-distcp/src/site/xdoc/cli.xml /hadoop/common/trunk/hadoop-tools/hadoop-distcp/src/site/xdoc/index.xml /hadoop/common/trunk/hadoop-tools/hadoop-distcp/src/site/xdoc/usage.xml /hadoop/common/trunk/hadoop-tools/hadoop-distcp/src/test/resources/sslConfig.xml /hadoop/common/trunk/hadoop-tools/hadoop-pipes/src/main/native/examples/conf/word-part.xml /hadoop/common/trunk/hadoop-tools/hadoop-pipes/src/main/native/examples/conf/word.xml /hadoop/common/trunk/hadoop-tools/hadoop-pipes/src/main/native/pipes/debug/pipes-default-gdb-commands.txt /hadoop/common/trunk/hadoop-tools/hadoop-pipes/src/main/native/pipes/debug/pipes-default-script /hadoop/common/trunk/hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/anonymization/WordList.java /hadoop/common/trunk/hadoop-tools/hadoop-tools-dist/pom.xml /hadoop/common/trunk/hadoop-tools/pom.xml /hadoop/common/trunk/pom.xml
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #1286 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1286/)
          HADOOP-9097. Maven RAT plugin is not checking all source files (tgraves) (Revision 1432934)

          Result = FAILURE
          tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1432934
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/pom.xml
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/config.h.cmake
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/resources/META-INF/services/org.apache.hadoop.security.SecurityInfo
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestDelegationTokenRenewer.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/resources/META-INF/services/org.apache.hadoop.security.token.TokenIdentifier
          • /hadoop/common/trunk/hadoop-common-project/pom.xml
          • /hadoop/common/trunk/hadoop-dist/pom.xml
          • /hadoop/common/trunk/hadoop-tools/hadoop-distcp/src/main/resources/distcp-default.xml
          • /hadoop/common/trunk/hadoop-tools/hadoop-distcp/src/site/xdoc/appendix.xml
          • /hadoop/common/trunk/hadoop-tools/hadoop-distcp/src/site/xdoc/architecture.xml
          • /hadoop/common/trunk/hadoop-tools/hadoop-distcp/src/site/xdoc/cli.xml
          • /hadoop/common/trunk/hadoop-tools/hadoop-distcp/src/site/xdoc/index.xml
          • /hadoop/common/trunk/hadoop-tools/hadoop-distcp/src/site/xdoc/usage.xml
          • /hadoop/common/trunk/hadoop-tools/hadoop-distcp/src/test/resources/sslConfig.xml
          • /hadoop/common/trunk/hadoop-tools/hadoop-pipes/src/main/native/examples/conf/word-part.xml
          • /hadoop/common/trunk/hadoop-tools/hadoop-pipes/src/main/native/examples/conf/word.xml
          • /hadoop/common/trunk/hadoop-tools/hadoop-pipes/src/main/native/pipes/debug/pipes-default-gdb-commands.txt
          • /hadoop/common/trunk/hadoop-tools/hadoop-pipes/src/main/native/pipes/debug/pipes-default-script
          • /hadoop/common/trunk/hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/anonymization/WordList.java
          • /hadoop/common/trunk/hadoop-tools/hadoop-tools-dist/pom.xml
          • /hadoop/common/trunk/hadoop-tools/pom.xml
          • /hadoop/common/trunk/pom.xml
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1286 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1286/ ) HADOOP-9097 . Maven RAT plugin is not checking all source files (tgraves) (Revision 1432934) Result = FAILURE tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1432934 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/pom.xml /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/config.h.cmake /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/resources/META-INF/services/org.apache.hadoop.security.SecurityInfo /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestDelegationTokenRenewer.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/resources/META-INF/services/org.apache.hadoop.security.token.TokenIdentifier /hadoop/common/trunk/hadoop-common-project/pom.xml /hadoop/common/trunk/hadoop-dist/pom.xml /hadoop/common/trunk/hadoop-tools/hadoop-distcp/src/main/resources/distcp-default.xml /hadoop/common/trunk/hadoop-tools/hadoop-distcp/src/site/xdoc/appendix.xml /hadoop/common/trunk/hadoop-tools/hadoop-distcp/src/site/xdoc/architecture.xml /hadoop/common/trunk/hadoop-tools/hadoop-distcp/src/site/xdoc/cli.xml /hadoop/common/trunk/hadoop-tools/hadoop-distcp/src/site/xdoc/index.xml /hadoop/common/trunk/hadoop-tools/hadoop-distcp/src/site/xdoc/usage.xml /hadoop/common/trunk/hadoop-tools/hadoop-distcp/src/test/resources/sslConfig.xml /hadoop/common/trunk/hadoop-tools/hadoop-pipes/src/main/native/examples/conf/word-part.xml /hadoop/common/trunk/hadoop-tools/hadoop-pipes/src/main/native/examples/conf/word.xml /hadoop/common/trunk/hadoop-tools/hadoop-pipes/src/main/native/pipes/debug/pipes-default-gdb-commands.txt /hadoop/common/trunk/hadoop-tools/hadoop-pipes/src/main/native/pipes/debug/pipes-default-script /hadoop/common/trunk/hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/anonymization/WordList.java /hadoop/common/trunk/hadoop-tools/hadoop-tools-dist/pom.xml /hadoop/common/trunk/hadoop-tools/pom.xml /hadoop/common/trunk/pom.xml
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-0.23-Build #495 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/495/)
          HADOOP-9097. Maven RAT plugin is not checking all source files (tgraves) (Revision 1432947)

          Result = FAILURE
          tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1432947
          Files :

          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/pom.xml
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/resources/META-INF/services/org.apache.hadoop.security.SecurityInfo
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/pom.xml
          • /hadoop/common/branches/branch-0.23/hadoop-dist/pom.xml
          • /hadoop/common/branches/branch-0.23/hadoop-tools/hadoop-distcp/src/main/resources/distcp-default.xml
          • /hadoop/common/branches/branch-0.23/hadoop-tools/hadoop-distcp/src/site/xdoc/appendix.xml
          • /hadoop/common/branches/branch-0.23/hadoop-tools/hadoop-distcp/src/site/xdoc/architecture.xml
          • /hadoop/common/branches/branch-0.23/hadoop-tools/hadoop-distcp/src/site/xdoc/cli.xml
          • /hadoop/common/branches/branch-0.23/hadoop-tools/hadoop-distcp/src/site/xdoc/index.xml
          • /hadoop/common/branches/branch-0.23/hadoop-tools/hadoop-distcp/src/site/xdoc/usage.xml
          • /hadoop/common/branches/branch-0.23/hadoop-tools/hadoop-distcp/src/test/resources/sslConfig.xml
          • /hadoop/common/branches/branch-0.23/hadoop-tools/hadoop-pipes/src/main/native/examples/conf/word-part.xml
          • /hadoop/common/branches/branch-0.23/hadoop-tools/hadoop-pipes/src/main/native/examples/conf/word.xml
          • /hadoop/common/branches/branch-0.23/hadoop-tools/hadoop-pipes/src/main/native/pipes/debug/pipes-default-gdb-commands.txt
          • /hadoop/common/branches/branch-0.23/hadoop-tools/hadoop-pipes/src/main/native/pipes/debug/pipes-default-script
          • /hadoop/common/branches/branch-0.23/hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/anonymization/WordList.java
          • /hadoop/common/branches/branch-0.23/hadoop-tools/hadoop-tools-dist/pom.xml
          • /hadoop/common/branches/branch-0.23/hadoop-tools/pom.xml
          • /hadoop/common/branches/branch-0.23/pom.xml
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #495 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/495/ ) HADOOP-9097 . Maven RAT plugin is not checking all source files (tgraves) (Revision 1432947) Result = FAILURE tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1432947 Files : /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/pom.xml /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/resources/META-INF/services/org.apache.hadoop.security.SecurityInfo /hadoop/common/branches/branch-0.23/hadoop-common-project/pom.xml /hadoop/common/branches/branch-0.23/hadoop-dist/pom.xml /hadoop/common/branches/branch-0.23/hadoop-tools/hadoop-distcp/src/main/resources/distcp-default.xml /hadoop/common/branches/branch-0.23/hadoop-tools/hadoop-distcp/src/site/xdoc/appendix.xml /hadoop/common/branches/branch-0.23/hadoop-tools/hadoop-distcp/src/site/xdoc/architecture.xml /hadoop/common/branches/branch-0.23/hadoop-tools/hadoop-distcp/src/site/xdoc/cli.xml /hadoop/common/branches/branch-0.23/hadoop-tools/hadoop-distcp/src/site/xdoc/index.xml /hadoop/common/branches/branch-0.23/hadoop-tools/hadoop-distcp/src/site/xdoc/usage.xml /hadoop/common/branches/branch-0.23/hadoop-tools/hadoop-distcp/src/test/resources/sslConfig.xml /hadoop/common/branches/branch-0.23/hadoop-tools/hadoop-pipes/src/main/native/examples/conf/word-part.xml /hadoop/common/branches/branch-0.23/hadoop-tools/hadoop-pipes/src/main/native/examples/conf/word.xml /hadoop/common/branches/branch-0.23/hadoop-tools/hadoop-pipes/src/main/native/pipes/debug/pipes-default-gdb-commands.txt /hadoop/common/branches/branch-0.23/hadoop-tools/hadoop-pipes/src/main/native/pipes/debug/pipes-default-script /hadoop/common/branches/branch-0.23/hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/anonymization/WordList.java /hadoop/common/branches/branch-0.23/hadoop-tools/hadoop-tools-dist/pom.xml /hadoop/common/branches/branch-0.23/hadoop-tools/pom.xml /hadoop/common/branches/branch-0.23/pom.xml
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Yarn-trunk #97 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/97/)
          HADOOP-9097. Maven RAT plugin is not checking all source files (tgraves) (Revision 1432934)

          Result = SUCCESS
          tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1432934
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/pom.xml
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/config.h.cmake
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/resources/META-INF/services/org.apache.hadoop.security.SecurityInfo
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestDelegationTokenRenewer.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/resources/META-INF/services/org.apache.hadoop.security.token.TokenIdentifier
          • /hadoop/common/trunk/hadoop-common-project/pom.xml
          • /hadoop/common/trunk/hadoop-dist/pom.xml
          • /hadoop/common/trunk/hadoop-tools/hadoop-distcp/src/main/resources/distcp-default.xml
          • /hadoop/common/trunk/hadoop-tools/hadoop-distcp/src/site/xdoc/appendix.xml
          • /hadoop/common/trunk/hadoop-tools/hadoop-distcp/src/site/xdoc/architecture.xml
          • /hadoop/common/trunk/hadoop-tools/hadoop-distcp/src/site/xdoc/cli.xml
          • /hadoop/common/trunk/hadoop-tools/hadoop-distcp/src/site/xdoc/index.xml
          • /hadoop/common/trunk/hadoop-tools/hadoop-distcp/src/site/xdoc/usage.xml
          • /hadoop/common/trunk/hadoop-tools/hadoop-distcp/src/test/resources/sslConfig.xml
          • /hadoop/common/trunk/hadoop-tools/hadoop-pipes/src/main/native/examples/conf/word-part.xml
          • /hadoop/common/trunk/hadoop-tools/hadoop-pipes/src/main/native/examples/conf/word.xml
          • /hadoop/common/trunk/hadoop-tools/hadoop-pipes/src/main/native/pipes/debug/pipes-default-gdb-commands.txt
          • /hadoop/common/trunk/hadoop-tools/hadoop-pipes/src/main/native/pipes/debug/pipes-default-script
          • /hadoop/common/trunk/hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/anonymization/WordList.java
          • /hadoop/common/trunk/hadoop-tools/hadoop-tools-dist/pom.xml
          • /hadoop/common/trunk/hadoop-tools/pom.xml
          • /hadoop/common/trunk/pom.xml
          Show
          Hudson added a comment - Integrated in Hadoop-Yarn-trunk #97 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/97/ ) HADOOP-9097 . Maven RAT plugin is not checking all source files (tgraves) (Revision 1432934) Result = SUCCESS tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1432934 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/pom.xml /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/config.h.cmake /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/resources/META-INF/services/org.apache.hadoop.security.SecurityInfo /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestDelegationTokenRenewer.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/resources/META-INF/services/org.apache.hadoop.security.token.TokenIdentifier /hadoop/common/trunk/hadoop-common-project/pom.xml /hadoop/common/trunk/hadoop-dist/pom.xml /hadoop/common/trunk/hadoop-tools/hadoop-distcp/src/main/resources/distcp-default.xml /hadoop/common/trunk/hadoop-tools/hadoop-distcp/src/site/xdoc/appendix.xml /hadoop/common/trunk/hadoop-tools/hadoop-distcp/src/site/xdoc/architecture.xml /hadoop/common/trunk/hadoop-tools/hadoop-distcp/src/site/xdoc/cli.xml /hadoop/common/trunk/hadoop-tools/hadoop-distcp/src/site/xdoc/index.xml /hadoop/common/trunk/hadoop-tools/hadoop-distcp/src/site/xdoc/usage.xml /hadoop/common/trunk/hadoop-tools/hadoop-distcp/src/test/resources/sslConfig.xml /hadoop/common/trunk/hadoop-tools/hadoop-pipes/src/main/native/examples/conf/word-part.xml /hadoop/common/trunk/hadoop-tools/hadoop-pipes/src/main/native/examples/conf/word.xml /hadoop/common/trunk/hadoop-tools/hadoop-pipes/src/main/native/pipes/debug/pipes-default-gdb-commands.txt /hadoop/common/trunk/hadoop-tools/hadoop-pipes/src/main/native/pipes/debug/pipes-default-script /hadoop/common/trunk/hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/anonymization/WordList.java /hadoop/common/trunk/hadoop-tools/hadoop-tools-dist/pom.xml /hadoop/common/trunk/hadoop-tools/pom.xml /hadoop/common/trunk/pom.xml
          Hide
          Todd Lipcon added a comment -

          This seems to be flagging two files as not having licenses:

          !????? /home/jenkins/jenkins-slave/workspace/PreCommit-HDFS-Build/trunk/hadoop-hdfs-project/hadoop-hdfs/src/site/resources/images/hdfsdatanodes.odg
          !????? /home/jenkins/jenkins-slave/workspace/PreCommit-HDFS-Build/trunk/hadoop-hdfs-project/hadoop-hdfs/src/site/resources/images/hdfsarchitecture.odg
          Lines that start with ????? in the release audit report indicate files that do not have an Apache license header.

          (seen in PreCommit-HDFS #3835)

          Show
          Todd Lipcon added a comment - This seems to be flagging two files as not having licenses: !????? /home/jenkins/jenkins-slave/workspace/PreCommit-HDFS-Build/trunk/hadoop-hdfs-project/hadoop-hdfs/src/site/resources/images/hdfsdatanodes.odg !????? /home/jenkins/jenkins-slave/workspace/PreCommit-HDFS-Build/trunk/hadoop-hdfs-project/hadoop-hdfs/src/site/resources/images/hdfsarchitecture.odg Lines that start with ????? in the release audit report indicate files that do not have an Apache license header. (seen in PreCommit-HDFS #3835)
          Hide
          Hudson added a comment -

          Integrated in Hadoop-trunk-Commit #3224 (See https://builds.apache.org/job/Hadoop-trunk-Commit/3224/)
          HADOOP-9097. Maven RAT plugin is not checking all source files (tgraves) (Revision 1432934)

          Result = SUCCESS
          tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1432934
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/pom.xml
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/config.h.cmake
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/resources/META-INF/services/org.apache.hadoop.security.SecurityInfo
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestDelegationTokenRenewer.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/resources/META-INF/services/org.apache.hadoop.security.token.TokenIdentifier
          • /hadoop/common/trunk/hadoop-common-project/pom.xml
          • /hadoop/common/trunk/hadoop-dist/pom.xml
          • /hadoop/common/trunk/hadoop-tools/hadoop-distcp/src/main/resources/distcp-default.xml
          • /hadoop/common/trunk/hadoop-tools/hadoop-distcp/src/site/xdoc/appendix.xml
          • /hadoop/common/trunk/hadoop-tools/hadoop-distcp/src/site/xdoc/architecture.xml
          • /hadoop/common/trunk/hadoop-tools/hadoop-distcp/src/site/xdoc/cli.xml
          • /hadoop/common/trunk/hadoop-tools/hadoop-distcp/src/site/xdoc/index.xml
          • /hadoop/common/trunk/hadoop-tools/hadoop-distcp/src/site/xdoc/usage.xml
          • /hadoop/common/trunk/hadoop-tools/hadoop-distcp/src/test/resources/sslConfig.xml
          • /hadoop/common/trunk/hadoop-tools/hadoop-pipes/src/main/native/examples/conf/word-part.xml
          • /hadoop/common/trunk/hadoop-tools/hadoop-pipes/src/main/native/examples/conf/word.xml
          • /hadoop/common/trunk/hadoop-tools/hadoop-pipes/src/main/native/pipes/debug/pipes-default-gdb-commands.txt
          • /hadoop/common/trunk/hadoop-tools/hadoop-pipes/src/main/native/pipes/debug/pipes-default-script
          • /hadoop/common/trunk/hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/anonymization/WordList.java
          • /hadoop/common/trunk/hadoop-tools/hadoop-tools-dist/pom.xml
          • /hadoop/common/trunk/hadoop-tools/pom.xml
          • /hadoop/common/trunk/pom.xml
          Show
          Hudson added a comment - Integrated in Hadoop-trunk-Commit #3224 (See https://builds.apache.org/job/Hadoop-trunk-Commit/3224/ ) HADOOP-9097 . Maven RAT plugin is not checking all source files (tgraves) (Revision 1432934) Result = SUCCESS tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1432934 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/pom.xml /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/config.h.cmake /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/resources/META-INF/services/org.apache.hadoop.security.SecurityInfo /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestDelegationTokenRenewer.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/resources/META-INF/services/org.apache.hadoop.security.token.TokenIdentifier /hadoop/common/trunk/hadoop-common-project/pom.xml /hadoop/common/trunk/hadoop-dist/pom.xml /hadoop/common/trunk/hadoop-tools/hadoop-distcp/src/main/resources/distcp-default.xml /hadoop/common/trunk/hadoop-tools/hadoop-distcp/src/site/xdoc/appendix.xml /hadoop/common/trunk/hadoop-tools/hadoop-distcp/src/site/xdoc/architecture.xml /hadoop/common/trunk/hadoop-tools/hadoop-distcp/src/site/xdoc/cli.xml /hadoop/common/trunk/hadoop-tools/hadoop-distcp/src/site/xdoc/index.xml /hadoop/common/trunk/hadoop-tools/hadoop-distcp/src/site/xdoc/usage.xml /hadoop/common/trunk/hadoop-tools/hadoop-distcp/src/test/resources/sslConfig.xml /hadoop/common/trunk/hadoop-tools/hadoop-pipes/src/main/native/examples/conf/word-part.xml /hadoop/common/trunk/hadoop-tools/hadoop-pipes/src/main/native/examples/conf/word.xml /hadoop/common/trunk/hadoop-tools/hadoop-pipes/src/main/native/pipes/debug/pipes-default-gdb-commands.txt /hadoop/common/trunk/hadoop-tools/hadoop-pipes/src/main/native/pipes/debug/pipes-default-script /hadoop/common/trunk/hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/anonymization/WordList.java /hadoop/common/trunk/hadoop-tools/hadoop-tools-dist/pom.xml /hadoop/common/trunk/hadoop-tools/pom.xml /hadoop/common/trunk/pom.xml
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12564474/HADOOP-9097-branch-0.23-entire.patch
          against trunk revision .

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2028//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12564474/HADOOP-9097-branch-0.23-entire.patch against trunk revision . -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2028//console This message is automatically generated.
          Hide
          Thomas Graves added a comment -

          upload corresponding branch-0.23 patches.

          Show
          Thomas Graves added a comment - upload corresponding branch-0.23 patches.
          Hide
          Thomas Graves added a comment -

          Update common pom.xml to include the .idea/** and .git/**.

          also upload the entire patch that includes that common change plus adding the tree.h license to hdfs LICENSE.txt.

          Show
          Thomas Graves added a comment - Update common pom.xml to include the .idea/** and .git/**. also upload the entire patch that includes that common change plus adding the tree.h license to hdfs LICENSE.txt.
          Hide
          Tom White added a comment -

          Sorry I missed the remove script. That looks good to me.

          Show
          Tom White added a comment - Sorry I missed the remove script. That looks good to me.
          Hide
          Thomas Graves added a comment -

          Thanks Tom. The empty files are removed via the HADOOP-9097-remove.sh script I attached. I could probably make those scripts a bit better as it just does svn rm <file>.

          I'll add the tree.h license into hdfs. I'll also add the .git and .idea to top level.

          Show
          Thomas Graves added a comment - Thanks Tom. The empty files are removed via the HADOOP-9097 -remove.sh script I attached. I could probably make those scripts a bit better as it just does svn rm <file>. I'll add the tree.h license into hdfs. I'll also add the .git and .idea to top level.
          Hide
          Tom White added a comment -

          Regarding the source files with third party licenses, by my reading of http://apache.org/legal/resolved.html#required-third-party-notices and the licenses in hadoop-hdfs-project/hadoop-hdfs/src/main/native/util/tree.h and hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/io/compress/lz4/lz4.c, it is necessary to add the licenses to the Hadoop LICENSE.txt files. I see that lz4.c's license is in the common LICENSE.txt file, but tree.h isn't in HDFS's. So that should be fixed.

          I notice that the following files are empty and can presumably be removed:

          • hadoop-hdfs-project/hadoop-hdfs/src/test/aop/org/apache/hadoop/hdfs/server/datanode/DataXceiverAspects.aj
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolProtocolBuffers/overview.html
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/MockApp.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/MockContainer.java

          Though not strictly necessary, it would be nice to add .git/** and .idea/** to the top-level excludes.

          With these changes I managed to get a clean run of mvn apache-rat:check with the combined patch.

          +1 on the combined patch. Thanks a lot for doing this work Tom.

          Show
          Tom White added a comment - Regarding the source files with third party licenses, by my reading of http://apache.org/legal/resolved.html#required-third-party-notices and the licenses in hadoop-hdfs-project/hadoop-hdfs/src/main/native/util/tree.h and hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/io/compress/lz4/lz4.c, it is necessary to add the licenses to the Hadoop LICENSE.txt files. I see that lz4.c's license is in the common LICENSE.txt file, but tree.h isn't in HDFS's. So that should be fixed. I notice that the following files are empty and can presumably be removed: hadoop-hdfs-project/hadoop-hdfs/src/test/aop/org/apache/hadoop/hdfs/server/datanode/DataXceiverAspects.aj hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolProtocolBuffers/overview.html hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/MockApp.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/MockContainer.java Though not strictly necessary, it would be nice to add .git/** and .idea/** to the top-level excludes. With these changes I managed to get a clean run of mvn apache-rat:check with the combined patch. +1 on the combined patch. Thanks a lot for doing this work Tom.
          Hide
          Thomas Graves added a comment -

          the test has been failing on other builds and isn't related to this. The release audit warnings are due to needing the other 3 jira.

          Show
          Thomas Graves added a comment - the test has been failing on other builds and isn't related to this. The release audit warnings are due to needing the other 3 jira.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12564358/HADOOP-9097.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 4 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          -1 release audit. The applied patch generated 11 release audit warnings.

          -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-dist hadoop-tools/hadoop-distcp hadoop-tools/hadoop-rumen hadoop-tools/hadoop-tools-dist:

          org.apache.hadoop.ha.TestZKFailoverController

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2024//testReport/
          Release audit warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/2024//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2024//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12564358/HADOOP-9097.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 4 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. -1 release audit . The applied patch generated 11 release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-dist hadoop-tools/hadoop-distcp hadoop-tools/hadoop-rumen hadoop-tools/hadoop-tools-dist: org.apache.hadoop.ha.TestZKFailoverController +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2024//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/2024//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2024//console This message is automatically generated.
          Hide
          Thomas Graves added a comment -

          I've attached 2 "entire" patches which are the combination of all 4 jira.

          The committer should run the remove script first then apply the appropriate patch. The trunk patch works on branch-2 also, but there is a separate remove script.

          Show
          Thomas Graves added a comment - I've attached 2 "entire" patches which are the combination of all 4 jira. The committer should run the remove script first then apply the appropriate patch. The trunk patch works on branch-2 also, but there is a separate remove script.
          Hide
          Thomas Graves added a comment -

          HDFS-4385 is hdfs side.

          Show
          Thomas Graves added a comment - HDFS-4385 is hdfs side.
          Hide
          Thomas Graves added a comment -

          There are a couple of files that I'm not sure about for this. They have existing copyright/licenses. Anyone with experience with apache license know?

          hadoop-hdfs-project/hadoop-hdfs/src/main/native/util/tree.h
          hadoop-hdfs-project/hadoop-hdfs/src/test/aop/org/apache/hadoop/hdfs/server/datanode/DataXceiverAspects.aj
          hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/io/compress/lz4/lz4.c

          Show
          Thomas Graves added a comment - There are a couple of files that I'm not sure about for this. They have existing copyright/licenses. Anyone with experience with apache license know? hadoop-hdfs-project/hadoop-hdfs/src/main/native/util/tree.h hadoop-hdfs-project/hadoop-hdfs/src/test/aop/org/apache/hadoop/hdfs/server/datanode/DataXceiverAspects.aj hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/io/compress/lz4/lz4.c
          Hide
          Tom White added a comment -

          It looks like the plugin is configured to only check pom.xml in some places:

                <plugin>
                  <groupId>org.apache.rat</groupId>
                  <artifactId>apache-rat-plugin</artifactId>
                  <configuration>
                    <includes>
                      <include>pom.xml</include>
                    </includes>
                  </configuration>
                </plugin>
          

          We should change this to include everything by default, and list exclusions in cases where it is not possible to add a license header (e.g. binary files). Service loader files (under META-INF), can have headers added since # is recognized as a comment.

          Show
          Tom White added a comment - It looks like the plugin is configured to only check pom.xml in some places: <plugin> <groupId>org.apache.rat</groupId> <artifactId>apache-rat-plugin</artifactId> <configuration> <includes> <include>pom.xml</include> </includes> </configuration> </plugin> We should change this to include everything by default, and list exclusions in cases where it is not possible to add a license header (e.g. binary files). Service loader files (under META-INF), can have headers added since # is recognized as a comment.

            People

            • Assignee:
              Thomas Graves
              Reporter:
              Tom White
            • Votes:
              0 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development