Hadoop Common
  1. Hadoop Common
  2. HADOOP-9081

Port TestWinUtils from branch-1-win to branch-trunk-win

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: trunk-win
    • Fix Version/s: trunk-win
    • Component/s: test
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      branch-1-win has a test suite named TestWinUtils to cover winutils.exe functionality. We need to port this to branch-trunk-win.

      1. HADOOP-9081-branch-trunk-win.1.patch
        104 kB
        Chris Nauroth
      2. test-untar.tar
        20 kB
        Chris Nauroth
      3. test-untar.tgz
        2 kB
        Chris Nauroth

        Issue Links

          Activity

          Hide
          Ivan Mitic added a comment -

          Thanks Chris for filing this Jira. It might be useful to tag along another snapshot of winutils which includes a few bugfixes. At this point, winutils is in pretty stable state in branch-1-win, and converging the two would be great.

          Show
          Ivan Mitic added a comment - Thanks Chris for filing this Jira. It might be useful to tag along another snapshot of winutils which includes a few bugfixes. At this point, winutils is in pretty stable state in branch-1-win, and converging the two would be great.
          Hide
          Chris Nauroth added a comment -

          Thanks, Ivan. Sounds like a good plan. The scope of this jira then is a merge of branch-1-win winutils to branch-trunk-win (no merge conflicts expected) and TestWinUtils at 100% test pass rate.

          Show
          Chris Nauroth added a comment - Thanks, Ivan. Sounds like a good plan. The scope of this jira then is a merge of branch-1-win winutils to branch-trunk-win (no merge conflicts expected) and TestWinUtils at 100% test pass rate.
          Hide
          Chris Nauroth added a comment -

          I am attaching a patch that is a consolidated port of branch-1-win changes that have not yet made it to branch-trunk-win. This patch is meant to port the following branch-1-win jiras:

          HADOOP-8456
          HADOOP-8763
          HADOOP-8847
          HADOOP-8872
          HADOOP-8936
          HADOOP-9006
          HADOOP-9026
          HADOOP-9061
          HDFS-4065

          I have tested this patch, including the new TestWinUtils suite, on Mac and Windows.

          Please credit this patch to the full list of original contributors: Chuan Liu, Ivan Mitic, Chris Nauroth, and Bikas Saha.

          Please also note that I have attached 2 binary files: test-untar.tar and test-untar.tgz. These must be committed to hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs. (I couldn't figure out a good way to put binary files into the patch.)

          Show
          Chris Nauroth added a comment - I am attaching a patch that is a consolidated port of branch-1-win changes that have not yet made it to branch-trunk-win. This patch is meant to port the following branch-1-win jiras: HADOOP-8456 HADOOP-8763 HADOOP-8847 HADOOP-8872 HADOOP-8936 HADOOP-9006 HADOOP-9026 HADOOP-9061 HDFS-4065 I have tested this patch, including the new TestWinUtils suite, on Mac and Windows. Please credit this patch to the full list of original contributors: Chuan Liu, Ivan Mitic, Chris Nauroth, and Bikas Saha. Please also note that I have attached 2 binary files: test-untar.tar and test-untar.tgz. These must be committed to hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs. (I couldn't figure out a good way to put binary files into the patch.)
          Hide
          Suresh Srinivas added a comment -

          +1 for the patch. I will take care svn adds for the two binary files.

          Show
          Suresh Srinivas added a comment - +1 for the patch. I will take care svn adds for the two binary files.
          Hide
          Suresh Srinivas added a comment -

          I committed the patch to trunk-win. Thank you Chuan Liu, Ivan Mitic, Chris Nauroth, and Bikas Saha.

          Show
          Suresh Srinivas added a comment - I committed the patch to trunk-win. Thank you Chuan Liu, Ivan Mitic, Chris Nauroth, and Bikas Saha.

            People

            • Assignee:
              Chris Nauroth
              Reporter:
              Chris Nauroth
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development