Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-9075

FileContext#FSLinkResolver should be made static

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.0-alpha
    • Fix Version/s: 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      FSLinkResolver class does not require access to Outer Class and hence should be made static.

      1. HDFS-4218.patch
        1 kB
        Arpit Agarwal

        Activity

        Hide
        hudson Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #1264 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1264/)
        HADOOP-9075. FileContext#FSLinkResolver should be made static. Contributed by Arpit Agarwal. (Revision 1411988)

        Result = FAILURE
        suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1411988
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileContext.java
        Show
        hudson Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1264 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1264/ ) HADOOP-9075 . FileContext#FSLinkResolver should be made static. Contributed by Arpit Agarwal. (Revision 1411988) Result = FAILURE suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1411988 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileContext.java
        Hide
        hudson Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #1233 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1233/)
        HADOOP-9075. FileContext#FSLinkResolver should be made static. Contributed by Arpit Agarwal. (Revision 1411988)

        Result = SUCCESS
        suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1411988
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileContext.java
        Show
        hudson Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1233 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1233/ ) HADOOP-9075 . FileContext#FSLinkResolver should be made static. Contributed by Arpit Agarwal. (Revision 1411988) Result = SUCCESS suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1411988 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileContext.java
        Hide
        hudson Hudson added a comment -

        Integrated in Hadoop-Yarn-trunk #43 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/43/)
        HADOOP-9075. FileContext#FSLinkResolver should be made static. Contributed by Arpit Agarwal. (Revision 1411988)

        Result = SUCCESS
        suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1411988
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileContext.java
        Show
        hudson Hudson added a comment - Integrated in Hadoop-Yarn-trunk #43 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/43/ ) HADOOP-9075 . FileContext#FSLinkResolver should be made static. Contributed by Arpit Agarwal. (Revision 1411988) Result = SUCCESS suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1411988 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileContext.java
        Hide
        hudson Hudson added a comment -

        Integrated in Hadoop-trunk-Commit #3052 (See https://builds.apache.org/job/Hadoop-trunk-Commit/3052/)
        HADOOP-9075. FileContext#FSLinkResolver should be made static. Contributed by Arpit Agarwal. (Revision 1411988)

        Result = SUCCESS
        suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1411988
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileContext.java
        Show
        hudson Hudson added a comment - Integrated in Hadoop-trunk-Commit #3052 (See https://builds.apache.org/job/Hadoop-trunk-Commit/3052/ ) HADOOP-9075 . FileContext#FSLinkResolver should be made static. Contributed by Arpit Agarwal. (Revision 1411988) Result = SUCCESS suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1411988 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileContext.java
        Hide
        sureshms Suresh Srinivas added a comment -

        +1. I committed the patch to trunk

        Thank you Arpit.

        Show
        sureshms Suresh Srinivas added a comment - +1. I committed the patch to trunk Thank you Arpit.
        Hide
        arpitagarwal Arpit Agarwal added a comment -

        No new tests are needed since this patch just makes a nested class static.

        Show
        arpitagarwal Arpit Agarwal added a comment - No new tests are needed since this patch just makes a nested class static.
        Hide
        eli Eli Collins added a comment -

        +1 lgtm

        Show
        eli Eli Collins added a comment - +1 lgtm
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12554449/HDFS-4218.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/3550//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3550//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12554449/HDFS-4218.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/3550//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3550//console This message is automatically generated.

          People

          • Assignee:
            arpitagarwal Arpit Agarwal
            Reporter:
            sureshms Suresh Srinivas
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development