Hadoop Common
  1. Hadoop Common
  2. HADOOP-9038

provide unit-test coverage of class org.apache.hadoop.fs.LocalDirAllocator.AllocatorPerContext.PathIterator

    Details

    • Type: Test Test
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0.0, 2.0.3-alpha, 0.23.6
    • Component/s: None
    • Labels:
      None

      Description

      The class org.apache.hadoop.fs.LocalDirAllocator.AllocatorPerContext.PathIterator currently has zero unit-test coverage. Add/enhance the tests to provide one.

      1. HADOOP-9038.patch
        4 kB
        Ivan A. Veselovsky

        Activity

        Hide
        Ivan A. Veselovsky added a comment -

        attached patch "HADOOP-9038" adds a new unit test to check the mentioned functionality, + makes one correction in method PathIterator#next() implementation.

        Show
        Ivan A. Veselovsky added a comment - attached patch " HADOOP-9038 " adds a new unit test to check the mentioned functionality, + makes one correction in method PathIterator#next() implementation.
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12553652/HADOOP-9038.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1750//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1750//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12553652/HADOOP-9038.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1750//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1750//console This message is automatically generated.
        Hide
        Robert Joseph Evans added a comment -

        The changes look fine to me. I like that we are now conforming correctly to the Iterable interface. +1

        Show
        Robert Joseph Evans added a comment - The changes look fine to me. I like that we are now conforming correctly to the Iterable interface. +1
        Hide
        Robert Joseph Evans added a comment -

        Thanks Ivan,

        I put this into trunk, branch-2, and branch-0.23

        Show
        Robert Joseph Evans added a comment - Thanks Ivan, I put this into trunk, branch-2, and branch-0.23
        Hide
        Hudson added a comment -

        Integrated in Hadoop-trunk-Commit #3058 (See https://builds.apache.org/job/Hadoop-trunk-Commit/3058/)
        HADOOP-9038. unit-tests for AllocatorPerContext.PathIterator (Ivan A. Veselovsky via bobby) (Revision 1413776)

        Result = SUCCESS
        bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1413776
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/LocalDirAllocator.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestLocalDirAllocator.java
        Show
        Hudson added a comment - Integrated in Hadoop-trunk-Commit #3058 (See https://builds.apache.org/job/Hadoop-trunk-Commit/3058/ ) HADOOP-9038 . unit-tests for AllocatorPerContext.PathIterator (Ivan A. Veselovsky via bobby) (Revision 1413776) Result = SUCCESS bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1413776 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/LocalDirAllocator.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestLocalDirAllocator.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Yarn-trunk #49 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/49/)
        HADOOP-9038. unit-tests for AllocatorPerContext.PathIterator (Ivan A. Veselovsky via bobby) (Revision 1413776)

        Result = SUCCESS
        bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1413776
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/LocalDirAllocator.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestLocalDirAllocator.java
        Show
        Hudson added a comment - Integrated in Hadoop-Yarn-trunk #49 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/49/ ) HADOOP-9038 . unit-tests for AllocatorPerContext.PathIterator (Ivan A. Veselovsky via bobby) (Revision 1413776) Result = SUCCESS bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1413776 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/LocalDirAllocator.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestLocalDirAllocator.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-0.23-Build #448 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/448/)
        svn merge -c 1413776 FIXES: HADOOP-9038. unit-tests for AllocatorPerContext.PathIterator (Ivan A. Veselovsky via bobby) (Revision 1413779)

        Result = SUCCESS
        bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1413779
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/LocalDirAllocator.java
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestLocalDirAllocator.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #448 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/448/ ) svn merge -c 1413776 FIXES: HADOOP-9038 . unit-tests for AllocatorPerContext.PathIterator (Ivan A. Veselovsky via bobby) (Revision 1413779) Result = SUCCESS bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1413779 Files : /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/LocalDirAllocator.java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestLocalDirAllocator.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #1239 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1239/)
        HADOOP-9038. unit-tests for AllocatorPerContext.PathIterator (Ivan A. Veselovsky via bobby) (Revision 1413776)

        Result = SUCCESS
        bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1413776
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/LocalDirAllocator.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestLocalDirAllocator.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1239 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1239/ ) HADOOP-9038 . unit-tests for AllocatorPerContext.PathIterator (Ivan A. Veselovsky via bobby) (Revision 1413776) Result = SUCCESS bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1413776 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/LocalDirAllocator.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestLocalDirAllocator.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #1270 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1270/)
        HADOOP-9038. unit-tests for AllocatorPerContext.PathIterator (Ivan A. Veselovsky via bobby) (Revision 1413776)

        Result = FAILURE
        bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1413776
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/LocalDirAllocator.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestLocalDirAllocator.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1270 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1270/ ) HADOOP-9038 . unit-tests for AllocatorPerContext.PathIterator (Ivan A. Veselovsky via bobby) (Revision 1413776) Result = FAILURE bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1413776 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/LocalDirAllocator.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestLocalDirAllocator.java

          People

          • Assignee:
            Ivan A. Veselovsky
            Reporter:
            Ivan A. Veselovsky
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development