Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-9037

Bug in test-patch.sh and precommit build process

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-alpha1
    • Fix Version/s: 3.0.0-alpha1
    • Component/s: build
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      In HDFS-4171, the precommit build failed, but it still posted +1 for every category.

      ======================================================================
      ======================================================================
          Running tests.
      ======================================================================
      ======================================================================
      
      
      /home/jenkins/jenkins-slave/workspace/PreCommit-HDFS-Build/trunk/
      dev-support/test-patch.sh: line 713: [: hadoop-hdfs-project/hadoop-hdfs:
      binary operator expected
      

        Activity

        Hide
        hudson Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #1258 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1258/)
        HADOOP-9037. Bug in test-patch.sh and precommit build process. Contributed by Kihwal Lee (Revision 1409274)

        Result = FAILURE
        jlowe : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1409274
        Files :

        • /hadoop/common/trunk/dev-support/test-patch.sh
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1258 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1258/ ) HADOOP-9037 . Bug in test-patch.sh and precommit build process. Contributed by Kihwal Lee (Revision 1409274) Result = FAILURE jlowe : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1409274 Files : /hadoop/common/trunk/dev-support/test-patch.sh /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #1227 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1227/)
        HADOOP-9037. Bug in test-patch.sh and precommit build process. Contributed by Kihwal Lee (Revision 1409274)

        Result = FAILURE
        jlowe : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1409274
        Files :

        • /hadoop/common/trunk/dev-support/test-patch.sh
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1227 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1227/ ) HADOOP-9037 . Bug in test-patch.sh and precommit build process. Contributed by Kihwal Lee (Revision 1409274) Result = FAILURE jlowe : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1409274 Files : /hadoop/common/trunk/dev-support/test-patch.sh /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        Integrated in Hadoop-Yarn-trunk #37 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/37/)
        HADOOP-9037. Bug in test-patch.sh and precommit build process. Contributed by Kihwal Lee (Revision 1409274)

        Result = SUCCESS
        jlowe : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1409274
        Files :

        • /hadoop/common/trunk/dev-support/test-patch.sh
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - Integrated in Hadoop-Yarn-trunk #37 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/37/ ) HADOOP-9037 . Bug in test-patch.sh and precommit build process. Contributed by Kihwal Lee (Revision 1409274) Result = SUCCESS jlowe : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1409274 Files : /hadoop/common/trunk/dev-support/test-patch.sh /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        Integrated in Hadoop-trunk-Commit #3017 (See https://builds.apache.org/job/Hadoop-trunk-Commit/3017/)
        HADOOP-9037. Bug in test-patch.sh and precommit build process. Contributed by Kihwal Lee (Revision 1409274)

        Result = SUCCESS
        jlowe : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1409274
        Files :

        • /hadoop/common/trunk/dev-support/test-patch.sh
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - Integrated in Hadoop-trunk-Commit #3017 (See https://builds.apache.org/job/Hadoop-trunk-Commit/3017/ ) HADOOP-9037 . Bug in test-patch.sh and precommit build process. Contributed by Kihwal Lee (Revision 1409274) Result = SUCCESS jlowe : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1409274 Files : /hadoop/common/trunk/dev-support/test-patch.sh /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        jlowe Jason Lowe added a comment -

        Thanks, Kihwal. I committed this to trunk.

        Show
        jlowe Jason Lowe added a comment - Thanks, Kihwal. I committed this to trunk.
        Hide
        jlowe Jason Lowe added a comment -

        +1 lgtm.

        Show
        jlowe Jason Lowe added a comment - +1 lgtm.
        Hide
        hadoopqa Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12553510/hadoop-9037.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1745//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1745//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12553510/hadoop-9037.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in . +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1745//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1745//console This message is automatically generated.
        Hide
        kihwal Kihwal Lee added a comment -

        The patch adds quotes around the argument to the unary operator. It may have a leading space, but that only happens when there actually is a module, so the "-n" test is still valid.

        Show
        kihwal Kihwal Lee added a comment - The patch adds quotes around the argument to the unary operator. It may have a leading space, but that only happens when there actually is a module, so the "-n" test is still valid.
        Hide
        kihwal Kihwal Lee added a comment -

        At line 713,

          if [ -n $hdfs_modules ]; then
        

        $hdfs_modules was "hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs". Since "-n" is a unary operator, the test complained.

        Show
        kihwal Kihwal Lee added a comment - At line 713, if [ -n $hdfs_modules ]; then $hdfs_modules was "hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs". Since "-n" is a unary operator, the test complained.

          People

          • Assignee:
            kihwal Kihwal Lee
            Reporter:
            kihwal Kihwal Lee
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development