Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • trunk-win, 3.0.0-alpha1
    • trunk-win
    • net
    • None
    • Reviewed

    Description

      The test asserts status of binding an HTTP server to a port. Perhaps there is some platform-specific difference in handling this on Windows.

      Attachments

        1. HADOOP-8979.patch
          1 kB
          Chris Nauroth

        Issue Links

          Activity

            Chris, thank you for fixing the test failure. +1 for the patch.

            I committed it to branch-trunk-win.

            sureshms Suresh Srinivas added a comment - Chris, thank you for fixing the test failure. +1 for the patch. I committed it to branch-trunk-win.
            chuanliu Chuan Liu added a comment -

            +1 Nice discovery and fix!

            chuanliu Chuan Liu added a comment - +1 Nice discovery and fix!
            hadoopqa Hadoop QA added a comment -

            -1 overall. Here are the results of testing the latest attachment
            http://issues.apache.org/jira/secure/attachment/12551682/HADOOP-8979.patch
            against trunk revision .

            +1 @author. The patch does not contain any @author tags.

            -1 tests included. The patch doesn't appear to include any new or modified tests.
            Please justify why no new tests are needed for this patch.
            Also please list what manual steps were performed to verify this patch.

            +1 javac. The applied patch does not increase the total number of javac compiler warnings.

            +1 javadoc. The javadoc tool did not generate any warning messages.

            +1 eclipse:eclipse. The patch built with eclipse:eclipse.

            +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

            +1 release audit. The applied patch does not increase the total number of release audit warnings.

            +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.

            +1 contrib tests. The patch passed contrib unit tests.

            Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1693//testReport/
            Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1693//console

            This message is automatically generated.

            hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12551682/HADOOP-8979.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1693//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1693//console This message is automatically generated.
            cnauroth Chris Nauroth added a comment -

            This had been fixed in branch-1-win, but it wasn't included in the merge to branch-trunk-win. The attached patch fixes it. We can start this patch in trunk and then merge to branch-trunk-win.

            Jenkins will give a -1 for no new tests. This condition is already covered sufficiently by TestHttpServer.testBindAddress, which had been failing on Windows prior to this patch.

            cnauroth Chris Nauroth added a comment - This had been fixed in branch-1-win, but it wasn't included in the merge to branch-trunk-win. The attached patch fixes it. We can start this patch in trunk and then merge to branch-trunk-win. Jenkins will give a -1 for no new tests. This condition is already covered sufficiently by TestHttpServer.testBindAddress, which had been failing on Windows prior to this patch.
            cnauroth Chris Nauroth added a comment -
            Running org.apache.hadoop.http.TestHttpServer
            Tests run: 12, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 14.497 sec <<< FAILURE!
            testBindAddress(org.apache.hadoop.http.TestHttpServer)  Time elapsed: 531 sec  <<< FAILURE!
            java.lang.AssertionError: 
            	at org.junit.Assert.fail(Assert.java:91)
            	at org.junit.Assert.assertTrue(Assert.java:43)
            	at org.junit.Assert.assertTrue(Assert.java:54)
            	at org.apache.hadoop.http.TestHttpServer.checkBindAddress(TestHttpServer.java:531)
            	at org.apache.hadoop.http.TestHttpServer.testBindAddress(TestHttpServer.java:500)
            	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
            	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
            	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
            	at java.lang.reflect.Method.invoke(Method.java:597)
            	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44)
            	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
            	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41)
            	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
            	at org.junit.runners.BlockJUnit4ClassRunner.runNotIgnored(BlockJUnit4ClassRunner.java:79)
            	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:71)
            	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:49)
            	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:193)
            	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:52)
            	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:191)
            	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:42)
            	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:184)
            	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:28)
            	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:31)
            	at org.junit.runners.ParentRunner.run(ParentRunner.java:236)
            	at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:252)
            	at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:141)
            	at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:112)
            	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
            	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
            	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
            	at java.lang.reflect.Method.invoke(Method.java:597)
            	at org.apache.maven.surefire.util.ReflectionUtils.invokeMethodWithArray(ReflectionUtils.java:189)
            	at org.apache.maven.surefire.booter.ProviderFactory$ProviderProxy.invoke(ProviderFactory.java:165)
            	at org.apache.maven.surefire.booter.ProviderFactory.invokeProvider(ProviderFactory.java:85)
            	at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:115)
            	at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:75)
            
            cnauroth Chris Nauroth added a comment - Running org.apache.hadoop.http.TestHttpServer Tests run: 12, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 14.497 sec <<< FAILURE! testBindAddress(org.apache.hadoop.http.TestHttpServer) Time elapsed: 531 sec <<< FAILURE! java.lang.AssertionError: at org.junit.Assert.fail(Assert.java:91) at org.junit.Assert.assertTrue(Assert.java:43) at org.junit.Assert.assertTrue(Assert.java:54) at org.apache.hadoop.http.TestHttpServer.checkBindAddress(TestHttpServer.java:531) at org.apache.hadoop.http.TestHttpServer.testBindAddress(TestHttpServer.java:500) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20) at org.junit.runners.BlockJUnit4ClassRunner.runNotIgnored(BlockJUnit4ClassRunner.java:79) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:71) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:49) at org.junit.runners.ParentRunner$3.run(ParentRunner.java:193) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:52) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:191) at org.junit.runners.ParentRunner.access$000(ParentRunner.java:42) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:184) at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:28) at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:31) at org.junit.runners.ParentRunner.run(ParentRunner.java:236) at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:252) at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:141) at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:112) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at org.apache.maven.surefire.util.ReflectionUtils.invokeMethodWithArray(ReflectionUtils.java:189) at org.apache.maven.surefire.booter.ProviderFactory$ProviderProxy.invoke(ProviderFactory.java:165) at org.apache.maven.surefire.booter.ProviderFactory.invokeProvider(ProviderFactory.java:85) at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:115) at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:75)

            People

              cnauroth Chris Nauroth
              cnauroth Chris Nauroth
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: