Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: trunk-win, 3.0.0-alpha1
    • Fix Version/s: trunk-win, 3.0.0-alpha1
    • Component/s: fs
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      The test fails on Windows. This may be related to code ported in to DF.java from branch-1-win.

      1. HADOOP-8974.patch
        1 kB
        Chris Nauroth

        Issue Links

          Activity

          Hide
          cnauroth Chris Nauroth added a comment -
          Running org.apache.hadoop.fs.TestDFVariations
          Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0 sec <<< FAILURE!
          testOSParsing(org.apache.hadoop.fs.TestDFVariations)  Time elapsed: 0 sec  <<< FAILURE!
          junit.framework.ComparisonFailure: UNIX mount expected:<[/foo/bar]> but was:<[C:]>
          	at junit.framework.Assert.assertEquals(Assert.java:81)
          	at org.apache.hadoop.fs.TestDFVariations.testOSParsing(TestDFVariations.java:54)
          	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
          	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
          	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
          	at java.lang.reflect.Method.invoke(Method.java:597)
          	at junit.framework.TestCase.runTest(TestCase.java:168)
          	at junit.framework.TestCase.runBare(TestCase.java:134)
          	at junit.framework.TestResult$1.protect(TestResult.java:110)
          	at junit.framework.TestResult.runProtected(TestResult.java:128)
          	at junit.framework.TestResult.run(TestResult.java:113)
          	at junit.framework.TestCase.run(TestCase.java:124)
          	at junit.framework.TestSuite.runTest(TestSuite.java:243)
          	at junit.framework.TestSuite.run(TestSuite.java:238)
          	at org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:83)
          	at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:252)
          	at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:141)
          	at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:112)
          	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
          	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
          	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
          	at java.lang.reflect.Method.invoke(Method.java:597)
          	at org.apache.maven.surefire.util.ReflectionUtils.invokeMethodWithArray(ReflectionUtils.java:189)
          	at org.apache.maven.surefire.booter.ProviderFactory$ProviderProxy.invoke(ProviderFactory.java:165)
          	at org.apache.maven.surefire.booter.ProviderFactory.invokeProvider(ProviderFactory.java:85)
          	at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:115)
          	at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:75)
          
          Show
          cnauroth Chris Nauroth added a comment - Running org.apache.hadoop.fs.TestDFVariations Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0 sec <<< FAILURE! testOSParsing(org.apache.hadoop.fs.TestDFVariations) Time elapsed: 0 sec <<< FAILURE! junit.framework.ComparisonFailure: UNIX mount expected:<[/foo/bar]> but was:<[C:]> at junit.framework.Assert.assertEquals(Assert.java:81) at org.apache.hadoop.fs.TestDFVariations.testOSParsing(TestDFVariations.java:54) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at junit.framework.TestCase.runTest(TestCase.java:168) at junit.framework.TestCase.runBare(TestCase.java:134) at junit.framework.TestResult$1.protect(TestResult.java:110) at junit.framework.TestResult.runProtected(TestResult.java:128) at junit.framework.TestResult.run(TestResult.java:113) at junit.framework.TestCase.run(TestCase.java:124) at junit.framework.TestSuite.runTest(TestSuite.java:243) at junit.framework.TestSuite.run(TestSuite.java:238) at org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:83) at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:252) at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:141) at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:112) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at org.apache.maven.surefire.util.ReflectionUtils.invokeMethodWithArray(ReflectionUtils.java:189) at org.apache.maven.surefire.booter.ProviderFactory$ProviderProxy.invoke(ProviderFactory.java:165) at org.apache.maven.surefire.booter.ProviderFactory.invokeProvider(ProviderFactory.java:85) at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:115) at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:75)
          Hide
          cnauroth Chris Nauroth added a comment -

          branch-1-win added code to DF to override the run() method so that it just sets mount to the drive specification on Windows. TestDFVariations doesn't exist on branch-1-win. When we merged from branch-1-win, it brought in the DF change, but there was no corresponding fix in TestDFVariations. This patch provides that test fix.

          This patch can start on trunk and then immediately merge to branch-trunk-win.

          Show
          cnauroth Chris Nauroth added a comment - branch-1-win added code to DF to override the run() method so that it just sets mount to the drive specification on Windows. TestDFVariations doesn't exist on branch-1-win. When we merged from branch-1-win, it brought in the DF change, but there was no corresponding fix in TestDFVariations. This patch provides that test fix. This patch can start on trunk and then immediately merge to branch-trunk-win.
          Hide
          hadoopqa Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12551485/HADOOP-8974.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1691//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1691//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12551485/HADOOP-8974.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1691//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1691//console This message is automatically generated.
          Hide
          ivanmi Ivan Mitic added a comment -

          Thanks Chris for the patch, looks good, +1

          Show
          ivanmi Ivan Mitic added a comment - Thanks Chris for the patch, looks good, +1
          Hide
          sureshms Suresh Srinivas added a comment -

          +1 for the patch.

          Show
          sureshms Suresh Srinivas added a comment - +1 for the patch.
          Hide
          sureshms Suresh Srinivas added a comment -

          I committed the patch to trunk and branch-trunk-win. Thank you Chris.

          Show
          sureshms Suresh Srinivas added a comment - I committed the patch to trunk and branch-trunk-win. Thank you Chris.
          Hide
          hudson Hudson added a comment -

          Integrated in Hadoop-trunk-Commit #2983 (See https://builds.apache.org/job/Hadoop-trunk-Commit/2983/)
          HADOOP-8974. TestDFVariations fails on Windows. Contributed by Chris Nauroth. (Revision 1407222)

          Result = SUCCESS
          suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1407222
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestDFVariations.java
          Show
          hudson Hudson added a comment - Integrated in Hadoop-trunk-Commit #2983 (See https://builds.apache.org/job/Hadoop-trunk-Commit/2983/ ) HADOOP-8974 . TestDFVariations fails on Windows. Contributed by Chris Nauroth. (Revision 1407222) Result = SUCCESS suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1407222 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestDFVariations.java
          Hide
          hudson Hudson added a comment -

          Integrated in Hadoop-Yarn-trunk #31 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/31/)
          HADOOP-8974. TestDFVariations fails on Windows. Contributed by Chris Nauroth. (Revision 1407222)

          Result = SUCCESS
          suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1407222
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestDFVariations.java
          Show
          hudson Hudson added a comment - Integrated in Hadoop-Yarn-trunk #31 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/31/ ) HADOOP-8974 . TestDFVariations fails on Windows. Contributed by Chris Nauroth. (Revision 1407222) Result = SUCCESS suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1407222 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestDFVariations.java
          Hide
          hudson Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #1221 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1221/)
          HADOOP-8974. TestDFVariations fails on Windows. Contributed by Chris Nauroth. (Revision 1407222)

          Result = SUCCESS
          suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1407222
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestDFVariations.java
          Show
          hudson Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1221 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1221/ ) HADOOP-8974 . TestDFVariations fails on Windows. Contributed by Chris Nauroth. (Revision 1407222) Result = SUCCESS suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1407222 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestDFVariations.java
          Hide
          hudson Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #1251 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1251/)
          HADOOP-8974. TestDFVariations fails on Windows. Contributed by Chris Nauroth. (Revision 1407222)

          Result = FAILURE
          suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1407222
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestDFVariations.java
          Show
          hudson Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1251 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1251/ ) HADOOP-8974 . TestDFVariations fails on Windows. Contributed by Chris Nauroth. (Revision 1407222) Result = FAILURE suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1407222 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestDFVariations.java

            People

            • Assignee:
              cnauroth Chris Nauroth
              Reporter:
              cnauroth Chris Nauroth
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development