Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 1.0.0, 2.0.0-alpha
    • Fix Version/s: 1.2.0, 2.0.3-alpha, 0.23.6
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      I often look at logs and have to track down the java version they were run with, it would be useful if we logged this as part of the startup message.

      1. hadoop-8931-b1.txt
        0.7 kB
        Eli Collins
      2. hadoop-8931.txt
        0.8 kB
        Eli Collins

        Activity

        Eli Collins created issue -
        Hide
        Eli Collins added a comment -

        Trivial patch attached.

        Show
        Eli Collins added a comment - Trivial patch attached.
        Eli Collins made changes -
        Field Original Value New Value
        Attachment hadoop-8931.txt [ 12549246 ]
        Eli Collins made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12549246/hadoop-8931.txt
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1630//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1630//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12549246/hadoop-8931.txt against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1630//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1630//console This message is automatically generated.
        Hide
        Ravi Prakash added a comment -

        I like the idea. Maybe also the classpath and other JVM parameters?

        Show
        Ravi Prakash added a comment - I like the idea. Maybe also the classpath and other JVM parameters?
        Hide
        Ravi Prakash added a comment -

        Oops! Never mind. I thought you were talking about the logs.

        Show
        Ravi Prakash added a comment - Oops! Never mind. I thought you were talking about the logs.
        Hide
        Eli Collins added a comment -

        This will show up in the logs. The classpath is logged right before we log the java version in this patch.

        Show
        Eli Collins added a comment - This will show up in the logs. The classpath is logged right before we log the java version in this patch.
        Hide
        Ravi Prakash added a comment -

        I feel silly now! Ok. Yeah! +1 lgtm

        Show
        Ravi Prakash added a comment - I feel silly now! Ok. Yeah! +1 lgtm
        Hide
        Steve Loughran added a comment -

        java.home already gets printed, doesn't it?

        Show
        Steve Loughran added a comment - java.home already gets printed, doesn't it?
        Hide
        Aaron T. Myers added a comment -

        +1

        Show
        Aaron T. Myers added a comment - +1
        Hide
        Arpit Gupta added a comment -

        can we also port this to branch-1?

        Show
        Arpit Gupta added a comment - can we also port this to branch-1?
        Hide
        Eli Collins added a comment -

        @Steve, JAVA_HOME doesn't get printed.
        @Arpit, I'll merge this to branch-1 as well.
        @ATM, thanks for the review.

        Show
        Eli Collins added a comment - @Steve, JAVA_HOME doesn't get printed. @Arpit, I'll merge this to branch-1 as well. @ATM, thanks for the review.
        Eli Collins made changes -
        Affects Version/s 1.0.0 [ 12318244 ]
        Target Version/s 2.0.3-alpha [ 12323273 ] 1.1.1, 2.0.3-alpha [ 12321658, 12323273 ]
        Hide
        Hudson added a comment -

        Integrated in Hadoop-trunk-Commit #2874 (See https://builds.apache.org/job/Hadoop-trunk-Commit/2874/)
        HADOOP-8931. Add Java version to startup message. Contributed by Eli Collins (Revision 1398998)

        Result = SUCCESS
        eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1398998
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/StringUtils.java
        Show
        Hudson added a comment - Integrated in Hadoop-trunk-Commit #2874 (See https://builds.apache.org/job/Hadoop-trunk-Commit/2874/ ) HADOOP-8931 . Add Java version to startup message. Contributed by Eli Collins (Revision 1398998) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1398998 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/StringUtils.java
        Hide
        Eli Collins added a comment -

        I've committed this and merged to branch-1 and branch-2.

        Show
        Eli Collins added a comment - I've committed this and merged to branch-1 and branch-2.
        Eli Collins made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags Reviewed [ 10343 ]
        Target Version/s 1.1.1, 2.0.3-alpha [ 12321658, 12323273 ]
        Fix Version/s 1.2.0 [ 12321659 ]
        Fix Version/s 2.0.3-alpha [ 12323273 ]
        Resolution Fixed [ 1 ]
        Hide
        Eli Collins added a comment -

        This is the branch-1 patch btw, same change applies the file just lives in a different directory.

        Show
        Eli Collins added a comment - This is the branch-1 patch btw, same change applies the file just lives in a different directory.
        Eli Collins made changes -
        Attachment hadoop-8931-b1.txt [ 12549391 ]
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Yarn-trunk #6 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/6/)
        HADOOP-8931. Add Java version to startup message. Contributed by Eli Collins (Revision 1398998)

        Result = FAILURE
        eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1398998
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/StringUtils.java
        Show
        Hudson added a comment - Integrated in Hadoop-Yarn-trunk #6 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/6/ ) HADOOP-8931 . Add Java version to startup message. Contributed by Eli Collins (Revision 1398998) Result = FAILURE eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1398998 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/StringUtils.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #1198 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1198/)
        HADOOP-8931. Add Java version to startup message. Contributed by Eli Collins (Revision 1398998)

        Result = SUCCESS
        eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1398998
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/StringUtils.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1198 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1198/ ) HADOOP-8931 . Add Java version to startup message. Contributed by Eli Collins (Revision 1398998) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1398998 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/StringUtils.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #1228 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1228/)
        HADOOP-8931. Add Java version to startup message. Contributed by Eli Collins (Revision 1398998)

        Result = FAILURE
        eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1398998
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/StringUtils.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1228 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1228/ ) HADOOP-8931 . Add Java version to startup message. Contributed by Eli Collins (Revision 1398998) Result = FAILURE eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1398998 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/StringUtils.java
        Hide
        Thomas Graves added a comment -

        I pulled this into branch-0.23 too.

        Show
        Thomas Graves added a comment - I pulled this into branch-0.23 too.
        Thomas Graves made changes -
        Fix Version/s 0.23.6 [ 12323504 ]
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-0.23-Build #443 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/443/)
        HADOOP-8931. Add Java version to startup message. (eli) (Revision 1412294)

        Result = SUCCESS
        tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1412294
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/StringUtils.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #443 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/443/ ) HADOOP-8931 . Add Java version to startup message. (eli) (Revision 1412294) Result = SUCCESS tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1412294 Files : /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/StringUtils.java
        Timur Perelmutov made changes -
        Summary Add Java version to startup message Add Java version to startup message
        Arun C Murthy made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        1m 38s 1 Eli Collins 16/Oct/12 03:29
        Patch Available Patch Available Resolved Resolved
        19h 27m 1 Eli Collins 16/Oct/12 22:57
        Resolved Resolved Closed Closed
        121d 15h 14m 1 Arun C Murthy 15/Feb/13 13:11

          People

          • Assignee:
            Eli Collins
            Reporter:
            Eli Collins
          • Votes:
            0 Vote for this issue
            Watchers:
            9 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development