[HADOOP-8929] Add toString, other improvements for SampleQuantiles

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.0.2-alpha, 3.0.0-alpha1
• Fix Version/s: 2.0.3-alpha
• Component/s: metrics
• Target Version/s: 2.0.2-alpha
• Hadoop Flags: Reviewed
• Assignee: Todd Lipcon
• Reporter: Todd Lipcon
• Created: 15/Oct/12 19:46
• Updated: 12/May/16 18:22
• Resolved: 16/Oct/12 06:07

Description

The new SampleQuantiles class is useful in the context of benchmarks, but currently there is no way to print it out outside the context of a metrics sink. It would be nice to have a convenient way to stringify it for logging, etc.

Also:

• made it Comparable and changed the HashMap to TreeMap so that the printout is in ascending percentile order. Given that this map is always very small, and snapshot() is only called once a minute or so, the runtime/memory differences between treemap and hashmap should be negligible.
• changed the behavior to return null instead of throw, because all the catching, etc, got pretty ugly. In implementing toString, I figured I'd clean up the other behavior along the way.